Franz Liedke
dd17fa3342
Remove unnecessary change
2020-09-18 22:27:11 +02:00
Franz Liedke
db8755d5d9
Remove unrelated change
2020-09-18 22:27:11 +02:00
Franz Liedke
5c2a233b74
Remove unnecessary conditional
...
The filter(Boolean) covers this.
2020-09-18 22:27:10 +02:00
Alexander Skvortsov
4dd0361ccf
Remove unnecessary class name
2020-09-18 22:27:10 +02:00
Alexander Skvortsov
ccd2b0ee0b
Revert diff reduction change
...
Sometimes, items passed to listItems might be null. We still need that filter check
2020-09-18 22:27:10 +02:00
Alexander Skvortsov
b954e79ec8
Move data from vnode
to vnode.state
...
`vnode.state` is persisted, `vnode` might not be
2020-09-18 22:27:09 +02:00
Franz Liedke
bdc64f98a5
I want my small diff back!
2020-09-18 22:27:09 +02:00
Franz Liedke
f9e5aa4193
Email confirmation alert: Simplify implementation
...
Now that we don't mess with component instances anymore, we can follow
normal Mithril patterns.
2020-09-18 22:27:09 +02:00
Franz Liedke
801220cc10
Fix type annotation
2020-09-18 22:27:08 +02:00
Franz Liedke
bd52aaaa61
Fragment: Update documentation
2020-09-18 22:27:08 +02:00
Franz Liedke
4a5d12626b
Revert "Remove deprecated "BC Layers", since BC is broken anyway"
...
This reverts commit 37c2956efae828e4f25448f4fdff33a79ab0aace.
2020-09-18 22:27:08 +02:00
Franz Liedke
1e4a7f3282
props -> attrs in code
2020-09-18 22:27:07 +02:00
Franz Liedke
cbcb0429d0
props -> attrs in comments
2020-09-18 22:27:07 +02:00
Franz Liedke
14b12f8ae8
Revert "Fix Post-actions being on top of Post Controls Dropdown"
...
This reverts commit fa29937d9e4dd868198bc2b003320c8431afed6f.
2020-09-18 22:27:07 +02:00
Franz Liedke
37d7068569
Revert "Run npm audit fix"
...
This reverts commit 791fd306e999066180cb67337566e17fa5e4bb1b.
2020-09-18 22:27:07 +02:00
Franz Liedke
6e1a9193ac
Revert "infrastructure: Run npm audit fix"
...
This reverts commit ff1c52dcf84a4408fdc156a140f8718b401e7d7f.
2020-09-18 22:27:06 +02:00
Franz Liedke
ea6aea409d
TS: Merge shims and tsconfig for now
...
This makes the structure less confusing, as long as the two parts are
not needed.
Once we actually have decided where to move the shared parts (to share
them with bundled and community extensions), and which parts to share,
this can easily be extracted again.
2020-09-18 22:27:06 +02:00
Franz Liedke
d572200cfb
TS: Document shims files
2020-09-18 22:27:06 +02:00
Franz Liedke
e10ebf0489
TS config / shims: Fix indentation / whitespace
2020-09-18 22:27:05 +02:00
Franz Liedke
b251ff0469
Extend documentation
2020-09-18 22:27:05 +02:00
Franz Liedke
4a0947db4b
TS: Be more specific in type assertion
...
See https://stackoverflow.com/a/33404548 .
2020-09-18 22:27:05 +02:00
Alexander Skvortsov
32767d6321
Fix typescript errors
2020-09-18 22:27:04 +02:00
Alexander Skvortsov
27017b7181
Register jQuery with shims
2020-09-18 22:27:04 +02:00
Franz Liedke
bdd30ceecc
Add documentation, keep lifecycle methods on top
2020-09-18 22:27:04 +02:00
Franz Liedke
abc98645a0
Fix typo, reduce diff
2020-09-18 22:27:03 +02:00
Franz Liedke
5d538adc33
Tweak Mithril documentation link
2020-09-18 22:27:03 +02:00
Franz Liedke
6f11567f91
Update comment
...
Who cares about Mithril 0.2? ;)
2020-09-18 22:27:03 +02:00
Alexander Skvortsov
537e2690e8
Replace get first element from filter with find
2020-09-18 22:27:03 +02:00
Franz Liedke
0e715a8c40
Restore comment
...
I love small diffs.
2020-09-18 22:27:02 +02:00
Franz Liedke
383a7e559f
DiscussionListPane: Inject state, extract method
2020-09-18 22:27:02 +02:00
Franz Liedke
aeaa9a4b73
Reuse ComposerPostPreview in ReplyPlaceholder
2020-09-18 22:27:02 +02:00
Franz Liedke
85f8fc52b7
ComposerPostPreview: Add scroll anchoring callback
...
This will be needed to replace the `ReplyPlaceholderPreview` component.
2020-09-18 22:27:01 +02:00
Franz Liedke
174f3aba90
ComposerPostPreview: Allow injecting CSS class
2020-09-18 22:27:01 +02:00
Franz Liedke
47ce93d2fd
Stop rendering previews when composer is hidden
...
This brings this component in line with the `ReplyPlaceholder` one.
2020-09-18 22:27:01 +02:00
Franz Liedke
24935eacaf
ComposerPostPreview: Inject entire composer
2020-09-18 22:27:00 +02:00
Franz Liedke
0f99e7c015
Rename post preview component again
...
I want to reuse it for the reply placeholder as well, and that will
require injecting a composer state instance, so this naming seems to
make more sense.
2020-09-18 22:27:00 +02:00
Franz Liedke
691ae85e50
TextFormatterPreview: Add documentation
2020-09-18 22:27:00 +02:00
Franz Liedke
fb83f8c59c
TextFormatterPreview: Pass in content callback
...
This makes the component itself less dependent on global state, which
has benefits for testability and reusability.
2020-09-18 22:26:59 +02:00
Franz Liedke
a6e6c54972
TextFormatterPreview: Expose in compat
2020-09-18 22:26:59 +02:00
Franz Liedke
6b5bdb5c41
Rename CommentPostPreview -> TextFormatterPreview
...
The idea is to be a bit more precise as to what this component does.
Also, there's already the `PostPreview` component which is actually a
link *to* a preview. Very confusing.
2020-09-18 22:26:59 +02:00
Alexander Skvortsov
d7ef260c54
Run code to rebuild tooltip oncreate AND onupdate
2020-09-18 22:26:58 +02:00
Alexander Skvortsov
571ed8d8e5
Don't store stuff on DOM elements.
2020-09-18 22:26:58 +02:00
Franz Liedke
42ad490096
mapRoutes: Fix outdated link to Mithril docs
2020-09-18 22:26:58 +02:00
Franz Liedke
09bead3ba2
Extend / correct documentation of SubtreeRetainer
2020-09-18 22:26:58 +02:00
Franz Liedke
abb896d430
Extend documentation of withAttr
2020-09-18 22:26:57 +02:00
Alexander Skvortsov
6e7c86ac50
Format
2020-09-18 22:26:57 +02:00
Alexander Skvortsov
2673dd2ee3
Don't show an error in console on promise rejection when not logged in and trying to reply / start a discussion
2020-09-18 22:26:57 +02:00
Alexander Skvortsov
cbd9c8dd4f
Add a workaround for the blank SelectDropdown issue.
...
Workaround explained in the code.
2020-09-18 22:26:56 +02:00
Alexander Skvortsov
29d995de45
Fix NotificationList storing jquery objects
2020-09-18 22:26:42 +02:00
Franz Liedke
a5b2768836
Revert "Use some
for needsRebuild in SubtreeRetainer"
...
This reverts commit 5318bd456856407dd92f44583bed5c88f0813a80.
My bad, I did not realize there was a side effect (storing stuff in
this.data) when suggesting this change. With that, using some() is much
less useful - plus it probably causes a bug because it does not always
iterate over all items once the callback returns true.
2020-09-18 22:26:42 +02:00