Franz Liedke
fc5eddb99d
Default parameter value
2020-08-02 09:25:36 +02:00
Franz Liedke
bad8115a4a
Remove obsolete properties in post stream state
2020-08-02 08:01:55 +02:00
Franz Liedke
1fc76acf06
Stop injecting post stream state into scrubber
2020-08-02 07:56:58 +02:00
Franz Liedke
527d93120a
Shrink the diff, e.g. by moving methods around
2020-08-01 02:59:55 +02:00
Franz Liedke
53582ab999
WIP: Re-work stream, scrubber and state
...
Mostly, this tries to move common logic up to the DiscussionPage as the
lowest common ancestor of these components sharing certain state.
It's still messy, though. :-/
2020-08-01 02:47:36 +02:00
Franz Liedke
6f6a09d7c4
Start decoupling scrolling from state
2020-07-31 23:23:32 +02:00
Franz Liedke
e8394e4a1d
Unify pausing
2020-07-31 16:42:42 +02:00
Franz Liedke
e455e6c431
Restore old implementation of goToLast()
...
It's not clear whether this was intentionally omitted.
2020-07-31 16:13:16 +02:00
Franz Liedke
a044c642f6
Add default parameter value
...
This is actually relied on already by not passing the parameter in other
methods.
2020-07-31 16:12:17 +02:00
Franz Liedke
01384139ef
Encapsulate a bit more logic in the state
2020-07-31 15:42:01 +02:00
Franz Liedke
57f5ad4893
Move method to previous position
2020-07-31 13:27:26 +02:00
Franz Liedke
8b69b24272
Fix docblocks
2020-07-31 13:21:45 +02:00
Franz Liedke
09c722e522
Remove unused prop
2020-07-31 12:14:00 +02:00
Franz Liedke
3ce94757fc
Rename props
2020-07-31 12:13:25 +02:00
Franz Liedke
aae6f24356
Fix docblock
2020-07-31 12:06:33 +02:00
Franz Liedke
1a2f9527fd
Revert formatting changes
2020-07-31 11:32:54 +02:00
Alexander Skvortsov
8c362bf7c7
Don't save index twice in post stream post-load
2020-07-31 11:18:12 +02:00
Alexander Skvortsov
f99f79e3c0
De-propify visible
2020-07-31 11:18:12 +02:00
Alexander Skvortsov
bbd8136695
A bit more cleanup
2020-07-31 11:17:46 +02:00
Alexander Skvortsov
1d8662088f
A bit more cleanup and bugfixes
2020-07-31 11:17:45 +02:00
Alexander Skvortsov
a850f4a6fb
Restore old scrubber index calculation system
2020-07-31 11:17:45 +02:00
Alexander Skvortsov
af55a13c61
A bit more cleanup, UI bugfixes
2020-07-31 11:17:45 +02:00
Alexander Skvortsov
92b62e7ab6
Minor cleanup of PostStreamState methods
2020-07-31 11:17:44 +02:00
Alexander Skvortsov
5ef4de75d1
Fix date not showing up properly
2020-07-31 11:17:44 +02:00
Alexander Skvortsov
88e6be9d0e
When scrolling to first post, scroll all the way to top, simplify scrollToItem promise structure
2020-07-31 11:17:44 +02:00
Alexander Skvortsov
228c7b883d
move index calculation back out of show
2020-07-31 11:17:44 +02:00
Alexander Skvortsov
cdcf64852e
Restore scrubber behavior
2020-07-31 11:17:43 +02:00
Alexander Skvortsov
d20650fb42
Use date of the post in index
2020-07-31 11:17:43 +02:00
Alexander Skvortsov
875a1f70c1
Fix date, index calculation on reload
2020-07-31 11:17:42 +02:00
Alexander Skvortsov
ef206495cd
Try calculating index before redraw to avoid calling redraw immediately after scroll
2020-07-31 11:17:42 +02:00
Alexander Skvortsov
2360745237
Fix jumping around on page reload
2020-07-31 11:17:42 +02:00
Alexander Skvortsov
cc10eaadd2
Get rid of separate system for scrollToLast
2020-07-31 11:17:42 +02:00
Alexander Skvortsov
c98c0b027f
Fix missing method call
2020-07-31 11:17:41 +02:00
Alexander Skvortsov
73507f403a
Don't use anchorScroll on goToNumber, instead scrolling directly to item
2020-07-31 11:17:41 +02:00
Alexander Skvortsov
d3fb5ee77c
Handle scroll to end as a special case of scroll to index to ensure that we get completely to the bottom and flash the bottom element
2020-07-31 11:17:41 +02:00
Alexander Skvortsov
479e5a8cf6
in goToNumber, only redraw when the response has been returned.
2020-07-31 11:17:40 +02:00
Alexander Skvortsov
4bce030115
Use same logic as in updateScrubber to calculate current post number
2020-07-31 11:17:40 +02:00
Alexander Skvortsov
9f2540dbe3
Properly bind loadNext button to the state
2020-07-31 11:17:40 +02:00
Alexander Skvortsov
aa15db6f44
Ensure consistent index in scrubber, rework current post index calculation logic.
2020-07-31 11:17:39 +02:00
Alexander Skvortsov
0c63be527b
Pass in a selector string to anchorScroll instead of a DOM element. Because the DOM element gets destroyed on redraw, it's offset height is interpreted as 0 which throws off our position in the stream.
2020-07-31 11:17:39 +02:00
Alexander Skvortsov
9db2f78939
Incorporate math floor in sanitizeIndex, use that for scrubber index display.
2020-07-31 11:17:39 +02:00
Alexander Skvortsov
9572863648
Add anchorScroll with redraw after loadPromise loads in scrollToItem
2020-07-31 11:17:39 +02:00
Alexander Skvortsov
ac1eef7578
Remove unused anchorScroll import
2020-07-31 11:17:38 +02:00
Alexander Skvortsov
514165c3af
Anchor scroll after loading posts
2020-07-31 11:17:38 +02:00
Alexander Skvortsov
e84960dcd1
Cleanup
2020-07-31 11:17:38 +02:00
Alexander Skvortsov
f8d1c7a317
Add redraws after posts have been loaded from the API
2020-07-31 11:17:37 +02:00
Alexander Skvortsov
ba82969a58
Remove unnecessary redraw
2020-07-31 11:17:37 +02:00
Alexander Skvortsov
b2917c8716
Add more console logs
2020-07-31 11:17:12 +02:00
Alexander Skvortsov
c150c097c1
Add some more debugging flags
2020-07-31 11:17:11 +02:00
Alexander Skvortsov
beab8ce39c
Update scrubber after scrollToItem
2020-07-31 11:17:11 +02:00
