mirror/php-flextype
1
0
Fork 0
mirror of https://github.com/flextype/flextype.git synced 2025-08-28 15:29:59 +02:00
Code Issues Releases Wiki Activity

feat(core): improve dependencies validation for Plugins API #411

Browse Source
This commit is contained in:
Awilum
2020-05-04 17:19:50 +03:00
parent 5604ed6b8e
commit 0c20d59400
1 changed files with 40 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

71
src/flextype/core/Plugins/Plugins.php
View File

@@ -13,6 +13,7 @@ use Flextype\Component\Arr\Arr;
use Flextype\Component\Filesystem\Filesystem;
use Flextype\Component\I18n\I18n;
use Composer\Semver\Comparator;
use Composer\Semver\Semver;
use RuntimeException;
use function array_replace_recursive;
use function count;
@@ -261,41 +262,49 @@ class Plugins
*/
public function getValidPluginsDependencies($plugins) : array
{
// Set verified plugins array
$verified_plugins = [];
// Go through plugins list and verify them.
foreach ($plugins as $plugin_name => $plugin_data) {
if (isset($plugin_data['manifest']['dependencies']['flextype']) &&
Comparator::equalTo($plugin_data['manifest']['dependencies']['flextype'], $this->flextype['registry']->get('flextype.manifest.version'))) {
$plugins[$plugin_name] = $plugin_data;
} else {
unset($plugins[$plugin_name]);
// Set verified true by default
$verified = true;
// If there is any dependencies for this plugin
if (isset($plugin_data['manifest']['dependencies'])) {
// Go through plugin dependencies
foreach ($plugin_data['manifest']['dependencies'] as $dependency => $constraints) {
// Verify flextype version
if ($dependency === 'flextype') {
if (!Semver::satisfies($this->flextype['registry']->get('flextype.manifest.version'), $constraints)) {
$verified = false;
}
} else {
// Verify plugin dependencies
if (!isset($plugins[$dependency])) {
$verified = false;
} else {
$version = $plugins[$dependency]['manifest']['version'];
if (!Semver::satisfies($version, $constraints)) {
$verified = false;
}
}
}
}
}
// If plugin is verified than include it
if ($verified) {
$verified_plugins[$plugin_name] = $plugin_data;
}
}
foreach ($plugins as $plugin_name => $plugin_data) {
$allowed_plugin = true;
if (isset($plugin_data['manifest']['dependencies']['plugins'])) {
foreach ($plugin_data['manifest']['dependencies']['plugins'] as $dependencies_plugin_name => $plugin_value) {
if (isset($plugins[$dependencies_plugin_name]) && $plugin_value == $plugins[$dependencies_plugin_name]['manifest']['version'] ) {
} else {
$allowed_plugin = false;
unset($plugins[$plugin_name]);
}
}
if ($allowed_plugin) {
$plugins[$plugin_name] = $plugin_data;
}
} else {
$plugins[$plugin_name] = $plugin_data;
}
}
return $plugins;
// Return verified plugins list
return $verified_plugins;
}
/**