1
0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-11 23:54:04 +02:00

CS fixes and a BC nitpick

This commit is contained in:
Jordi Boggiano
2014-02-06 13:42:34 +01:00
parent 2afc675520
commit 4814e79f3f

View File

@@ -175,13 +175,18 @@ class HipChatHandler extends SocketHandler
$batchRecords = $this->combineRecords($records); $batchRecords = $this->combineRecords($records);
foreach($batchRecords as $batchRecord) { $handled = false;
foreach ($batchRecords as $batchRecord) {
if ($this->isHandling($batchRecord)) { if ($this->isHandling($batchRecord)) {
$this->write($batchRecord); $this->write($batchRecord);
$handled = true;
} }
} }
if (!$handled) {
return false;
}
return false === $this->bubble; return false === $this->bubble;
} }
@@ -205,7 +210,6 @@ class HipChatHandler extends SocketHandler
$datetime = null; $datetime = null;
foreach ($records as $record) { foreach ($records as $record) {
$record = $this->processRecord($record); $record = $this->processRecord($record);
if ($record['level'] > $level) { if ($record['level'] > $level) {
@@ -230,7 +234,6 @@ class HipChatHandler extends SocketHandler
); );
if (!$this->validateStringLength($batchRecord['formatted'], static::MAXIMUM_MESSAGE_LENGTH)) { if (!$this->validateStringLength($batchRecord['formatted'], static::MAXIMUM_MESSAGE_LENGTH)) {
// Pop the last message and implode the remainging messages // Pop the last message and implode the remainging messages
$lastMessage = array_pop($messages); $lastMessage = array_pop($messages);
$lastFormattedMessage = array_pop($formattedMessages); $lastFormattedMessage = array_pop($formattedMessages);