mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-05 23:25:30 +02:00
Code Issues Releases Wiki Activity

[ticket/10887] Split auto increment test from db tools test.

Browse Source 
Auto increment test does not need any particular columns
and should not depend, in particular, on correct handling
of binary data.

This commit moves auto increment test into its own file and
gives it its own table with a simple schema.

PHPBB3-10887
This commit is contained in:
Oleg Pudeyev 2012-05-10 23:22:35 -04:00
parent 4b3d807293
commit 1019226dfa
2 changed files with 100 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

100
tests/dbal/auto_increment_test.php Normal file
View File

@ -0,0 +1,100 @@
<?php
/**
*
* @package testing
* @copyright (c) 2012 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/
require_once dirname(__FILE__) . '/../../phpBB/includes/functions.php';
require_once dirname(__FILE__) . '/../../phpBB/includes/db/db_tools.php';
class phpbb_dbal_auto_increment_test extends phpbb_database_test_case
{
protected $db;
protected $tools;
protected $table_exists;
protected $table_data;
public function getDataSet()
{
return $this->createXMLDataSet(dirname(__FILE__).'/fixtures/config.xml');
}
protected function setUp()
{
parent::setUp();
$this->db = $this->new_dbal();
$this->tools = new phpbb_db_tools($this->db);
$this->table_data = array(
'COLUMNS' => array(
'c_id' => array('UINT', NULL, 'auto_increment'),
'c_uint' => array('UINT', 4),
),
'PRIMARY_KEY' => 'c_id',
);
$this->tools->sql_create_table('prefix_table_name', $this->table_data);
$this->table_exists = true;
}
protected function tearDown()
{
if ($this->table_exists)
{
$this->tools->sql_table_drop('prefix_table_name');
}
parent::tearDown();
}
static protected function get_default_values()
{
return array(
'c_uint' => 0,
);
}
public function test_auto_increment()
{
$sql = 'DELETE FROM prefix_table_name';
$result = $this->db->sql_query($sql);
$row1 = array_merge(self::get_default_values(), array(
'c_uint' => 1,
));
$row2 = array_merge(self::get_default_values(), array(
'c_uint' => 2,
));
$sql = 'INSERT INTO prefix_table_name ' . $this->db->sql_build_array('INSERT', $row1);
$result = $this->db->sql_query($sql);
$id1 = $this->db->sql_nextid();
$sql = 'INSERT INTO prefix_table_name ' . $this->db->sql_build_array('INSERT', $row2);
$result = $this->db->sql_query($sql);
$id2 = $this->db->sql_nextid();
$this->assertGreaterThan($id1, $id2, 'Auto increment should increase the id value');
$sql = "SELECT *
FROM prefix_table_name WHERE c_id = $id1";
$result = $this->db->sql_query($sql);
$row_actual = $this->db->sql_fetchrow($result);
$this->db->sql_freeresult($result);
$row1['c_id'] = $id1;
$this->assertEquals($row1, $row_actual);
$sql = "SELECT *
FROM prefix_table_name WHERE c_id = $id2";
$result = $this->db->sql_query($sql);
$row_actual = $this->db->sql_fetchrow($result);
$this->db->sql_freeresult($result);
$row2['c_id'] = $id2;
$this->assertEquals($row2, $row_actual);
}
}

45
tests/dbal/db_tools_test.php
View File

@ -189,51 +189,6 @@ class phpbb_dbal_db_tools_test extends phpbb_database_test_case
$this->assertEquals($row_expect[$column_name], $row_actual[$column_name], "Column $column_name of type $type should have equal return and input value.");
}
public function test_auto_increment()
{
$sql = 'DELETE FROM prefix_table_name';
$result = $this->db->sql_query($sql);
$row1 = array_merge(self::get_default_values(), array(
'c_uint' => 1,
'c_vchar' => '1', // these values are necessary to avoid unique index issues
'c_vchar_size' => '1',
));
$row2 = array_merge(self::get_default_values(), array(
'c_uint' => 2,
'c_vchar' => '2',
'c_vchar_size' => '2',
));
$sql = 'INSERT INTO prefix_table_name ' . $this->db->sql_build_array('INSERT', $row1);
$result = $this->db->sql_query($sql);
$id1 = $this->db->sql_nextid();
$sql = 'INSERT INTO prefix_table_name ' . $this->db->sql_build_array('INSERT', $row2);
$result = $this->db->sql_query($sql);
$id2 = $this->db->sql_nextid();
$this->assertGreaterThan($id1, $id2, 'Auto increment should increase the id value');
$sql = "SELECT *
FROM prefix_table_name WHERE c_id = $id1";
$result = $this->db->sql_query($sql);
$row_actual = $this->db->sql_fetchrow($result);
$this->db->sql_freeresult($result);
$row1['c_id'] = $id1;
$this->assertEquals($row1, $row_actual);
$sql = "SELECT *
FROM prefix_table_name WHERE c_id = $id2";
$result = $this->db->sql_query($sql);
$row_actual = $this->db->sql_fetchrow($result);
$this->db->sql_freeresult($result);
$row2['c_id'] = $id2;
$this->assertEquals($row2, $row_actual);
}
public function test_list_columns()
{
$this->assertEquals(