mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-01-17 22:28:46 +01:00
Code Issues Releases Wiki Activity

[task/refactor-db-testcase] Improve error message of db tests

Browse Source 
If database tests cannot be run the error message is ambigous. This
commit makes it clearer:

- whether the supplied dbms is supported by us
- which dbms are supported by us
- whether the required PDO extension is loaded

PHPBB3-10043
This commit is contained in:
Igor Wiedler 2011-02-14 09:15:51 +01:00
parent 6c7f49f561
commit 17b17bc939
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/test_framework/phpbb_database_test_connection_manager.php
View File

@ -76,7 +76,14 @@ class phpbb_database_test_connection_manager
break;
}
$this->pdo = new PDO($dsn, $this->config['dbuser'], $this->config['dbpasswd']);;
try
{
$this->pdo = new PDO($dsn, $this->config['dbuser'], $this->config['dbpasswd']);
}
catch (PDOException $e)
{
throw new Exception("Unable do connect to $dsn with error: {$e->getMessage()}");
}
// good for debug
// $this->pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
@ -330,7 +337,9 @@ class phpbb_database_test_connection_manager
}
else
{
trigger_error('Database unsupported', E_USER_ERROR);
$message = 'Supplied dbms is unsupported, must be one of: ';
$message .= implode(', ', array_keys($available_dbms));
throw new Exception($message);
}
}
}