[ticket/10006] Add phpbb_config::delete

Add the missing `phpbb_config::delete` method to the config class

PHPBB3-10006

phpBB/includes/config/config.php

@@ -103,6 +103,26 @@ class phpbb_config implements ArrayAccess, IteratorAggregate, Countable
 		return count($this->config);
 	}
 
+	/**
+	* Removes a configuration option
+	*
+	* @param  String $key   The configuration option's name
+	* @param  bool   $cache Whether this variable should be cached or if it
+	*                       changes too frequently to be efficiently cached
+	* @return bool          True if the configuration entry was deleted successfully,
+	*                       otherwise false
+	*/
+	public function delete($key, $cache = true)
+	{
+		if (!isset($this->config[$key]))
+		{
+			return false;
+		}
+
+		unset($this->config[$key]);
+		return true;
+	}
+
 	/**
 	* Sets a configuration option's value
 	*

phpBB/includes/config/db.php

@@ -90,6 +90,38 @@ class phpbb_config_db extends phpbb_config
 		parent::__construct($config);
 	}
 
+	/**
+	* Removes a configuration option
+	*
+	* @param  String $key   The configuration option's name
+	* @param  bool   $cache Whether this variable should be cached or if it
+	*                       changes too frequently to be efficiently cached
+	* @return bool          True if the configuration entry was deleted successfully,
+	*                       otherwise false
+	*/
+	public function delete($key, $cache = true)
+	{
+		if (!isset($this->config[$key]))
+		{
+			return false;
+		}
+
+		$sql = 'DELETE FROM ' . $this->table . "
+			WHERE config_name = '" . $this->db->sql_escape($key) . "'";
+		$this->db->sql_query($sql);
+		if (!$this->db->sql_affectedrows())
+		{
+			return false;
+		}
+
+		unset($this->config[$key]);
+
+		if ($cache)
+		{
+			$this->cache->destroy('config');
+		}
+	}
+
 	/**
 	* Sets a configuration option's value
 	*

tests/config/config_test.php

@@ -109,4 +109,13 @@ class phpbb_config_test extends phpbb_test_case
 		$config->increment('foo', 1);
 		$this->assertEquals(27, $config['foo']);
 	}
+
+	public function test_delete()
+	{
+		$config = new phpbb_config(array('foo' => 'bar'));
+
+		$this->assertTrue(isset($config['foo']));
+		$config->delete('foo');
+		$this->assertFalse(isset($config['foo']));
+	}
 }

tests/config/db_test.php

@@ -125,4 +125,11 @@ class phpbb_config_db_test extends phpbb_database_test_case
 		$this->config->increment('foobar', 3);
 		$this->assertEquals(3, $this->config['foobar']);;
 	}
+
+	public function test_delete()
+	{
+		$this->assertTrue(isset($this->config['foo']));
+		$this->config->delete('foo', false);
+		$this->assertFalse(isset($this->config['foo']));
+	}
 }