Merge remote-tracking branch 'Marc/ticket/11859' into develop

* Marc/ticket/11859:
  [ticket/11859] Add missing get_template_name method to test drivers
  [ticket/11859] Make avatar drivers return template filename

phpBB/phpbb/avatar/driver/driver.php

@@ -109,17 +109,6 @@ abstract class driver implements \phpbb\avatar\driver\driver_interface
 		return true;
 	}
 
-	/**
-	* @inheritdoc
-	*/
-	public function get_template_name()
-	{
-		$driver = preg_replace('#^phpbb\\\\avatar\\\\driver\\\\#', '', get_class($this));
-		$template = "ucp_avatar_options_$driver.html";
-
-		return $template;
-	}
-
 	/**
 	* @inheritdoc
 	*/

phpBB/phpbb/avatar/driver/gravatar.php

@@ -146,6 +146,14 @@ class gravatar extends \phpbb\avatar\driver\driver
 		);
 	}
 
+	/**
+	* @inheritdoc
+	*/
+	public function get_template_name()
+	{
+		return 'ucp_avatar_options_gravatar.html';
+	}
+
 	/**
 	* Build gravatar URL for output on page
 	*

phpBB/phpbb/avatar/driver/local.php

@@ -134,6 +134,14 @@ class local extends \phpbb\avatar\driver\driver
 		);
 	}
 
+	/**
+	* @inheritdoc
+	*/
+	public function get_template_name()
+	{
+		return 'ucp_avatar_options_local.html';
+	}
+
 	/**
 	* Get a list of avatars that are locally available
 	* Results get cached for 24 hours (86400 seconds)

phpBB/phpbb/avatar/driver/remote.php

@@ -186,4 +186,12 @@ class remote extends \phpbb\avatar\driver\driver
 			'avatar_height' => $height,
 		);
 	}
+
+	/**
+	* @inheritdoc
+	*/
+	public function get_template_name()
+	{
+		return 'ucp_avatar_options_remote.html';
+	}
 }

phpBB/phpbb/avatar/driver/upload.php

@@ -167,6 +167,14 @@ class upload extends \phpbb\avatar\driver\driver
 		return true;
 	}
 
+	/**
+	* @inheritdoc
+	*/
+	public function get_template_name()
+	{
+		return 'ucp_avatar_options_upload.html';
+	}
+
 	/**
 	* Check if user is able to upload an avatar
 	*

tests/avatar/driver/barfoo.php

@@ -18,4 +18,9 @@ class barfoo extends \phpbb\avatar\driver\driver
 	{
 		return false;
 	}
+
+	public function get_template_name()
+	{
+		return 'barfoo.html';
+	}
 }

tests/avatar/driver/foobar.php

@@ -18,4 +18,9 @@ class foobar extends \phpbb\avatar\driver\driver
 	{
 		return false;
 	}
+
+	public function get_template_name()
+	{
+		return 'foobar.html';
+	}
 }