[ticket/12557] Search, cron and profilefields fixes

PHPBB3-12557

phpBB/phpbb/cron/manager.php

@@ -35,6 +35,8 @@ class manager
 	* Constructor. Loads all available tasks.
 	*
 	* @param array|\Traversable $tasks Provides an iterable set of task names
+	* @param string $phpbb_root_path Relative path to phpBB root
+	* @param string $php_ext PHP extension (php)
 	*/
 	public function __construct($tasks, $phpbb_root_path, $php_ext)
 	{

phpBB/phpbb/cron/task/wrapper.php

@@ -29,6 +29,8 @@ class wrapper
 	* Wraps a task $task, which must implement cron_task interface.
 	*
 	* @param \phpbb\cron\task\task $task The cron task to wrap.
+	* @param string $phpbb_root_path Relative path to phpBB root
+	* @param string $php_ext PHP extension (php)
 	*/
 	public function __construct(\phpbb\cron\task\task $task, $phpbb_root_path, $php_ext)
 	{

phpBB/phpbb/profilefields/type/type_interface.php

@@ -189,8 +189,8 @@ interface type_interface
 	/**
 	* Allows manipulating the intended variables if needed
 	*
-	* @param string	$key			Name of the option
 	* @param int	$step			Step on which the option is hidden
+	* @param string	$key			Name of the option
 	* @param string	$action			Currently performed action (create|edit)
 	* @param array	$field_data		Array with data for this field
 	* @return mixed		Final value of the option

phpBB/phpbb/search/base.php

@@ -86,8 +86,8 @@ class base
 	* Retrieves cached search results
 	*
 	* @param string $search_key		an md5 string generated from all the passed search options to identify the results
-	* @param int	&$result_count	will contain the number of all results for the search (not only for the current page)
-	* @param array 	&$id_ary 		is filled with the ids belonging to the requested page that are stored in the cache
+	* @param int	$result_count	will contain the number of all results for the search (not only for the current page)
+	* @param array 	$id_ary 		is filled with the ids belonging to the requested page that are stored in the cache
 	* @param int 	$start			indicates the first index of the page
 	* @param int 	$per_page		number of ids each page is supposed to contain
 	* @param string $sort_dir		is either a or d representing ASC and DESC
@@ -168,7 +168,7 @@ class base
 	* @param string $keywords 		contains the keywords as entered by the user
 	* @param array	$author_ary		an array of author ids, if the author should be ignored during the search the array is empty
 	* @param int 	$result_count	contains the number of all results for the search (not only for the current page)
-	* @param array	&$id_ary 		contains a list of post or topic ids that shall be cached, the first element
+	* @param array	$id_ary 		contains a list of post or topic ids that shall be cached, the first element
 	* 	must have the absolute index $start in the result set.
 	* @param int 	$start			indicates the first index of the page
 	* @param string $sort_dir		is either a or d representing ASC and DESC

phpBB/phpbb/search/fulltext_mysql.php

@@ -73,6 +73,12 @@ class fulltext_mysql extends \phpbb\search\base
 	 * Creates a new \phpbb\search\fulltext_mysql, which is used as a search backend
 	 *
 	 * @param string|bool $error Any error that occurs is passed on through this reference variable otherwise false
+	 * @param string $phpbb_root_path Relative path to phpBB root
+	 * @param string $phpEx PHP extension (php)
+	 * @param \phpbb\auth\auth $auth Auth object
+	 * @param \phpbb\config\config $config Config object
+	 * @param \phpbb\db\driver\driver_interface Database object
+	 * @param \phpbb\user $user User object
 	 */
 	public function __construct(&$error, $phpbb_root_path, $phpEx, $auth, $config, $db, $user)
 	{

phpBB/phpbb/search/fulltext_postgres.php

@@ -86,6 +86,12 @@ class fulltext_postgres extends \phpbb\search\base
 	 * Creates a new \phpbb\search\fulltext_postgres, which is used as a search backend
 	 *
 	 * @param string|bool $error Any error that occurs is passed on through this reference variable otherwise false
+	 * @param string $phpbb_root_path Relative path to phpBB root
+	 * @param string $phpEx PHP extension (php)
+	 * @param \phpbb\auth\auth $auth Auth object
+	 * @param \phpbb\config\config $config Config object
+	 * @param \phpbb\db\driver\driver_interface Database object
+	 * @param \phpbb\user $user User object
 	 */
 	public function __construct(&$error, $phpbb_root_path, $phpEx, $auth, $config, $db, $user)
 	{

phpBB/phpbb/search/fulltext_sphinx.php

@@ -119,6 +119,12 @@ class fulltext_sphinx
 	 * Creates a new \phpbb\search\fulltext_postgres, which is used as a search backend
 	 *
 	 * @param string|bool $error Any error that occurs is passed on through this reference variable otherwise false
+	 * @param string $phpbb_root_path Relative path to phpBB root
+	 * @param string $phpEx PHP extension (php)
+	 * @param \phpbb\auth\auth $auth Auth object
+	 * @param \phpbb\config\config $config Config object
+	 * @param \phpbb\db\driver\driver_interface Database object
+	 * @param \phpbb\user $user User object
 	 */
 	public function __construct(&$error, $phpbb_root_path, $phpEx, $auth, $config, $db, $user)
 	{