mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-01-17 22:28:46 +01:00
Code Issues Releases Wiki Activity

[ticket/13502] Test getArguments() method of controller resolver

Browse Source 
PHPBB3-13502
This commit is contained in:
Marc Alexander 2016-03-30 17:44:38 +02:00
parent 3f4cf72872
commit 91045879df
2 changed files with 57 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
tests/controller/controller_test.php
View File

@ -11,6 +11,9 @@
*
*/
include_once(__DIR__ . '/ext/vendor2/foo/controller.php');
include_once(__DIR__.'/phpbb/controller/foo.php');
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
@ -64,7 +67,7 @@ class phpbb_controller_controller_test extends phpbb_test_case
$this->assertNull($routes->get('controller_noroute'));
}
public function test_controller_resolver()
protected function get_foo_container()
{
$container = new ContainerBuilder();
// YamlFileLoader only uses one path at a time, so we need to loop
@ -75,26 +78,58 @@ class phpbb_controller_controller_test extends phpbb_test_case
$loader->load('services.yml');
}
// Autoloading classes within the tests folder does not work
// so I'll include them manually.
if (!class_exists('vendor2\\foo\\controller'))
{
include(__DIR__ . '/ext/vendor2/foo/controller.php');
}
if (!class_exists('phpbb\\controller\\foo'))
{
include(__DIR__.'/phpbb/controller/foo.php');
}
return $container;
}
public function test_controller_resolver()
{
$container = $this->get_foo_container();
$resolver = new \phpbb\controller\resolver($container, dirname(__FILE__) . '/');
$symfony_request = new Request();
$symfony_request->attributes->set('_controller', 'foo.controller:handle');
$this->assertEquals($resolver->getController($symfony_request), array(new foo\controller, 'handle'));
$this->assertEquals(array('foo'), $resolver->getArguments($symfony_request, $resolver->getController($symfony_request)));
$symfony_request = new Request();
$symfony_request->attributes->set('_controller', 'core_foo.controller:bar');
$this->assertEquals($resolver->getController($symfony_request), array(new phpbb\controller\foo, 'bar'));
$this->assertEquals(array(), $resolver->getArguments($symfony_request, $resolver->getController($symfony_request)));
}
public function data_get_arguments()
{
return array(
array(array(new foo\controller(), 'handle2'), array('foo', 0)),
array(array(new foo\controller(), 'handle_fail'), array('default'), array('no_default' => 'default')),
array(array(new foo\controller(), 'handle_fail'), array(), array(), '\phpbb\controller\exception', 'CONTROLLER_ARGUMENT_VALUE_MISSING'),
array('', array(), array(), '\ReflectionException', 'Function () does not exist'),
array(new foo\controller(), array(), array(), '\ReflectionException', 'Method __invoke does not exist'),
);
}
/**
* @dataProvider data_get_arguments
*/
public function test_get_arguments($input, $expected, $set_attributes = array(), $exception = '', $exception_message = '')
{
$container = $this->get_foo_container();
$resolver = new \phpbb\controller\resolver($container, dirname(__FILE__) . '/');
$symfony_request = new Request();
foreach ($set_attributes as $name => $value)
{
$symfony_request->attributes->set($name, $value);
}
if (!empty($exception))
{
$this->setExpectedException($exception, $exception_message);
}
$this->assertEquals($expected, $resolver->getArguments($symfony_request, $input));
}
}

12
tests/controller/ext/vendor2/foo/controller.php
View File

@ -11,8 +11,18 @@ class controller
*
* @return null
*/
public function handle()
public function handle($optional = 'foo')
{
return new Response('Test', 200);
}
public function handle2($foo = 'foo', $very_optional = 0)
{
return new Response('Test2', 200);
}
public function handle_fail($no_default)
{
return new Response('Test_fail', 200);
}
}