mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-03-23 17:10:53 +01:00
Code Issues Releases Wiki Activity

Merge pull request #4678 from DavidIQ/ticket/15047

Browse Source 
[ticket/15047] Various db tools fixes for MSSQL
This commit is contained in:
Marc Alexander 2017-01-28 11:09:26 +01:00
commit b859559c8f
No known key found for this signature in database
GPG Key ID: 50E0D2423696F995
1 changed files with 42 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
phpBB/phpbb/db/tools/mssql.php
View File

@ -477,7 +477,7 @@ class mssql extends tools
{
$statements = array();
$statements[] = 'DROP INDEX ' . $table_name . '.' . $index_name;
$statements[] = 'DROP INDEX [' . $table_name . '].[' . $index_name . ']';
return $this->_sql_run_sql($statements);
}
@ -524,7 +524,10 @@ class mssql extends tools
{
$statements = array();
$this->check_index_name_length($table_name, $index_name);
if ($this->is_sql_server_2000())
{
$this->check_index_name_length($table_name, $index_name);
}
$statements[] = 'CREATE UNIQUE INDEX [' . $index_name . '] ON [' . $table_name . ']([' . implode('], [', $column) . '])';
@ -538,7 +541,10 @@ class mssql extends tools
{
$statements = array();
$this->check_index_name_length($table_name, $index_name);
if ($this->is_sql_server_2000())
{
$this->check_index_name_length($table_name, $index_name);
}
// remove index length
$column = preg_replace('#:.*$#', '', $column);
@ -601,7 +607,7 @@ class mssql extends tools
// Change the column
$statements[] = 'ALTER TABLE [' . $table_name . '] ALTER COLUMN [' . $column_name . '] ' . $column_data['column_type_sql'];
if (!empty($column_data['default']))
if (!empty($column_data['default']) && !$this->mssql_is_column_identity($table_name, $column_name))
{
// Add new default value constraint
$statements[] = 'ALTER TABLE [' . $table_name . '] ADD CONSTRAINT [DF_' . $table_name . '_' . $column_name . '_1] ' . $column_data['default'] . ' FOR [' . $column_name . ']';
@ -678,6 +684,37 @@ class mssql extends tools
return $statements;
}
/**
* Checks to see if column is an identity column
*
* Identity columns cannot have defaults set for them.
*
* @param string $table_name
* @param string $column_name
* @return bool true if identity, false if not
*/
protected function mssql_is_column_identity($table_name, $column_name)
{
if ($this->mssql_is_sql_server_2000())
{
// http://msdn.microsoft.com/en-us/library/aa175912%28v=sql.80%29.aspx
// Deprecated in SQL Server 2005
$sql = "SELECT COLUMNPROPERTY(object_id('{$table_name}'), '{$column_name}', 'IsIdentity') AS is_identity";
}
else
{
$sql = "SELECT is_identity FROM sys.columns
WHERE object_id = object_id('{$table_name}')
AND name = '{$column_name}'";
}
$result = $this->db->sql_query($sql);
$is_identity = $this->db->sql_fetchfield('is_identity');
$this->db->sql_freeresult($result);
return (bool) $is_identity;
}
/**
* Get a list with existing indexes for the column
*
@ -717,6 +754,7 @@ class mssql extends tools
AND cols.object_id = ix.object_id
WHERE ix.object_id = object_id('{$table_name}')
AND cols.name = '{$column_name}'
AND ix.is_primary_key = 0
AND ix.is_unique = " . ($unique ? '1' : '0');
}