mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-11 01:55:24 +02:00
Code Issues Releases Wiki Activity

Missed a width/height check for uploaded avatars

Browse Source 
git-svn-id: file:///svn/phpbb/trunk@2372 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Paul S. Owen 2002-03-20 14:38:51 +00:00
parent 8483e9195e
commit f24f3be056
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
phpBB/includes/usercp_avatar.php
View File

@ -135,7 +135,7 @@ function user_avatar_upload($mode, $avatar_mode, $user_id, &$error, &$error_msg,
{
$avatar_data = substr($avatar_data, strlen($avatar_data) - $avatar_filesize, $avatar_filesize);
$tmp_path = ( !$ini_val('safe_mode') ) ? '/tmp' : './' . $board_config['avatar_path'] . "/tmp";
$tmp_path = ( !@$ini_val('safe_mode') ) ? '/tmp' : './' . $board_config['avatar_path'] . "/tmp";
$tmp_filename = tempnam($tmp_path, $userdata['user_id'] . '-');
$fptr = @fopen($tmp_filename, 'wb');
@ -176,6 +176,8 @@ function user_avatar_upload($mode, $avatar_mode, $user_id, &$error, &$error_msg,
$error_msg = ( !empty($error_msg) ) ? $error_msg . '<br />' . $l_avatar_size : $l_avatar_size;
return;
}
list($width, $height) = @getimagesize($avatar_filename);
}
if ( !($imgtype = check_image_type($avatar_filetype, $error, $error_msg)) )
@ -202,7 +204,7 @@ function user_avatar_upload($mode, $avatar_mode, $user_id, &$error, &$error_msg,
}
else
{
if ( $ini_val('open_basedir') != '' )
if ( @$ini_val('open_basedir') != '' )
{
if ( phpversion() < '4.0.3' )
{