mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-07 16:15:22 +02:00
Code Issues Releases Wiki Activity

[ticket/11148] Remove unneeded variable mimetype and use type octet-stream

Browse Source 
The variable $mimetype is not used in the method local_upload() afterwards
so it shouldn't be assigned. The correct default mimetype should be
application/octet-stream and not application/octetstream according to RFC 2046.

PHPBB3-11148
This commit is contained in:
Marc Alexander 2014-06-02 11:57:37 +02:00
parent 3823fe355f
commit ff56f0dcfe
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
phpBB/includes/functions_upload.php
View File

@ -82,7 +82,7 @@ class filespec
if (!$this->mimetype) if (!$this->mimetype)
{ {
$this->mimetype = 'application/octetstream'; $this->mimetype = 'application/octet-stream';
} }
$this->extension = strtolower(self::get_extension($this->realname)); $this->extension = strtolower(self::get_extension($this->realname));
@ -673,7 +673,6 @@ class fileupload
{ {
$upload['name'] = utf8_basename($source_file); $upload['name'] = utf8_basename($source_file);
$upload['size'] = 0; $upload['size'] = 0;
$mimetype = 'application/octet-stream';
} }
else else
{ {