* task/refactor-db-testcase:
[task/refactor-db-testcase] Further improve error messages.
[task/refactor-db-testcase] Do not show db password on connect error
[task/refactor-db-testcase] Improve error message of db tests
[task/refactor-db-testcase] Refactor phpbb_database_test_case
If database tests cannot be run the error message is ambigous. This
commit makes it clearer:
- whether the supplied dbms is supported by us
- which dbms are supported by us
- whether the required PDO extension is loaded
PHPBB3-10043
Move most of the methods to a separate connection manager class. The
test case creates a manager to handle database creation, schema loading
and more. Most of the methods could be simplified because they can
access shared pdo, config and dbms data.
PHPBB3-10043
When displaying the default value for a numeric custom profile field, only use
request_var to obtain the value on creation. When editing, it will always
override the actual value with an empty string, as this is request_var's default
return value.
PHPBB3-8904
There is no reason not to use request_var() here because it is available anyway
since 3afd2c6948e777fde2f43f00bff1659f2691f4d8.
This change especially prevents submitting an array which might then throw an
error in one of the string functions substr() or strpos() later on.
PHPBB3-10038
On 32-bit php, -2147483648, despite fitting in the int type,
is for some reason made into a floating-point value. Use an
explicit cast to make it an integer.
PHPBB3-10020
Due to the usage of `__DIR__` for the file includes the tests can't
be ran on systems with PHP < 5.3. Replace all occurances of
`__DIR__` with `dirname(__FILE__)`.
PHPBB3-10011
The comment in the code says: "We now get the first number passed and will
select the key based upon this number". But the loop over the arguments is not
left and therefore it uses the last int-value not the first one.
PHPBB3-9949
The language pack download page includes index.html files instead of index.htm. It also does not include the new captcha_*.php files which are included since 3.0.6.
PHPBB3-9966
If acm_file cannot open the cache file for writing, it prints a message
to that effect and calls die(). The message itself does not indicate that
it is a fatal error, and someone seeing the message might expect that
inability to write to cache is not fatal.
Make it clear that the error is fatal by printing the word "Fatal" before
the message.
PHPBB3-10014
The "deny" and "access" directives are IP-based in general. Both directives
only support IPv6 from nginx 0.8.22 onwards, on older versions of nginx those
directives have no effect on IPv6 requests. Thus they do not block access for
IPv6 requests.
Adding the "internal" directive blocks external access in general (both IPv4
and IPv6) and makes the web server return a status code 404 (Not Found)
response.
See:
http://nginx.org/en/CHANGEShttp://wiki.nginx.org/HttpCoreModule#internal
PHPBB3-10007
