1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-05 15:16:16 +02:00

134 Commits

Author SHA1 Message Date
Richard McGirr
02b5873442 [ticket/15010] Fix incorrect use of request
https://tracker.phpbb.com/browse/PHPBB3-15010

PHPBB3-15010
2017-01-14 09:18:55 -05:00
Tristan Darricau
809d73ca5e
Merge branch '3.1.x' into 3.2.x
* 3.1.x:
  [ticket/14889] Missing method in profile fields type interface
2016-12-11 20:41:42 +01:00
Tristan Darricau
230e737790
Merge pull request #4558 from javiexin/ticket/14889
[ticket/14889] Missing method in profile fields type interface

* javiexin/ticket/14889:
  [ticket/14889] Missing method in profile fields type interface
2016-12-11 20:41:39 +01:00
Marc Alexander
72529cd179
Merge branch '3.1.x' into 3.2.x 2016-12-05 19:15:37 +01:00
javiexin
591eff9e78 [ticket/14890] Typo in input validation of profile fields of type string
This bug was introduced by PHPBB3-14272

PHPBB3-14890
2016-12-05 18:35:16 +01:00
javiexin
47e418e50e [ticket/14889] Missing method in profile fields type interface
Completes the profile fields type interface by defining a missing
required method for all implementations of a type.

PHPBB3-14889
2016-12-05 01:07:43 +01:00
Marc Alexander
1600d82b77 Merge remote-tracking branch 'origin/ticket/14272' into ticket/14272-3.2.x
Conflicts:
	phpBB/adm/style/acp_icons.html
	phpBB/includes/acp/acp_groups.php
	phpBB/includes/acp/acp_users.php
	phpBB/includes/functions_acp.php
	phpBB/includes/ucp/ucp_groups.php
	phpBB/styles/prosilver/template/ucp_avatar_options_gravatar.html
	phpBB/styles/prosilver/template/ucp_avatar_options_remote.html
	phpBB/styles/subsilver2/template/mcp_topic.html
	phpBB/styles/subsilver2/template/posting_attach_body.html
	phpBB/styles/subsilver2/template/posting_body.html
	phpBB/styles/subsilver2/template/posting_poll_body.html
	phpBB/styles/subsilver2/template/ucp_avatar_options_gravatar.html
	phpBB/styles/subsilver2/template/ucp_avatar_options_remote.html
2016-03-27 09:59:25 +02:00
Marc Alexander
aca6e64669 [ticket/14272] Only use maxlength and size for allowed input elements
PHPBB3-14272
2015-11-06 10:20:05 +01:00
Marc Alexander
942705e6c6 Merge branch '3.1.x' 2015-08-20 15:48:18 +02:00
Marc Alexander
897b9f333b [ticket/14037] Minor coding style improvements to event
PHPBB3-14037
2015-08-20 10:14:07 +02:00
javiexin
cf0170d5e3 [ticket/14037] Allows adapting memberlist profile fields headline
Adds an event to allow modifying the profile fields headline in line
with modifications to profile fields data.

PHPBB3-14037
2015-08-20 10:12:59 +02:00
Gaëtan Muller
f6e06da4c6 [ticket/13455] Update calls to request_var()
PHPBB3-13455
2015-02-03 20:50:40 +01:00
Joas Schilling
d1bff80dd1 [ticket/13528] Return correct translation instead of is_set()
PHPBB3-13528
2015-01-20 22:56:33 +01:00
Joas Schilling
f02dc44a23 Merge pull request #3138 from prototech/ticket/12642
[ticket/12642] Ensure CPF type specific options are set when editing booleans.
2015-01-20 22:46:08 +01:00
Marc Alexander
67c987f0d0 Merge pull request #3166 from nickvergessen/Senky-ticket/12866
[ticket/12866] Wrong profile field validation options
2015-01-10 12:36:49 +01:00
Jakub Senko
b7f69edaa2 [ticket/12866] Assume underscore is part of \w
PHPBB3-12866
2014-11-28 20:00:48 +01:00
rxu
a8c62e707a [ticket/12926] Support for IDN (IRI)
Add international domain name support for URLs.

PHPBB3-12926
2014-11-27 01:18:49 +07:00
Cesar G
d43f196fa6 [ticket/12642] Ensure CPF type specific options are set when editing booleans.
prepare_hidden_fields is expected to return null if the option is not sent
in the request. The boolean method returns false instead, which results in
the options being set as false in hidden fields when accessing the first edit
step.

When checking the "Default value" option, there is also a failure to check
whether the "Field type" option is set to checkbox, thus resulting in this
option getting lost as well.

PHPBB3-12642
2014-11-11 16:48:25 -08:00
Cesar G
ec220d6494 [ticket/13209] Gather language field values for boolean CPF's in all steps.
The user can move back and forth between all three steps and as such the lang
field data should be expected in all steps.

PHPBB3-13209
2014-11-11 16:32:04 -08:00
Cesar G
3108d0b060 [ticket/13209] Fix expected request value of CPF language fields.
Multiple languages can be edited, thus the expected value is an array.

PHPBB3-13209
2014-11-11 16:28:06 -08:00
Joas Schilling
f64a937a57 [ticket/13111] Dropdown options are already an array in the field data
PHPBB3-13111
2014-09-30 12:27:14 +02:00
Joas Schilling
f3fef8934e Merge pull request #2954 from rxu/ticket/13055
[ticket/13055] Fix string profile fields validation to support unicode
2014-09-24 12:25:57 +02:00
rxu
dc65058c20 [ticket/13055] Add string profile fields validation options to support unicode
PHPBB3-13055
2014-09-18 08:19:08 +08:00
Jakub Senko
fcd2a2f186 [ticket/12734] Remove unnecessary error supressing
PHPBB3-12734
2014-09-10 18:37:16 +02:00
Marc Alexander
a6b275de5c [ticket/12794] Properly validate google+ field against valid character set
PHPBB3-12794
2014-08-08 17:06:01 +02:00
Joas Schilling
2f44a865a0 Merge pull request #2477 from n-aleha/ticket/12557ascraeus
[ticket/12557] Fix doc block errors found by Sami for ascraeus

* n-aleha/ticket/12557ascraeus:
  [ticket/12557] Fix load active module description
  [ticket/12557] Fix php file description
  [ticket/12557] Fix post data description for notifications
  [ticket/12557] Fix pass by reference doc blocks
  [ticket/12557] Fix doc block in extension base class
  [ticket/12557] Fix doc block in mimetype guesser
  [ticket/12557] Fix var $preserve_cr description
  [ticket/12557] Fix doc block errors found by Sami
  [ticket/12557] Fix doc block errors found by Sami
  [ticket/12557] Fix doc block errors found by Sami
  [ticket/12557] Template fixes
  [ticket/12557] Search, cron and profilefields fixes
  [ticket/12557] Notification fixes
  [ticket/12557] Fix doc block errors found by Sami pt1
  [ticket/12557] Fix doc block errors found by Sami
  [ticket/12557] Fix doc block errors found by Sami
2014-08-07 12:43:45 +02:00
Shitiz Garg
79cccebc6e [ticket/12910] Set get_name for Google+ fields
PHPBB3-12910
2014-08-03 23:20:53 +05:30
n-aleha
8f2395857e [ticket/12557] Search, cron and profilefields fixes
PHPBB3-12557
2014-08-03 07:06:29 +03:00
Joas Schilling
3df41920f7 Merge pull request #2718 from lucifer4o/ticket/12793
[ticket/12793] String '0' does not display for string profile fields

* lucifer4o/ticket/12793:
  [ticket/12793] Tests (added and changed)
  [ticket/12793] Changing get_profile_contact_value to get_profile_value_raw
  [ticket/12793] String '0' does not display for string profile fields
2014-07-27 20:11:44 +02:00
Stanislav Atanasov
223c634bee [ticket/12793] Changing get_profile_contact_value to get_profile_value_raw
Changing the return to get_profile_value_raw

PHPBB3-12793
2014-07-10 11:46:11 +03:00
Stanislav Atanasov
57bbb4548b [ticket/12793] String '0' does not display for string profile fields
See https://github.com/phpbb/phpbb/pull/2647#discussion_r14503051

PHPBB3-12793
2014-07-10 11:46:00 +03:00
Stanislav Atanasov
27f15c0d5b [ticket/12791] Changed the if check
Removed unneeded variable

PHPBB3-12791
2014-07-10 11:43:52 +03:00
Stanislav Atanasov
690de21134 [ticket/12791] String profile fields do not use links ...
smilies and line breaks in memberlist

The value is overwritten with the contact value
Added aditional check if the field is a contact so we don't overwrite it.

PHPBB3-12791
2014-07-10 11:42:31 +03:00
Joas Schilling
29a07404d3 Merge pull request #2672 from Nicofuma/ticket/12782
[ticket/12782] Use an interface for the phpbb event_dispatcher

* Nicofuma/ticket/12782:
  [ticket/12782] Add doc block
  [ticket/12782] Use an interface for the phpbb event_dispatcher
2014-07-07 20:23:10 +02:00
Joas Schilling
107693ff58 Merge pull request #2647 from Dragooon/ticket/12334
[ticket/12334] Add PROFILE_FIELD_VALUE_RAW template var

* Dragooon/ticket/12334:
  [ticket/12334] Remove profile fields test group
  [ticket/12334] Add additional test for type_string
  [ticket/12334] Add string test for type_int
  [ticket/12334] Improve type_dropdown's test description
  [ticket/12334] Group profile fields test
  [ticket/12334] Change get_profile_value_raw_data to profile_value_raw_data
  [ticket/12334] Add get_profile_value_raw unit test for type_bool
  [ticket/12334] Add get_profile_value_raw unit test for type_date
  [ticket/12334] Add get_profile_value_raw unit tests for type_dropdown
  [ticket/12334] Add get_profile_value_raw unit test for type_string
  [ticket/12334] Add get_profile_value_raw unit test for type_url
  [ticket/12334] Add get_profile_value_raw unit tests for type_int
  [ticket/12334] Removed tests
  [ticket/12334] Dropdowns cannot be tested this way
  [ticket/12334] Added test get_profile_value_raw
  [ticket/12334] Changed from valueid to value_raw
  [ticket/12334] Implemented get_profile_valueid method
  [ticket/12334] Added field_novalue fall-back as requested
  [ticket/12334] Add PROFILE_FIELD_VALUEID template var
2014-07-03 11:21:16 +02:00
Tristan Darricau
eb13b4ae28 [ticket/12782] Use an interface for the phpbb event_dispatcher
PHPBB3-12782
2014-06-28 13:19:55 +02:00
Shitiz Garg
6d464e0bc4 [ticket/12759] Fix type_bool and type_dropdown's UCP fields
PHPBB3-12759
2014-06-27 17:58:28 +05:30
Shitiz Garg
98262a5a17 [ticket/12759] Remove lang_helper from profilefields_manager
No longer required

PHPBB3-12759
2014-06-27 17:48:37 +05:30
Shitiz Garg
2cf4a4f6fe [ticket/12759] Cache all lang_options in lang_helper instead
PHPBB3-12759
2014-06-27 17:48:37 +05:30
Shitiz Garg
c1df2ce62a [ticket/12759] Extra line in profilefields_manager
PHPBB3-12759
2014-06-27 17:48:37 +05:30
Shitiz Garg
c82a0b74cf [ticket/12759] Add phpDoc comments to explain get_option_lang
PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
51bc31da20 [ticket/12759] Little code cleanup
PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
6251d68be4 [ticket/12759] Make sure $field_id has unique elements
Otherwise it would cause a bunch of repetitive IDs passed to the IN clause

PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
aebe03f88c [ticket/12759] Cache the lang options earlier
Previously it would re-run on every post

PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
6cf6ec3354 [ticket/12759] Cache lang options for all fields while displaying
Previously these would be fetched one field at one time, causing a large
number of queries in case there were large number of custom profile fields
and/or unique number of users in areas such as viewing topics. Resolve this
by caching them at once when generating data for displaying them in templates.

PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
6d23cc3a0e [ticket/12759] Allow multiple fields to be loaded via get_option_lang
PHPBB3-12759
2014-06-27 17:48:36 +05:30
PayBas
2b451a174b [ticket/12334] Changed from valueid to value_raw
PHPBB3-12334
2014-06-24 21:47:29 +05:30
PayBas
507eca319d [ticket/12334] Implemented get_profile_valueid method
PHPBB3-12334
2014-06-24 21:47:29 +05:30
PayBas
4169fd65f0 [ticket/12334] Added field_novalue fall-back as requested
PHPBB3-12334
2014-06-24 21:47:29 +05:30
PayBas
08e2c07f0b [ticket/12334] Add PROFILE_FIELD_VALUEID template var
PHPBB3-12334
2014-06-24 21:47:29 +05:30