When performing an action on users in the ACP Inactive Users, such as activating, deleting, or reminding, trigger_error is now called to give a notification that the action was performed
PHPBB3-7598
* Fyorl/ticket/10941: (30 commits)
[ticket/10941] Removed superfluous array
[ticket/10941] File 'txt' now too big so changed tests to reflect that
[ticket/10941] Added a comment to ensure tags stay uppercase
[ticket/10941] Modified tearDown to use DirectoryIterator instead of glob
[ticket/10941] Added tests/upload/fixture/copies to tracking
[ticket/10941] Fixed form test test_too_large
[ticket/10941] Replaced use of English with language system
[ticket/10941] Renamed classes and filenames so that tests run
[ticket/10941] Moved comment into markTestIncomplete parameter
[ticket/10941] Removed manual includes of mock classes
[ticket/10941] Added subdirectory for file operations
[ticket/10941] Added some comments for clarification
[ticket/10941] Fixed a failing test
[ticket/10941] Rearranged tests into their own classes or methods
[ticket/10941] Removed the incomplete mark as is_image is fixed
[ticket/10941] Refactored tearDown to stop iterating over the directory.
[ticket/10941] Refactored init_filespec to return new object.
[ticket/10941] Minor typo fixes
[ticket/10941] Changed assertTrue to assertEquals
[ticket/10941] Now actually checks for the value of errors.
...
Since the is_image change, the filespec class no longer trusts the
browser's reported mimetype and instead checks the file itself. Thus
pretending a text file had the mimetype of an image will no longer
fail, the file will simply not be treated as an image.
PHPBB3-10941
Had to remove one of the tests due to a small limitation with the
functional testing framework. May mark the test as incomplete again
pending further comments.
PHPBB3-10941
Uses phpbb_mock_lang to return the key used when setting errors to
allow that key to be checked for during tests rather than just checking
if any error was set.
PHPBB3-10941
NOTE: test_form_upload() is broken. Uploading files via Symfony fails to
retain $_FILES['fileupload']['type'] even if it set explicitely. This appears
to be a bug in Symfony. Since the current version of filespec::is_image()
relies on the mimetype, these tests will __fail__. filespec::is_image() has
been fixed in https://github.com/phpbb/phpbb3/pull/833 however.
PHPBB3-10941
