Joas Schilling
d8a63047aa
[ticket/11474] Clarify comment with "global" and forum_id = 0
...
Forum ID 0 in permission checks, checks the global moderator permission.
PHPBB3-11405
PHPBB3-11474
2013-03-26 20:20:51 +01:00
Joas Schilling
1af89968dd
[ticket/11474] Check read permission before sending *_in_queue notifications
...
PHPBB3-11405
PHPBB3-11474
2013-03-26 20:20:26 +01:00
Joas Schilling
8a94e08e30
[ticket/11405] Add unit tests for post_in_queue
...
PHPBB3-11405
2013-03-26 20:17:26 +01:00
Joas Schilling
0f204595d9
[ticket/11405] Fix "only variables should be passed by reference"
...
PHPBB3-11405
2013-03-26 20:17:24 +01:00
Joas Schilling
81cf02e057
[ticket/11405] Order users in bookmark, in order to pass postgres tests
...
PHPBB3-11405
2013-03-26 13:54:33 +01:00
Joas Schilling
e20b0a4234
[ticket/11405] Use different fixtures so it's not a total mess
...
PHPBB3-11405
2013-03-26 13:06:04 +01:00
Joas Schilling
7e2f80ec0a
[ticket/11405] Add unit tests for bookmarking
...
PHPBB3-11405
2013-03-26 12:59:35 +01:00
Joas Schilling
cdd45cb8ba
[ticket/11405] Move test to submit_post_base.php and use data sets for testing
...
PHPBB3-11405
2013-03-26 12:58:14 +01:00
Joas Schilling
053c75543d
[ticket/11405] Correctly prefill the tables (missed the posts and not-types)
...
PHPBB3-11405
2013-03-25 15:34:18 +01:00
Joas Schilling
060876e627
[ticket/11405] Add a base class to avoid duplicated setUp() code
...
PHPBB3-11405
2013-03-25 15:16:29 +01:00
Joas Schilling
1259117d21
[ticket/11405] Sort $users array in order to prevent issues on postgres
...
PHPBB3-11405
2013-03-25 15:07:06 +01:00
Joas Schilling
499eded880
[ticket/11405] Add unit tests for quoted users notifications
...
PHPBB3-11405
2013-03-25 15:07:05 +01:00
Joas Schilling
7d5949ae3d
[ticket/11405] Fix some coding style issues
...
PHPBB3-11405
2013-03-25 14:37:22 +01:00
Joas Schilling
a91ffe06c7
[ticket/11405] Send post notifications to forum subscribers
...
Like in 3.0 we should also send notifications about new posts to users
that subscribed to the forum. (Subscriptions are verbose)
PHPBB3-11405
2013-03-25 09:28:53 +01:00
Joas Schilling
bc5f8e30d0
[ticket/11405] Add some basic tests for notifications in submit_post()
...
Poster, should NOT receive a notification
Topic subscribed, should receive a notification
Topic subscribed, but unauthed to read, should NOT receive a notification
Topic subscribed, but already notified, should NOT receive a new notification
Topic and forum subscribed, should receive ONE notification
Forum subscribed, should receive a notification
Forum subscribed, but already notified, should NOT receive a new notification
PHPBB3-11405
2013-03-23 13:20:32 +01:00
Joas Schilling
b51a66b60b
Merge remote-tracking branch 'bantu/ticket/11457' into develop
...
* bantu/ticket/11457:
[ticket/11457] Remove check and include for set_var function. It's not used.
2013-03-18 13:51:30 +01:00
Joas Schilling
99d0c7e62b
Merge remote-tracking branch 'bantu/ticket/11455' into develop
...
* bantu/ticket/11455:
[ticket/11455] Restore alphabetic order (underscore first) in config/tables.yml
2013-03-18 10:42:51 +01:00
Andreas Fischer
3c99a33e87
[ticket/11457] Remove check and include for set_var function. It's not used.
...
PHPBB3-11457
2013-03-17 18:58:43 +01:00
Andreas Fischer
76262f186f
[ticket/11455] Restore alphabetic order (underscore first) in config/tables.yml
...
PHPBB3-11455
2013-03-17 18:31:49 +01:00
Andreas Fischer
51c1ba12c1
Merge remote-tracking branch 'nickvergessen/ticket/11443' into develop
...
* nickvergessen/ticket/11443:
[ticket/11443] Fix Migrator Modules Tool by creating a phpbb_log object
[ticket/11443] Add _test suffix to migration test filenames
2013-03-16 01:44:36 +01:00
Joas Schilling
4168cfd7e6
[ticket/11443] Fix Migrator Modules Tool by creating a phpbb_log object
...
PHPBB3-11443
2013-03-16 01:24:50 +01:00
Joas Schilling
afd3681208
Merge remote-tracking branch 'bantu/ticket/11441' into develop
...
* bantu/ticket/11441:
[ticket/11441] Split user loader tests into multiple test methods.
[ticket/11441] Use setUp() in phpbb_user_loader_test.
[ticket/11441] Update/correct copyright year of user loader test.
[ticket/11441] Correct/fix class name of user loader test.
[ticket/11441] Add _test prefix to user loader test filename.
2013-03-15 19:06:54 +01:00
Joas Schilling
02fd181198
Merge remote-tracking branch 'bantu/ticket/11439' into develop
...
* bantu/ticket/11439:
[ticket/11439] Add _test suffix to notification test filename.
2013-03-15 10:31:59 +01:00
Joas Schilling
2cd1c62403
[ticket/11443] Add _test suffix to migration test filenames
...
PHPBB3-11443
2013-03-15 10:23:14 +01:00
Andreas Fischer
15cade3dc5
[ticket/11439] Add _test suffix to notification test filename.
...
PHPBB3-11439
2013-03-15 10:21:09 +01:00
Andreas Fischer
ba460d98f1
[ticket/11441] Split user loader tests into multiple test methods.
...
PHPBB3-11441
2013-03-15 01:36:05 +01:00
Andreas Fischer
ef1caf6933
[ticket/11441] Use setUp() in phpbb_user_loader_test.
...
PHPBB3-11441
2013-03-15 01:32:33 +01:00
Andreas Fischer
e1e9138c3b
[ticket/11441] Update/correct copyright year of user loader test.
...
PHPBB3-11441
2013-03-15 01:28:27 +01:00
Andreas Fischer
3c09612d36
[ticket/11441] Correct/fix class name of user loader test.
...
PHPBB3-11441
2013-03-15 01:26:26 +01:00
Andreas Fischer
eabcbb9baf
[ticket/11441] Add _test prefix to user loader test filename.
...
PHPBB3-11441
2013-03-15 01:25:10 +01:00
Nathan Guse
d4ee7718b9
Merge remote-tracking branch 'remotes/Marc/ticket/11404' into develop
...
# By Marc Alexander
# Via Marc Alexander
* remotes/Marc/ticket/11404:
[ticket/11404] Remove version ID from manager_test.php file header
[ticket/11404] Add tests for phpbb_avatar_manager::clean_row()
[ticket/11404] Convert manager_test to UNIX line endings
[ticket/11404] Use a default data row if $row is empty in clean_row()
[ticket/11404] Return empty array of avatar data if $row is empty
2013-03-12 14:48:07 -05:00
Nathan Guse
739dbd9e31
Merge remote-tracking branch 'remotes/Marc/ticket/11433' into develop
...
# By Marc Alexander
# Via Marc Alexander
* remotes/Marc/ticket/11433:
[ticket/11433] Rename CSS class "jalert" to "phpbb_alert"
2013-03-12 14:41:54 -05:00
Nathan Guse
04aceaecb6
Merge remote-tracking branch 'remotes/nickv/ticket/11310' into develop
...
# By Joas Schilling
# Via Joas Schilling
* remotes/nickv/ticket/11310:
[ticket/11310] Add hashes to action links to prevent CSRF attacks
2013-03-12 11:41:21 -05:00
Joas Schilling
5eef287646
[ticket/11310] Add hashes to action links to prevent CSRF attacks
...
PHPBB3-11310
2013-03-12 17:19:30 +01:00
Marc Alexander
d378f5ac32
[ticket/11433] Rename CSS class "jalert" to "phpbb_alert"
...
This missing change caused the loading info to appear during ajax
requests. With this patch it will be properly hidden as it should.
PHPBB3-11433
2013-03-12 15:15:21 +01:00
Marc Alexander
4ad8fcbd58
[ticket/11404] Remove version ID from manager_test.php file header
...
PHPBB3-11404
2013-03-11 10:35:18 +01:00
Marc Alexander
fb1984dadb
[ticket/11404] Add tests for phpbb_avatar_manager::clean_row()
...
PHPBB3-11404
2013-03-11 10:34:25 +01:00
Marc Alexander
2ec0dc5b34
[ticket/11404] Convert manager_test to UNIX line endings
...
PHPBB3-11404
2013-03-11 10:34:12 +01:00
Nathaniel Guse
d6930df7a2
Merge remote-tracking branch 'remotes/dhruv/ticket/11303' into develop
...
# By Dhruv
# Via Dhruv
* remotes/dhruv/ticket/11303:
[ticket/11303] rename attribute to timezone-preselect
[ticket/11303] remove additional brackets
[ticket/11303] use S_TZ_PRESELECT in subsilver
[ticket/11303] add S_TZ_PRESELECT template var
2013-03-09 19:08:51 -06:00
Nathaniel Guse
3f5d938a95
Merge remote-tracking branch 'remotes/marc/ticket/11323' into develop
...
# By Marc Alexander
# Via Marc Alexander
* remotes/marc/ticket/11323:
[ticket/11323] Reduce additional code and revert regex to previous one
[ticket/11323] Enable tests for inclusion of defined variables
[ticket/11323] Correctly treat variables in template defines
2013-03-09 19:02:44 -06:00
Nathaniel Guse
48bad80f4a
Merge remote-tracking branch 'remotes/Blitze/ticket/11383' into develop
...
# By OpenShift guest
# Via OpenShift guest
* remotes/Blitze/ticket/11383:
[ticket/11383] Correctly revert modules added/removed by migrator
2013-03-09 18:33:19 -06:00
David King
606e392d40
Merge remote-tracking branch 'EXreaction/ticket/11423' into develop
...
# By Nathaniel Guse
# Via Nathaniel Guse
* EXreaction/ticket/11423:
[ticket/11423] Send unformatted usernames to the email template
2013-03-09 18:38:05 -05:00
Nathaniel Guse
36de18e174
[ticket/11423] Send unformatted usernames to the email template
...
PHPBB3-11423
2013-03-09 09:12:46 -06:00
Nathan Guse
7bb32d27ac
Merge remote-tracking branch 'remotes/nickv/ticket/11421' into develop
...
# By Joas Schilling
# Via Joas Schilling
* remotes/nickv/ticket/11421:
[ticket/11421] Correctly display submit button when needed
2013-03-07 11:33:33 -06:00
Nathan Guse
683e17c403
Merge remote-tracking branch 'remotes/nickv/ticket/11417' into develop
...
# By Joas Schilling
# Via Joas Schilling
* remotes/nickv/ticket/11417:
[ticket/11417] FIx submit button description on notifications options page
2013-03-07 11:33:02 -06:00
Nathan Guse
e826edb6fe
Merge remote-tracking branch 'remotes/nickv/ticket/11390' into develop
...
# By Joas Schilling
# Via Joas Schilling
* remotes/nickv/ticket/11390:
[ticket/11390] Correctly separate list of notifications from header
[ticket/11390] Hide pagination when there are no notifications
2013-03-07 11:32:17 -06:00
Nathan Guse
0c8c8484d0
Merge remote-tracking branch 'remotes/nickv/ticket/11407' into develop
...
# By Joas Schilling
# Via Joas Schilling
* remotes/nickv/ticket/11407:
[ticket/11407] Fix <dfn> description of "notification" option.
2013-03-07 11:31:29 -06:00
Marc Alexander
bb58462724
[ticket/11404] Use a default data row if $row is empty in clean_row()
...
A statically defined $default_row will be used inside the
phpbb_avatar_manager::clean_row() method if the $row passed to it is
empty.
PHPBB3-11404
2013-03-07 13:03:27 +01:00
Joas Schilling
d219eafa16
[ticket/11407] Fix <dfn> description of "notification" option.
...
PHPBB3-11407
2013-03-07 12:18:53 +01:00
Joas Schilling
7ac945358e
[ticket/11390] Correctly separate list of notifications from header
...
PHPBB3-11390
2013-03-07 11:39:55 +01:00