David King
db1d49d559
[feature/controller] Rename get_paths to import_paths_from_finder
...
Also removed unused variable from url_matcher function
PHPBB3-10864
2012-11-16 17:05:46 -05:00
David King
b4eff4f06a
[feature/controller] Remove URL Base from helper class
...
I had forgotten that the container sends the same instance of objects to all
services that request it, so in this case all controllers would share the same
base url path, which is not desired.
PHPBB3-10864
2012-11-16 17:05:45 -05:00
David King
aead33432a
[feature/controller] Remove dumped container when cache is purged
...
PHPBB3-10864
2012-11-16 17:05:44 -05:00
David King
c54c3ee422
[feature/controller] A few minor nitpickings
...
PHPBB3-10864
2012-11-16 17:05:44 -05:00
David King
fa43edd877
[feature/controller] Further separate url matcher functionality
...
PHPBB3-10864
2012-11-16 17:05:43 -05:00
David King
4cb9ec522c
[feature/controller] Separate Kernel listeners into their own classes
...
PHPBB3-10864
2012-11-16 17:05:42 -05:00
David King
196c2d4bc3
[feature/controller] Move new functions to their own file
...
PHPBB3-10864
2012-11-16 17:05:41 -05:00
David King
269a56e2c3
[feature/controller] Undo removal of period in ext.finder service definition
...
PHPBB3-10864
2012-11-16 17:05:41 -05:00
David King
d3aa8823b2
[feature/controller] Use a dumped url matcher class to improve performance
...
PHPBB3-10864
2012-11-16 17:05:40 -05:00
David King
5877bf1b1b
[feature/controller] Update helper service given constructor change
...
PHPBB3-10864
2012-11-16 16:47:32 -05:00
David King
46cb0fb068
[feature/controller] Removed another empty construct method
...
PHPBB3-10864
2012-11-16 16:47:32 -05:00
David King
c6a5699325
[feature/controller-new] Fix line endings
...
PHPBB3-10864
2012-11-16 16:47:31 -05:00
David King
2e59450459
[feature/controller] Use assign_display() instead of return_display()
...
The latter was deemed unnecessary at the moment.
PHPBB3-10864
2012-11-16 16:47:30 -05:00
David King
6900456e90
[feature/controller] Revert changes to template class
...
As per IRC, assign_display() effectively does what return_display() was added
to do, so no change was needed.
PHPBB3-10864
2012-11-16 16:47:29 -05:00
David King
ef46af8298
[feature/controller] Don't attempt to assign if no variable is give
...
PHPBB3-10864
2012-11-16 16:47:29 -05:00
David King
b5255d4ea4
[feature/controller] Fix syntax error in template code
...
PHPBB3-10864
2012-11-16 16:47:28 -05:00
David King
1c5a82c411
[feature/controller] Remove empty __construct() method
...
PHPBB3-10864
2012-11-16 16:47:27 -05:00
David King
79bcbd3691
[feature/controller] Add _controller attribute to Request after instantiation
...
PHPBB3-10864
2012-11-16 16:47:26 -05:00
David King
ac29c7e9d9
[feature/controller] Rework assign_display(), use exceptions instead of return
...
PHPBB3-10864
2012-11-16 16:47:22 -05:00
David King
4b6d538b06
[feature/controller] Rename kernel pass class properly
...
PHPBB3-10864
2012-11-16 16:45:29 -05:00
David King
7687f06961
[feature/controller] Inject dependencies instead of container
...
PHPBB3-10864
2012-11-16 16:45:28 -05:00
David King
6e647cf6e1
[feature/controller] Resolve trivial conflict I missed during rebase
...
PHPBB3-10864
2012-11-16 16:45:27 -05:00
David King
dd1f8a0e55
[feature/controller-new] Call pass to subscribe the Kernel event listener
...
PHPBB3-10864
2012-11-16 16:45:26 -05:00
David King
cba0be96a9
[feature/controller] Fix 403 Forbidden error
2012-11-16 16:25:16 -05:00
David King
4e1f17a87d
[feature/controller] includes/functions.php is included by default
...
PHPBB3-10864
2012-11-16 16:25:15 -05:00
David King
97957d6792
[feature/controller-new] Rename kernel compiler pass class
...
PHPBB3-10864
2012-11-16 16:25:14 -05:00
David King
5c86a1660d
[feature/controller] Don't allow a kernel listener to be added with no method
...
PHPBB3-10864
2012-11-16 16:25:12 -05:00
David King
067a770730
[feature/controller] Transfer kernel-related stuff from container PR
...
PHPBB3-10864
2012-11-16 16:25:10 -05:00
David King
06158693c7
[feature/controller] Implement a front controller
...
PHPBB3-10864
2012-11-16 16:25:09 -05:00
Andreas Fischer
65dde648ca
Merge remote-tracking branch 'imkingdavid/ticket/11211' into develop
...
* imkingdavid/ticket/11211:
[ticket/11211] Fix typo in phpbb_realpath() method name
2012-11-16 21:05:23 +01:00
David King
ca09eb94e3
[ticket/11211] Fix typo in phpbb_realpath() method name
...
PHPBB3-11211
2012-11-16 14:38:53 -05:00
Oleg Pudeyev
1a2dfa6d4c
Merge PR #1074 branch 'develop-olympus' into develop
...
* develop-olympus:
[ticket/11192] Merge dataProvider arrays because the test is the same now.
[ticket/11192] Update $value parameter description to support other types.
[ticket/11192] Mark negative byte numbers as unsupported.
[ticket/11192] Test strings not converted to int/float before.
[ticket/11192] Also test strings, e.g. sums returned by the database.
[ticket/11192] Also test powers of 10 / 1000.
[ticket/11192] Add tests.
[ticket/11192] Add Tebibyte to get_formatted_filesize().
2012-11-16 10:29:22 -05:00
Oleg Pudeyev
af5d8b502e
Merge PR #1074 branch 'bantu/ticket/11192' into develop-olympus
...
* bantu/ticket/11192:
[ticket/11192] Merge dataProvider arrays because the test is the same now.
[ticket/11192] Update $value parameter description to support other types.
[ticket/11192] Mark negative byte numbers as unsupported.
[ticket/11192] Test strings not converted to int/float before.
[ticket/11192] Also test strings, e.g. sums returned by the database.
[ticket/11192] Also test powers of 10 / 1000.
[ticket/11192] Add tests.
[ticket/11192] Add Tebibyte to get_formatted_filesize().
2012-11-16 10:25:06 -05:00
Andreas Fischer
8851f9589a
[ticket/11192] Merge dataProvider arrays because the test is the same now.
...
PHPBB3-11192
2012-11-16 16:20:55 +01:00
Andreas Fischer
efd6f1df63
[ticket/11192] Update $value parameter description to support other types.
...
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Andreas Fischer
7cbd440e7a
[ticket/11192] Mark negative byte numbers as unsupported.
...
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Andreas Fischer
4e3a42f59f
[ticket/11192] Test strings not converted to int/float before.
...
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Andreas Fischer
09c8c58a5c
[ticket/11192] Also test strings, e.g. sums returned by the database.
...
PHPBB3-11192
2012-11-16 08:00:12 +01:00
Andreas Fischer
b7ec639945
[ticket/11192] Also test powers of 10 / 1000.
...
PHPBB3-11192
2012-11-16 08:00:07 +01:00
Oleg Pudeyev
c15b98999e
[ticket/11192] Add tests.
...
PHPBB3-11192
2012-11-15 23:57:55 -05:00
Oleg Pudeyev
9c86f70b4a
Merge PR #1041 branch 'cyberalien/ticket/11175' into develop
...
* cyberalien/ticket/11175:
[ticket/11175] Add microdata to prosilver
[ticket/11175] Add microdata to subsilver2
2012-11-15 22:09:52 -05:00
Oleg Pudeyev
f553635491
Merge PR #1094 branch 'igorw/ticket/11206' into develop
...
* igorw/ticket/11206:
[ticket/11206] Remove includes to non-existent files from download/file.php
2012-11-15 18:49:45 -05:00
Igor Wiedler
d061a5abf8
[ticket/11206] Remove includes to non-existent files from download/file.php
...
This makes avatars work again.
PHPBB3-11206
2012-11-16 00:34:08 +01:00
Igor Wiedler
c27e8f0dd3
Merge remote-tracking branch 'p/ticket/11205' into develop
...
* p/ticket/11205:
[ticket/11205] Fix merge conflict in readme.html.
2012-11-15 23:54:59 +01:00
Oleg Pudeyev
5d0796624f
[ticket/11205] Fix merge conflict in readme.html.
...
PHPBB3-11205
2012-11-15 17:45:00 -05:00
Oleg Pudeyev
109a86520f
Merge PR #1060 branch 'develop-olympus' into develop
...
* develop-olympus:
[ticket/11186] Database unit tests fail on windows using sqlite2
2012-11-15 16:31:03 -05:00
Oleg Pudeyev
17a7c4821a
Merge PR #1060 branch 'nickvergessen/ticket/11186' into develop-olympus
...
* nickvergessen/ticket/11186:
[ticket/11186] Database unit tests fail on windows using sqlite2
2012-11-15 16:00:39 -05:00
Andreas Fischer
3408662e16
Merge remote-tracking branch 'p/ticket/11202' into develop
...
* p/ticket/11202:
[ticket/11202] Check response success before content assertions.
2012-11-15 21:43:33 +01:00
Igor Wiedler
51b07364c4
Merge remote-tracking branch 'p/ticket/11204' into develop
...
* p/ticket/11204:
[ticket/11204] Reindent.
2012-11-15 20:56:57 +01:00
Oleg Pudeyev
8917b31e31
[ticket/11202] Check response success before content assertions.
...
This does not change tests that perform requests which are either
clearly not supposed to succeed or are a gray area.
PHPBB3-11202
2012-11-15 14:54:13 -05:00