* github-nickvergessen/ticket/12286:
[ticket/12286] Reword section about plurals
[ticket/12286] Fix spelling of elephant(s) in the sample
[ticket/12286] Correctly capitalize PHP
[ticket/12286] Fix nesting of ul inside li element
[ticket/12286] Add note that goto should not be used
[ticket/12286] Add section about plurals to the coding guidelines
[ticket/12286] Classes must use the name space
[ticket/12286] Remove section about utf8_normalize_nfc()
[ticket/12286] Use $request->variable() instead of request_var()
[ticket/12286] Function names should be prefixed with phpbb_
[ticket/12286] Add "Since" to template event docs
[ticket/12286] style.php and imagesets dont exist anymore
[ticket/12286] Styles have a phpbb_version and a style_version in 3.1
[ticket/12286] Use UTF8 (c) in style.cfg samples
* github-nickvergessen/ticket/12282:
[ticket/12282] Update new references
[ticket/12282] Update container db mock
[ticket/12282] Add new line at EOF of the interface
[ticket/12282] Use interface for type hinting
[ticket/12282] Use {@inheritDoc} for inherited methods
[ticket/12282] Add Interface for DBAL drivers
* github-nickvergessen/ticket/11352:
[ticket/11352] Add functional tests for disapproving a post/topic
[ticket/11352] Redirect the user back to view*.php after disapproving
* vsephpbb/ticket/11098:
[ticket/11098] Fix error reporting on the autologin key pages
[ticket/11098] Update subsilver2 to also include mark/unmark all buttons
[ticket/11098] HTML Validity fix to Notifications in UCP
[ticket/11098] Add mark/unmark all options to remember me keys
The response is already parsed and when running it through parseJSON returned
null prior to 1.9. Now there's an actual error thrown, so the function is
returning and thus leaving the attachment row intact.
PHPBB3-12375
* paybas/ticket/12369:
[ticket/12369] White-space cleanup
[ticket/12369] Removed template vars initial state
[ticket/12369] Added ACP vars
[ticket/12369] Add template var {BODY_CLASS} to HTML body
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/12349:
[ticket/12349] Fix Sniffer for @license tag
[ticket/12349] Update license header in several new files
* Marc/ticket/12362:
[ticket/12362] Do not use database test case as it's not needed
[ticket/12362] Add tests for schema generator
[ticket/12362] Throw exception in schema generator on unresolvable dependency
Currently, a link to Google and its logo are displayed in the
language/en/help_bbcode.php file to explain how to correctly format tags
and to add an image to a post. However, the Google logo is outdated and
Google does not allow the use of its logo on third-party websites. Plus,
that overload their servers. I used the blue phpBB logo to replace it
because the grey one with transparent background is hardly visible.
Originally, I just refreshed the old Google logo with the new one
(https://www.google.com/images/srpr/logo5w.png) but Joas proposed to use
the phpBB logo, and I agree with him.
PHPBB3-12361
The user should be redirected back to:
- the topic, if he came from viewtopic and the topic still exists
- the forum, if he came from viewtopic, but the topic does not exist anymore
PHPBB3-11352
In 7d8b578 this line was introduced to fix a bug with style.php.
Later since 1d42d1b a new session is always created after
killing the old one.
This causes a duplicated creation of the session everytime
the user logs itself out.
PHPBB3-12360
* Marc/ticket/12150:
[ticket/12150] Use correct license URL in prune shadow migrations file
[ticket/12150] Remove 'after' for columns from migrations file
[ticket/12150] Update schema files for prune shadow topics
[ticket/12150] Use log service instead of add_log() function
[ticket/12150] Use shorter column names for prune settings
[ticket/12150] Add functional tests for pruning shadow topics
[ticket/12150] Add missing space to query for shadow topics
[ticket/12150] Add missing prune settings variables in acp_forums
[ticket/12150] Add file and caller for pruning shadow topics
[ticket/12150] Add prune columns to schema files and migration file
[ticket/12150] Add options to acp
Make sure we throw an exception in the schema generator if we come across an
unresolvable dependency. Otherwise we'll get stuck in a infinite loop that
needs to be cancelled by the user or the maximum execution time.
PHPBB3-12362
