mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-25 04:23:38 +01:00
Code Issues Releases Wiki Activity
16,129 Commits 17 Branches 190 Tags
Commit Graph

16129 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nils Adermann
fd7db5cc1f Merge pull request #1296 from bantu/ticket/11440 
[ticket/11440] Cast values of the $user_ids array to integer before sql_in_set.
 2013-03-31 14:42:43 -07:00
Nils Adermann
133307b6bf Merge pull request #1300 from bantu/ticket/11451 
[ticket/11445] Add abstract class phpbb_notification_method_messenger_ba...
 2013-03-29 08:58:40 -07:00
Nils Adermann
fe93ceb20e Merge pull request #1306 from bantu/ticket/11403 
[ticket/11403] phpbb_notification_manager: Use SQL multi insert in batch...
 2013-03-29 08:56:10 -07:00
Andreas Fischer
b156b22f35 [ticket/11403] Use an instance of phpbb_db_sql_insert_buffer instead. 
PHPBB3-11403
 2013-03-29 16:53:50 +01:00
Andreas Fischer
6910d44154 [ticket/11403] phpbb_notification_manager: Use SQL multi insert in batches. 
PHPBB3-11403
 2013-03-29 16:37:04 +01:00
Nils Adermann
1b71779432 Merge pull request #1285 from EXreaction/ticket/11422 
[ticket/11422] Increment assets when database_update is complete
 2013-03-29 08:29:22 -07:00
Nils Adermann
e91077153e Merge pull request #1315 from bantu/ticket/11469 
[ticket/11469] Add SQL insert buffer allowing easier handling of multi i...
 2013-03-29 08:27:09 -07:00
Andreas Fischer
4bd5f279dc [ticket/11469] Add comment about using bitwise operator. 
PHPBB3-11469
 2013-03-28 00:28:51 +01:00
Andreas Fischer
e3a6935de6 [ticket/11469] Add more table status assertions. 
PHPBB3-11469
 2013-03-28 00:28:51 +01:00
Andreas Fischer
e022a7e8f6 [ticket/11469] Remove comments. Method names should be good enough now. 
PHPBB3-11469
 2013-03-28 00:28:51 +01:00
Andreas Fischer
a04fe625a8 [ticket/11469] Do not repeat markTestSkipped() message. 
PHPBB3-11469
 2013-03-28 00:28:51 +01:00
Andreas Fischer
6f946e2188 [ticket/11469] Refactor get_three_rows() into get_rows($n). 
PHPBB3-11469
 2013-03-28 00:28:51 +01:00
Andreas Fischer
eacd0f3e7d [ticket/11469] Fix spacing in getDataSet(). 
PHPBB3-11469
 2013-03-28 00:28:51 +01:00
Andreas Fischer
c909d9602b [ticket/11469] Do not repeat assert_config_count(2). Also move to setUp(). 
PHPBB3-11469
 2013-03-28 00:28:50 +01:00
Andreas Fischer
b48c4d9549 [ticket/11469] Use setUp() to setup DB and a buffer with size 2. 
PHPBB3-11469
 2013-03-28 00:28:50 +01:00
Andreas Fischer
1bd13acb75 [ticket/11469] Use multi insert property from DB. Do not copy value to buffer. 
PHPBB3-11469
 2013-03-28 00:28:50 +01:00
Andreas Fischer
4132573088 [ticket/11469] Use buffer with a single element instead of extra code path. 
PHPBB3-11469
 2013-03-28 00:28:50 +01:00
Andreas Fischer
b88eb3c8e0 [ticket/11469] Do not repeat row generation. 
PHPBB3-11469
 2013-03-28 00:28:50 +01:00
Andreas Fischer
873f098b6c [ticket/11469] Do not repeat array with three rows. 
PHPBB3-11469
 2013-03-28 00:28:46 +01:00
Andreas Fischer
a534497d82 [ticket/11469] Move protected method to end of test file. 
PHPBB3-11469
 2013-03-28 00:22:07 +01:00
Andreas Fischer
edd4987030 Merge remote-tracking branch 'nickvergessen/ticket/bantu/11469-2' into ticket/11469 
* nickvergessen/ticket/bantu/11469-2:
  [ticket/11469] Cast $result to boolean in insert_all()
  [ticket/11469] Check return values of the functions
  [ticket/11469] Split tests and skip multi_insert if unavailable
 2013-03-27 23:14:38 +01:00
Joas Schilling
c9f059c4f2 [ticket/11469] Cast $result to boolean in insert_all() 
|= returns integer values

PHPBB3-11469
 2013-03-27 20:55:48 +01:00
Joas Schilling
69ad4aab78 [ticket/11469] Check return values of the functions 
PHPBB3-11469
 2013-03-27 20:55:08 +01:00
Joas Schilling
9606ccc202 [ticket/11469] Split tests and skip multi_insert if unavailable 
PHPBB3-11469
 2013-03-27 20:54:20 +01:00
Andreas Fischer
53f9e2131c [ticket/11469] Add note about calling flush() after batch insert is done. 
PHPBB3-11469
 2013-03-27 19:27:27 +01:00
Andreas Fischer
dc766f29b4 [ticket/11469] Have all methods of phpbb_db_sql_insert_buffer provide feedback. 
PHPBB3-11469
 2013-03-27 19:19:26 +01:00
Andreas Fischer
8c5fcac232 [ticket/11469] Add benefits over collecting huge insert arrays to class doc. 
PHPBB3-11469
 2013-03-27 18:22:59 +01:00
Andreas Fischer
55fb87ff18 Merge remote-tracking branch 'nickvergessen/ticket/bantu/11469' into ticket/11469 
* nickvergessen/ticket/bantu/11469:
  [ticket/11469] Use method to check config count, instead of repeating it
  [ticket/11469] Return after sql_multi_insert when multi_insert is false
  [ticket/11469] Add some basic unit tests for phpbb_db_sql_insert_buffer
 2013-03-27 18:11:49 +01:00
Andreas Fischer
43b6ae3fee Merge remote-tracking branch 'phpbb/develop' into ticket/11469 
* phpbb/develop:
  [ticket/11476] Remove pass-by-reference from sql_mutli_insert
  [ticket/11466] Remove old database driver files from PHPUnit exclude
  [ticket/11448] Use of $user_id parameter to mark a user's notifications read
  [ticket/11460] Add default behaviour tests for notification and email types.
  [ticket/11460] Configure functional test board email using dummy SMTP data.
  [ticket/11460] Add test for whether post_email and topic_email are checked.
  [ticket/11460] Add methods for checkbox handling to phpbb_functional_test_case.
  [ticket/11460] Drop incorrect phpbb_notification_{type,method}_ prefix.
 2013-03-27 18:11:38 +01:00
Andreas Fischer
94a15f85a6 [ticket/11469] Add example code to class documentation. 
PHPBB3-11469
 2013-03-27 18:11:31 +01:00
Andreas Fischer
b583f6d8d9 Merge remote-tracking branch 'nickvergessen/ticket/11476' into develop 
* nickvergessen/ticket/11476:
  [ticket/11476] Remove pass-by-reference from sql_mutli_insert
 2013-03-27 17:55:42 +01:00
Joas Schilling
c629b2c7b3 [ticket/11476] Remove pass-by-reference from sql_mutli_insert 
The method never writes to the array passed by reference. So it can be
passed by value instead to avoid certain problems.

PHPBB3-11476
 2013-03-27 15:01:36 +01:00
Joas Schilling
af9f30cd52 [ticket/11469] Use method to check config count, instead of repeating it 
PHPBB3-11469
 2013-03-27 14:09:04 +01:00
Joas Schilling
bf6f2c5875 [ticket/11469] Return after sql_multi_insert when multi_insert is false 
PHPBB3-11469
 2013-03-27 14:00:47 +01:00
Joas Schilling
8dd26dee83 [ticket/11469] Add some basic unit tests for phpbb_db_sql_insert_buffer 
PHPBB3-11469
 2013-03-27 14:00:46 +01:00
Nils Adermann
b7778f7fde Merge remote-tracking branch 'github-bantu/ticket/11460' into develop 
* github-bantu/ticket/11460:
  [ticket/11460] Add default behaviour tests for notification and email types.
  [ticket/11460] Configure functional test board email using dummy SMTP data.
  [ticket/11460] Add test for whether post_email and topic_email are checked.
  [ticket/11460] Add methods for checkbox handling to phpbb_functional_test_case.
  [ticket/11460] Drop incorrect phpbb_notification_{type,method}_ prefix.
 2013-03-27 06:31:53 +01:00
Nils Adermann
c9aa39be5d Merge pull request #1318 from imkingdavid/ticket/11448 
[ticket/11448] Use of $user_id parameter to mark a user's notifications read
 2013-03-26 15:19:28 -07:00
Nils Adermann
59e0196846 Merge pull request #1319 from imkingdavid/ticket/11466 
[ticket/11466] Remove old database driver files from PHPUnit exclude
 2013-03-26 15:16:43 -07:00
David King
6ab9ef54a2 [ticket/11466] Remove old database driver files from PHPUnit exclude 
As per the ticket comments, these can simply be removed, rather than having to
be renamed to the new file locations.

PHPBB3-11466
 2013-03-26 17:21:35 -04:00
David King
6dddc22ec7 [ticket/11448] Use of $user_id parameter to mark a user's notifications read 
Currently, the $user_id is a parameter but is not used. This patch fixes that.

PHPBB3-11448
 2013-03-26 17:07:20 -04:00
Andreas Fischer
fc8bf3f3c7 [ticket/11469] Add comment about using sql_multi_insert when not buffering. 
PHPBB3-11469
 2013-03-25 17:01:44 +01:00
Andreas Fischer
d3decaeedf [ticket/11460] Add default behaviour tests for notification and email types. 
PHPBB3-11460
 2013-03-24 23:42:13 +01:00
Andreas Fischer
02817158fc [ticket/11460] Configure functional test board email using dummy SMTP data. 
PHPBB3-11460
 2013-03-22 22:42:05 +01:00
Andreas Fischer
69df6b49db [ticket/11460] Add test for whether post_email and topic_email are checked. 
PHPBB3-11460
 2013-03-22 22:16:24 +01:00
Andreas Fischer
16a6025372 [ticket/11469] Add SQL insert buffer allowing easier handling of multi inserts. 
1. Tries to prevent going over max packet size by flushing to the database
   after a certain number of rows have been added.
2. Because of 1., it is less likely to reach a connection timeout when
   inserting a huge number of rows.
3. By flushing the buffer when a certain size is reached, memory usage should
   be lower compared to building the whole insert row set first.

PHPBB3-11469
 2013-03-21 23:12:31 +01:00
Andreas Fischer
15aec0bbb2 [ticket/11460] Add methods for checkbox handling to phpbb_functional_test_case. 
PHPBB3-11460
 2013-03-21 03:07:50 +01:00
Oleg Pudeyev
8b464e87f0 Merge PR #1298 branch 'nickvergessen/ticket/11438' into develop 
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/11438:
  [ticket/11438] Add spaces after # comment start and before \ line breaks
  [ticket/11438] Add helpful comments from sample config to ACP output
  [ticket/11438] Add empty sql_query_pre to delta-source
  [ticket/11438] Move backslash to concatenate the query strings correctly
  [ticket/11438] Update sphinx.sample.conf to one provided by config_generate()
 2013-03-20 11:43:14 -04:00
Andreas Fischer
1ac94699e4 [ticket/11460] Drop incorrect phpbb_notification_{type,method}_ prefix. 
PHPBB3-11460
 2013-03-19 19:25:34 +01:00
Joas Schilling
b51a66b60b Merge remote-tracking branch 'bantu/ticket/11457' into develop 
* bantu/ticket/11457:
  [ticket/11457] Remove check and include for set_var function. It's not used.
 2013-03-18 13:51:30 +01:00
Joas Schilling
99d0c7e62b Merge remote-tracking branch 'bantu/ticket/11455' into develop 
* bantu/ticket/11455:
  [ticket/11455] Restore alphabetic order (underscore first) in config/tables.yml
 2013-03-18 10:42:51 +01:00