mirror of
https://github.com/phpbb/phpbb.git
synced 2025-01-19 15:17:16 +01:00
Varun Agrawal
285b7a1f4c
[ticket/12355] Topic Tools not fully updated when subscribing/bookmarking
The Topic Tools menu appears at the top of a topic page and again at the bottom of a topic page. When you use the Topic Tools menu to Bookmark or Subscribe to a Topic, the menu item you chose is updated to reflect that, by switching to say Unsubscribe topic or Remove from Bookmarks. However, this change is not mirrored in the other Topic Tools menu at the other location on the page. Both Topic Tools menus should be updated during the AJAX event, so that they always show the same options to the user. It is solved by creating a data-update-all attribute which contains all the class/ID that will update when topic tool is clicked PHPBB3-12355
ABOUT
phpBB is a free bulletin board written in PHP.
COMMUNITY
Find support and lots more on phpBB.com! Discuss the development on area51.
INSTALLING DEPENDENCIES
To be able to run an installation from the repo (and not from a pre-built package) you need to run the following commands to install phpBB's dependencies.
cd phpBB
php ../composer.phar install --dev
CONTRIBUTE
- Create an account on phpBB.com
- Create a ticket (unless there already is one)
- Read our Git Contribution Guidelines; if you're new to git, also read the introduction guide
- Send us a pull request
AUTOMATED TESTING
We have unit and functional tests in order to prevent regressions. You can view the bamboo continuous integration here or check our travis build below:
LICENSE
Description
Languages
PHP
86.9%
HTML
8.5%
JavaScript
2.7%
CSS
1.6%
Shell
0.2%