mirror/php-web-maker
1
0
Fork 0
mirror of https://github.com/chinchang/web-maker.git synced 2025-07-13 18:16:19 +02:00
Code Issues Releases Wiki Activity

Remove some duplciate code

Browse Source 
Eslint complexity drops from 27 to 25
This commit is contained in:
Andrew Luca
2017-12-27 00:56:10 +02:00
parent d6d205d83e
commit 7699d213d1
1 changed files with 5 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/script.js
View File

@ -2174,30 +2174,18 @@ globalConsoleContainerEl, externalLibrarySearchInput, keyboardShortcutsModal
closeAllOverlays(); closeAllOverlays();
} }
if (ARROW_DOWN && isSavedItemsPaneOpen) { if (isSavedItemsPaneOpen && (ARROW_DOWN || ARROW_UP)) {
// Return if no items present. // Return if no items present.
if (!$all('.js-saved-item-tile').length) { if (!$all('.js-saved-item-tile').length) {
return; return;
} }
const method = ARROW_DOWN ? 'nextUntil' : 'previousUntil'
selectedItemElement = $('.js-saved-item-tile.selected'); selectedItemElement = $('.js-saved-item-tile.selected');
if (selectedItemElement) { if (selectedItemElement) {
selectedItemElement.classList.remove('selected'); selectedItemElement.classList.remove('selected');
selectedItemElement selectedItemElement[method]('.js-saved-item-tile:not(.hide)')
.nextUntil('.js-saved-item-tile:not(.hide)')
.classList.add('selected');
} else {
$('.js-saved-item-tile:not(.hide)').classList.add('selected');
}
$('.js-saved-item-tile.selected').scrollIntoView(false);
} else if (ARROW_UP && isSavedItemsPaneOpen) {
if (!$all('.js-saved-item-tile').length) {
return;
}
selectedItemElement = $('.js-saved-item-tile.selected');
if (selectedItemElement) {
selectedItemElement.classList.remove('selected');
selectedItemElement
.previousUntil('.js-saved-item-tile:not(.hide)')
.classList.add('selected'); .classList.add('selected');
} else { } else {
$('.js-saved-item-tile:not(.hide)').classList.add('selected'); $('.js-saved-item-tile:not(.hide)').classList.add('selected');