mirror of
https://github.com/chinchang/web-maker.git
synced 2025-07-25 16:01:14 +02:00
some a11y improvements. stop saved item pane for tabbing when hidden
This commit is contained in:
@@ -63,6 +63,7 @@ export default class Modal extends Component {
|
||||
return (
|
||||
<Portal into="body">
|
||||
<div
|
||||
role="dialog"
|
||||
class={`${this.props.extraClasses || ''} modal is-modal-visible ${
|
||||
this.props.small ? 'modal--small' : ''
|
||||
}`}
|
||||
|
@@ -150,11 +150,14 @@ export default class SavedItemPane extends Component {
|
||||
id="js-saved-items-pane"
|
||||
class={`saved-items-pane ${isOpen ? 'is-open' : ''}`}
|
||||
onKeyDown={this.keyDownHandler.bind(this)}
|
||||
aria-hidden={isOpen}
|
||||
tabIndex={`${isOpen ? 0 : -1}`}
|
||||
>
|
||||
<button
|
||||
onClick={this.onCloseIntent.bind(this)}
|
||||
class="btn saved-items-pane__close-btn"
|
||||
id="js-saved-items-pane-close-btn"
|
||||
aria-label="Close saved creations pane"
|
||||
>
|
||||
X
|
||||
</button>
|
||||
|
@@ -1043,6 +1043,7 @@ body > #demo-frame {
|
||||
width: 450px;
|
||||
padding: 20px 30px;
|
||||
z-index: 6;
|
||||
visibility: hidden; /* prevents tabbing */
|
||||
background-color: var(--color-popup);
|
||||
transition: 0.3s cubic-bezier(1, 0.13, 0.21, 0.87);
|
||||
transition-property: transform;
|
||||
@@ -1051,6 +1052,7 @@ body > #demo-frame {
|
||||
}
|
||||
|
||||
.saved-items-pane.is-open {
|
||||
visibility: visible;
|
||||
transition-duration: 0.4s;
|
||||
transform: translateX(0);
|
||||
}
|
||||
|
Reference in New Issue
Block a user