mirror/ripme
1
0
Fork 0
mirror of https://github.com/RipMeApp/ripme.git synced 2025-08-30 17:20:20 +02:00
Code Issues Releases Wiki Activity

improved logging message and added comment for timeouts

Browse Source
This commit is contained in:
cyian-1756
2018-07-31 16:55:21 -04:00
parent 77a64a1dd7
commit d71addb8a7
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/com/rarchives/ripme/ripper/DownloadFileThread.java
View File

@@ -110,6 +110,8 @@ class DownloadFileThread extends Thread {
huc = (HttpURLConnection) urlToDownload.openConnection();
}
huc.setInstanceFollowRedirects(true);
// It is important to set both ConnectTimeout and ReadTimeout. If you don't then ripme will wait forever
// for the server to send data after connecting.
huc.setConnectTimeout(TIMEOUT);
huc.setReadTimeout(TIMEOUT);
huc.setRequestProperty("accept", "*/*");
@@ -225,7 +227,9 @@ class DownloadFileThread extends Thread {
fos.close();
break; // Download successful: break out of infinite loop
} catch (SocketTimeoutException timeoutEx) {
logger.error(url.toExternalForm() + " timedout!");
// Handle the timeout
logger.error("[!] " + url.toExternalForm() + " timedout!");
// Download failed, break out of loop
break;
} catch (HttpStatusException hse) {
logger.debug("HTTP status exception", hse);