mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-19 13:41:19 +02:00
Code Issues Releases Wiki Activity

IE11 html serializer parser fix (#2087)

Browse Source 
#### Is this adding or improving a _feature_ or fixing a _bug_?

This should fix `Unable to get property 'childNodes' of undefined or null reference` error in IE11 when using slate-html-serializer and deserializing an empty string (#1757, #1756).

#### What's the new behavior?

The `defaultParseHtml` now returns an empty body element if the parsed body is null. 

I tested this in the latest Chrome, Firefox and Safari, and they all seemed to work similarly. If the html param was an empty string, `parseFromString` returned a document element, which had a body property which was an empty body element. In IE11 though the body property was null, which caused the undefined or null reference later.

#### Have you checked that...?

* [x] The new code matches the existing patterns and styles.
* [x] The tests pass with `yarn test`.
* [x] The linter passes with `yarn lint`. (Fix errors with `yarn prettier`.)
* [x] The relevant examples still work. (Run examples with `yarn watch`.)
This commit is contained in:
danielsarin
2018-08-17 01:05:08 +03:00
committed by Ian Storm Taylor
parent 183a5d36ff
commit 4d31983a94
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/slate-html-serializer/src/index.js
View File

@@ -78,7 +78,8 @@ function defaultParseHtml(html) {
const parsed = new DOMParser().parseFromString(html, 'text/html')
const { body } = parsed
return body
// COMPAT: in IE 11 body is null if html is an empty string
return body || window.document.createElement('body')
}
/**