mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-14 03:03:58 +02:00
Code Issues Releases Wiki Activity

Add warning when passing an node to a method accepting a key

Browse Source
This commit is contained in:
Samy Pesse
2016-11-03 00:31:29 +01:00
parent 4ffee3d749
commit 94d1a5434e
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/utils/normalize.js
View File

@@ -6,6 +6,7 @@ import Data from '../models/data'
import Mark from '../models/mark'
import Selection from '../models/selection'
import Text from '../models/text'
import warning from './warning'
import typeOf from 'type-of'
/**
@@ -58,13 +59,14 @@ function inline(value) {
*/
function key(value) {
if (typeOf(value) == 'string') return value
warning('Passing a node instead of a key to a method accepting a key can reduce performances')
if (value instanceof Block) return value.key
if (value instanceof Document) return value.key
if (value instanceof Inline) return value.key
if (value instanceof Text) return value.key
if (typeOf(value) == 'string') return value
throw new Error(`Invalid \`key\` argument! It must be either a block, an inline, a text, or a string. You passed: "${value}".`)
}
@@ -221,4 +223,3 @@ export default {
selection,
selectionProperties,
}