mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-07-31 20:40:19 +02:00
Code Issues Releases Wiki Activity

When removing the node containing the cursor, always prefer placing the cursor in a sibling text node (#5923)

Browse Source 
* Add tests describing the selection after the current node is removed

* Always prefer placing the cursor in a sibling text node after removal

* Add changeset
This commit is contained in:
Joe Anderson
2025-07-26 07:44:08 +01:00
committed by GitHub
parent 7657838d4e
commit ba33735a8c
12 changed files with 318 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
.changeset/stupid-ants-buy.md Normal file
View File

@@ -0,0 +1,9 @@
---
'slate': minor
---
- When removing a text node containing the cursor, always perfer placing the cursor in a sibling text node if one exists.
- Previously, the selection would enter a sibling inline in some circumstances, even when a sibling text node was available.
- The most noticeable effect of this change occurs when pressing backspace at the start of line N when the last non-empty node in line N-1 is an inline.
- Before, the cursor would be placed inside the inline.
- Now, the cursor is placed outside the inline.

6
packages/slate/src/interfaces/transforms/general.ts
View File

@@ -246,8 +246,10 @@ export const GeneralTransforms: GeneralTransforms = {
let preferNext = false
if (prev && next) {
if (Path.equals(next[1], path)) {
preferNext = !Path.hasPrevious(next[1])
if (Path.isSibling(prev[1], path)) {
preferNext = false
} else if (Path.equals(next[1], path)) {
preferNext = true
} else {
preferNext =
Path.common(prev[1], path).length <

37
packages/slate/test/operations/remove_node/cursor-aunt-text-after.tsx Normal file
View File

@@ -0,0 +1,37 @@
/** @jsx jsx */
import { jsx } from '../../'
export const input = (
<editor>
<element>
<text />
<inline>
<text id="0">a</text>
<text id="1">
<cursor />
</text>
</inline>
<text>b</text>
</element>
</editor>
)
export const operations = [
{
type: 'remove_node',
path: [0, 1, 1],
node: { text: '', id: '1' },
},
]
export const output = (
<editor>
<element>
<text />
<inline>
<text id="0">
a<cursor />
</text>
</inline>
<text>b</text>
</element>
</editor>
)

37
packages/slate/test/operations/remove_node/cursor-aunt-text-before.tsx Normal file
View File

@@ -0,0 +1,37 @@
/** @jsx jsx */
import { jsx } from '../../'
export const input = (
<editor>
<element>
<text>a</text>
<inline>
<text id="0">
<cursor />
</text>
<text id="1">b</text>
</inline>
<text />
</element>
</editor>
)
export const operations = [
{
type: 'remove_node',
path: [0, 1, 0],
node: { text: '', id: '0' },
},
]
export const output = (
<editor>
<element>
<text>a</text>
<inline>
<text id="1">
<cursor />b
</text>
</inline>
<text />
</element>
</editor>
)

35
packages/slate/test/operations/remove_node/cursor-sibling-inline-after.tsx Normal file
View File

@@ -0,0 +1,35 @@
/** @jsx jsx */
import { jsx } from '../../'
export const input = (
<editor>
<element>a</element>
<element>
<text>
<cursor />
</text>
<inline>b</inline>
<text />
</element>
</editor>
)
export const operations = [
{
type: 'remove_node',
path: [1, 0],
node: { text: '' },
},
]
export const output = (
<editor>
<element>a</element>
<element>
{/* Recreated by normalizer */}
<text />
<inline>
<cursor />b
</inline>
<text />
</element>
</editor>
)

33
packages/slate/test/operations/remove_node/cursor-sibling-inline-before-text-after.tsx Normal file
View File

@@ -0,0 +1,33 @@
/** @jsx jsx */
import { jsx } from '../../'
export const input = (
<editor>
<element>
<text />
<inline>a</inline>
<text id="0">
<cursor />
</text>
<text id="1">b</text>
</element>
</editor>
)
export const operations = [
{
type: 'remove_node',
path: [0, 2],
node: { text: '', id: '0' },
},
]
export const output = (
<editor>
<element>
<text />
<inline>a</inline>
<text id="1">
<cursor />b
</text>
</element>
</editor>
)

35
packages/slate/test/operations/remove_node/cursor-sibling-inline-before.tsx Normal file
View File

@@ -0,0 +1,35 @@
/** @jsx jsx */
import { jsx } from '../../'
export const input = (
<editor>
<element>
<text />
<inline>a</inline>
<text>
<cursor />
</text>
</element>
<element>b</element>
</editor>
)
export const operations = [
{
type: 'remove_node',
path: [0, 2],
node: { text: '' },
},
]
export const output = (
<editor>
<element>
<text />
<inline>
a<cursor />
</inline>
{/* Recreated by normalizer */}
<text />
</element>
<element>b</element>
</editor>
)

31
packages/slate/test/operations/remove_node/cursor-sibling-text-after.tsx Normal file
View File

@@ -0,0 +1,31 @@
/** @jsx jsx */
import { jsx } from 'slate-hyperscript'
export const input = (
<editor>
<element>a</element>
<element>
<text id="0">
<cursor />
</text>
<text id="1">b</text>
</element>
</editor>
)
export const operations = [
{
type: 'remove_node',
path: [1, 0],
node: { text: '', id: '0' },
},
]
export const output = (
<editor>
<element>a</element>
<element>
<text id="1">
<cursor />b
</text>
</element>
</editor>
)

33
packages/slate/test/operations/remove_node/cursor-sibling-text-before-inline-after.tsx Normal file
View File

@@ -0,0 +1,33 @@
/** @jsx jsx */
import { jsx } from '../../'
export const input = (
<editor>
<element>
<text id="0">a</text>
<text id="1">
<cursor />
</text>
<inline>b</inline>
<text />
</element>
</editor>
)
export const operations = [
{
type: 'remove_node',
path: [0, 1],
node: { text: '', id: '1' },
},
]
export const output = (
<editor>
<element>
<text id="0">
a<cursor />
</text>
<inline>b</inline>
<text />
</element>
</editor>
)

31
packages/slate/test/operations/remove_node/cursor-sibling-text-before.tsx Normal file
View File

@@ -0,0 +1,31 @@
/** @jsx jsx */
import { jsx } from 'slate-hyperscript'
export const input = (
<editor>
<element>
<text id="0">a</text>
<text id="1">
<cursor />
</text>
</element>
<element>b</element>
</editor>
)
export const operations = [
{
type: 'remove_node',
path: [0, 1],
node: { text: '', id: '1' },
},
]
export const output = (
<editor>
<element>
<text id="0">
a<cursor />
</text>
</element>
<element>b</element>
</editor>
)

31
packages/slate/test/operations/remove_node/cursor-sibling-text-both-sides.tsx Normal file
View File

@@ -0,0 +1,31 @@
/** @jsx jsx */
import { jsx } from 'slate-hyperscript'
export const input = (
<editor>
<element>
<text id="0">a</text>
<text id="1">
<cursor />
</text>
<text id="2">b</text>
</element>
</editor>
)
export const operations = [
{
type: 'remove_node',
path: [0, 1],
node: { text: '', id: '1' },
},
]
export const output = (
<editor>
<element>
<text id="0">
a<cursor />
</text>
<text id="2">b</text>
</element>
</editor>
)

5
packages/slate/test/transforms/delete/point/inline-void-reverse.tsx
View File

@@ -25,10 +25,9 @@ export const output = (
<block>
<text />
<inline void>
<text>
<cursor />
</text>
<text />
</inline>
<cursor />
word
</block>
</editor>