mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-09-03 12:12:39 +02:00
Code Issues Releases Wiki Activity

Omit focus change when traveling in history (#1330)

Browse Source 
* omit focus change on redo/undo

* use loash instead of delete

* replace ternary operator
This commit is contained in:
Yifeng Wang
2017-10-30 11:57:50 -05:00
committed by Ian Storm Taylor
parent 0dc1f3d06e
commit d0172eac17
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
packages/slate/src/changes/on-history.js
View File

@@ -1,5 +1,6 @@
import invert from '../operations/invert'
import omit from 'lodash/omit'
/**
* Changes.
@@ -30,7 +31,13 @@ Changes.redo = (change) => {
// Replay the next operations.
next.forEach((op) => {
change.applyOperation(op, { save: false })
// When the operation mutates selection, omit its `isFocused` props to
// prevent editor focus changing during continuously redoing.
let { type, properties } = op
if (type === 'set_selection') {
properties = omit(properties, 'isFocused')
}
change.applyOperation({ ...op, properties }, { save: false })
})
// Update the history.
@@ -60,8 +67,14 @@ Changes.undo = (change) => {
redos = redos.push(previous)
// Replay the inverse of the previous operations.
previous.slice().reverse().map(invert).forEach((inverse) => {
change.applyOperation(inverse, { save: false })
previous.slice().reverse().map(invert).forEach((inverseOp) => {
// When the operation mutates selection, omit its `isFocused` props to
// prevent editor focus changing during continuously undoing.
let { type, properties } = inverseOp
if (type === 'set_selection') {
properties = omit(properties, 'isFocused')
}
change.applyOperation({ ...inverseOp, properties }, { save: false })
})
// Update the history.