mirror of
https://github.com/ianstormtaylor/slate.git
synced 2025-02-01 13:18:29 +01:00
8f9bfdac2b
* Use slate rather than relative path * Move benchmark to one dir * Use slate-* instead of relative path * Before and After Function * Remove un-necessary cross-env * Hard fix * Lint the hard fix * Reset memory in bench() * Working on Benchmark Frameworks * Rename to slate-dev-benchmark * Add packages * Fix prettier bug * Benchmark framework is in working * Do not log in test * max times test * mute logger in test * add hr time * Better support for maxTime; add support of split runs to save memory space * Fix maxTries * Add global.gc * Global gc for each bench * Better test interface * Test max-time * Test max-time done * Add Benchmark among packages * Starting to get benchmark running * Pure Node lib * Change babelrc for pure Node benchmark * Moving Benchmarks * Get benchmark and test running * Get benchmark for slate-html-serializer * add slate-react * add slate/changes * all benchmarks are converted * Run benchmark by yarn * Run benchmark with expose-gc * Annotate Bench.js * Do not bundle slate-dev-benchmark in rollup * Add annotation * Allow config file to enable part benchmark compare * Add config for compare * support compare.js * Do not re-allocate memory; due to a large heap taken influence result * Render with Decorations * get active marks at range * Fix bug in showing percents * Fix percent showing bug * chore: add more benches * Better output of benchmark * Fix linting * decoration and normal as different benchmark test * Fix deserialize benchmark * README.md * Fix Readme.md * README.md * block-spacing config * safer user config loading * use package.json to load package in test * Consistent linting * move components to parent directory * Annotation styling in package * margin line before multi-line block * Fix naive bug * Fix naive bug * Fix a blank line * only log user and hr * Better name * Better annotation for runBundleTasks * Fix typo * Better logger * Move async to test * Omit skip * Only log the user space time * Single line async sleep * file name fix * Fix annotation * Better output of compare * Remove get-characters(-at-range) benchmarks * Restore emoji * Capitalize types * Remove compare to another area * Add grep and config interface * Linting files * Linting benchmarks * Linting benchmarks * Update yarn.lock
124 lines
5.1 KiB
Markdown
124 lines
5.1 KiB
Markdown
# Contributing
|
|
|
|
Want to contribute to Slate? That would be awesome!
|
|
|
|
* [Reporting Bugs](#reporting-bugs)
|
|
* [Asking Questions](#asking-questions)
|
|
* [Submitting Pull Requests](#submitting-pull-requests)
|
|
* [Running Examples](#running-examples)
|
|
* [Running Tests](#running-tests)
|
|
* [Running Benchmarks](#running-benchmarks)
|
|
* [Adding Browser Support](#adding-browser-support)
|
|
* [Testing Input Methods](#testing-input-methods)
|
|
* [Debugging Slate Methods](#debugging-slate-methods)
|
|
* [Publishing Releases](#publishing-releases)
|
|
|
|
## Reporting Bugs
|
|
|
|
If you run into any weird behavior while using Slate, feel free to open a new issue in this repository! Please run a **search before opening** a new issue, to make sure that someone else hasn't already reported or solved the bug you've found.
|
|
|
|
Any issue you open must include:
|
|
|
|
* A [JSFiddle](https://jsfiddle.net/fj9dvhom/1/) that reproduces the bug with a minimal setup.
|
|
* A GIF showing the issue in action. (Using something like [RecordIt](http://recordit.co/).)
|
|
* A clear explanation of what the issue is.
|
|
|
|
Here's a [JSFiddle template for Slate](https://jsfiddle.net/fj9dvhom/1/) to get you started:
|
|
|
|
[](https://jsfiddle.net/fj9dvhom/1/)
|
|
|
|
## Asking Questions
|
|
|
|
We've also got a [Slate Slack team](https://slate-slack.herokuapp.com) where you can ask questions and get answers from other people using Slate:
|
|
|
|
[](https://slate-slack.herokuapp.com)
|
|
|
|
Please use the Slack instead of asking questions in issues, since we want to reserve issues for keeping track of bugs and features. We close questions in issues so that maintaining the project isn't overwhelming.
|
|
|
|
## Submitting Pull Requests
|
|
|
|
All pull requests are super welcomed and greatly appreciated! Easy issues are marked with an [`easy-one`](https://github.com/ianstormtaylor/slate/issues?q=is%3Aopen+is%3Aissue+label%3Aeasy-one) label if you're looking for a simple place to get familiar with the code base.
|
|
|
|
Please include tests and docs with every pull request!
|
|
|
|
## Running Examples
|
|
|
|
Check out the [Examples readme](./examples) to see how to get the examples running locally!
|
|
|
|
## Running Tests
|
|
|
|
To run the tests, you need to have the Slate repository cloned to your computer. After that, you need to `cd` into the directory where you cloned it, and install the dependencies with `yarn` and build the monorepo:
|
|
|
|
```
|
|
yarn install
|
|
yarn build
|
|
```
|
|
|
|
Then run the tests with:
|
|
|
|
```
|
|
yarn test
|
|
```
|
|
|
|
To keep the source rebuilding on every file change, you need to run an additional watching command in a separate process:
|
|
|
|
```
|
|
yarn watch
|
|
```
|
|
|
|
If you need to debug something, you can add a `debugger` line to the source, and then run `yarn test debug`.
|
|
|
|
If you only want to run a specific test or tests, you can run `yarn test --fgrep="slate-react rendering"` flag which will filter the tests being run by grepping for the string in each test.
|
|
|
|
## Running Benchmarks
|
|
|
|
To run the benchmarks, first make some changes to the source that you want to benchmark. Now that you're ready, you need to save a "baseline" for what the performance was before you made you change.
|
|
|
|
To do that, stash your changes and save the benchmarks:
|
|
|
|
```
|
|
git stash
|
|
yarn benchmark:save
|
|
```
|
|
|
|
Then once the reference has been saved, unstash your changes and run the benchmarks to see a comparison:
|
|
|
|
```
|
|
git stash pop
|
|
yarn benchmark
|
|
```
|
|
|
|
There will be some subtle changes in iteration speed always, but the comparison reporter will highlight any changes that seem meaningful. You can run `benchmark` multiple times to ensure the speed up persists.
|
|
|
|
### Run Selected Benchmarks
|
|
|
|
To run selected benchmarks, create `tmp/benchmark-config.js` with `module.exports.include`. For example, to run slate-core benchmarks only with `get-*`, we can create a `tmp/benchmark-config.js` as
|
|
|
|
```
|
|
module.exports.include = {
|
|
slate: /^get/
|
|
}
|
|
```
|
|
|
|
## Adding Browser Support
|
|
|
|
Slate aims to targeted all of the modern browsers, and eventually the modern mobile platforms. Right now browser support is limited to the latest versions of [Chrome](https://www.google.com/chrome/browser/desktop/), [Firefox](https://www.mozilla.org/en-US/firefox/new/), and [Safari](http://www.apple.com/safari/), but if you are interested in adding support for another modern platform, that is welcomed!
|
|
|
|
## Testing Input Methods
|
|
|
|
[Here's a helpful page](https://github.com/Microsoft/vscode/wiki/IME-Test) detailing how to test various input scenarios on Windows, Mac and Linux.
|
|
|
|
## Debugging Slate Methods
|
|
|
|
Slate makes use of [debug](https://github.com/visionmedia/debug) to log information about various methods. You can [enable the logger in the browser](https://github.com/visionmedia/debug#browser-support) by setting `localStorage.debug = "*"` (to log methods on all modules) or to a single namespace (e.g. `slate:editor`). Look for `const debug = Debug('<namespace>')` to get the namespace of various modules.
|
|
|
|
## Publishing Releases
|
|
|
|
Since we use [Lerna](https://lernajs.io) to manage the Slate packages this is fairly easy, **but** you must make sure you are using `npm` to run the release script, because using `yarn` results in failures. So just run:
|
|
|
|
```js
|
|
npm run release
|
|
```
|
|
|
|
And follow the prompts Lerna gives you.
|