mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-08-06 14:16:32 +02:00
Code Issues Releases Wiki Activity

Avoid copying of constructor results

Browse Source
This commit is contained in:
Lorenz Hübschle-Schneider
2014-10-21 14:46:55 +02:00
parent fee1e7c349
commit 645f09d514
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libtomahawk/UrlHandler.cpp
View File

@@ -95,7 +95,7 @@ localFileIODeviceFactory( const Tomahawk::result_ptr&, const QString& url,
io->open( QIODevice::ReadOnly ); io->open( QIODevice::ReadOnly );
// std::functions cannot accept temporaries as parameters // std::functions cannot accept temporaries as parameters
QSharedPointer< QIODevice > sp = QSharedPointer<QIODevice>( io ); QSharedPointer< QIODevice > sp( io );
callback( url, sp ); callback( url, sp );
} }

2
src/libtomahawk/resolvers/JSResolverHelper.cpp
View File

@@ -903,7 +903,7 @@ void
JSResolverHelper::gotStreamUrl( std::function< void( const QString&, QSharedPointer< QIODevice >& ) > callback, NetworkReply* reply ) JSResolverHelper::gotStreamUrl( std::function< void( const QString&, QSharedPointer< QIODevice >& ) > callback, NetworkReply* reply )
{ {
// std::functions cannot accept temporaries as parameters // std::functions cannot accept temporaries as parameters
QSharedPointer< QIODevice > sp = QSharedPointer< QIODevice >( reply->reply(), &QObject::deleteLater ); QSharedPointer< QIODevice > sp ( reply->reply(), &QObject::deleteLater );
QString url = reply->reply()->url().toString(); QString url = reply->reply()->url().toString();
reply->disconnectFromReply(); reply->disconnectFromReply();
reply->deleteLater(); reply->deleteLater();