mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-08-06 22:26:32 +02:00
Code Issues Releases Wiki Activity

More translator friendly string formatting

Browse Source 
* Add escaping of supplied strings since they may interfere with the
  xml-based markup.
This commit is contained in:
Uwe L. Korn
2013-02-24 16:30:28 +01:00
parent 689d97d689
commit 971e84337f
1 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/infoplugins/linux/fdonotify/FdoNotifyPlugin.cpp
View File

@@ -48,6 +48,8 @@
#include <QDBusConnection>
#include <QImage>
// QTextDocument provides Qt::escape()
#include <QTextDocument>
namespace Tomahawk
{
@@ -174,17 +176,28 @@ FdoNotifyPlugin::nowPlaying( const QVariant &input )
if ( !hash.contains( "title" ) || !hash.contains( "artist" ) || !hash.contains( "album" ) )
return;
QString messageText;
// If the window manager supports notification styling then use it.
const char* messageTemplate = "\"%1\" by %2%3.";
const char* albumMessageTemplate = "on \"%1\"";
if ( m_wmSupportsBodyMarkup ) {
messageTemplate = "%1<br /><i>by</i> %2%3.";
albumMessageTemplate = "<br /><i>on</i> %1";
// Remark: If using xml-based markup in notifications, the supplied strings need to be escaped.
QString album;
if ( !hash[ "album" ].isEmpty() )
album = tr( "<br /><i>on</i> %1" ).arg( Qt::escape( hash[ "album" ] ) );
messageText = tr( "%1<br /><i>by</i> %2%3." )
.arg( Qt::escape( hash[ "title" ] ) )
.arg( Qt::escape( hash[ "artist" ] ) )
.arg( album );
}
QString messageText = tr( messageTemplate )
else
{
QString album;
if ( !hash[ "album" ].isEmpty() )
album = QString( " %1" ).arg( tr( "on \"%1\"" ).arg( hash[ "album" ] ) );
messageText = tr( "\"%1\" by %2%3." )
.arg( hash[ "title" ] )
.arg( hash[ "artist" ] )
.arg( hash[ "album" ].isEmpty() ? QString() : QString( " %1" ).arg( tr( albumMessageTemplate ).arg( hash[ "album" ] ) ) );
.arg( album );
}
tDebug( LOGVERBOSE ) << Q_FUNC_INFO << "sending message" << messageText;