Try to fix compilation with qt4

admin/win/update-vlc.sh

@@ -9,20 +9,19 @@ fi
 
 rm -rvf vlc/
 
-VLC_TARBALL="vlc-2.2.3.tar.bz2"
 
 echo "Download phonon archive..."
 # wget -c "http://downloads.sourceforge.net/project/vlc/1.1.9/win32/vlc-1.1.9-win32.7z?r=http%3A%2F%2Fwww.videolan.org%2Fvlc%2Fdownload-windows.html&ts=1306272584&use_mirror=leaseweb"
 # wget -c "http://download.tomahawk-player.org/tomahawk-vlc-0.1.zip"
 # wget -c http://people.videolan.org/~jb/phonon/phonon-vlc-last.7z
 # wget -c http://people.videolan.org/~jb/phonon/phonon_phonon-vlc_20111128.7z
-wget -c "http://download.tomahawk-player.org/test/$VLC_TARBALL"
+wget -c http://download.tomahawk-player.org/test/vlc.tar.bz2
 
 echo "Extract binary..."
 # 7z x phonon*.7z
 # mv -v vlc-*/ vlc/
 # unzip tomahawk-vlc-0.1.zip
-tar xvjf "$VLC_TARBALL"
+tar xvjf vlc.tar.bz2
 
 # echo "Download phonon_vlc_no_video.dll..."
 # wget -c http://people.videolan.org/~jb/phonon/phonon_vlc_no_video.dll
@@ -73,9 +72,7 @@ rm -rvf \
     **/libi420* \
     **/libi422* \
     mux/ \
-    stream_filter/*dash* \
-    stream_filter/*smooth* \
-    stream_filter/*record* \
+    stream_filter/ \
     **/libtheora_plugin* \
     **/liblibbluray_plugin* \
     **/libdtv_plugin* \

resources.qrc

@@ -170,6 +170,5 @@
         <file>data/images/downloadbutton.svg</file>
         <file>data/images/nav-back.svg</file>
         <file>data/images/nav-forward.svg</file>
-        <file>data/sounds/silence.ogg</file>
     </qresource>
 </RCC>

src/libtomahawk/ContextMenu.cpp

@@ -223,10 +223,8 @@ ContextMenu::setQueries( const QList<Tomahawk::query_ptr>& queries )
         m_sigmap->setMapping( addAction( tr( "&Copy Track Link" ) ), ActionCopyLink );
     }
 
-    if ( m_supportedActions & ActionOpenFileManager &&
-         queries.length() == 1 &&
+    if ( m_supportedActions & ActionOpenFileManager && queries.length() == 1 &&
          queries.first()->numResults() &&
-         queries.first()->results().first()->resolvedByCollection() &&
          queries.first()->results().first()->resolvedByCollection()->isLocal() )
     {
         m_sigmap->setMapping( addAction( ImageRegistry::instance()->icon( RESPATH "images/folder.svg" ),

src/libtomahawk/TomahawkSettings.cpp

@@ -929,20 +929,6 @@ TomahawkSettings::setVolume( unsigned int volume )
 }
 
 
-bool
-TomahawkSettings::muted() const
-{
-    return value( "audio/muted" ).toBool();
-}
-
-
-void
-TomahawkSettings::setMuted( bool muted )
-{
-    setValue( "audio/muted", muted );
-}
-
-
 QString
 TomahawkSettings::proxyHost() const
 {

src/libtomahawk/TomahawkSettings.h

@@ -107,9 +107,6 @@ public:
     unsigned int volume() const;
     void setVolume( unsigned int volume );
 
-    bool muted() const;
-    void setMuted( bool muted );
-
     /// Playlist stuff
     QByteArray playlistColumnSizes( const QString& playlistid ) const;
     void setPlaylistColumnSizes( const QString& playlistid, const QByteArray& state );

src/libtomahawk/audio/AudioEngine.cpp

@@ -167,17 +167,10 @@ AudioEngine::AudioEngine()
 
     d->audioOutput = new AudioOutput( this );
 
-    connect( d->audioOutput, SIGNAL( initialized() ), this, SIGNAL( initialized() ) );
     connect( d->audioOutput, SIGNAL( stateChanged( AudioOutput::AudioState, AudioOutput::AudioState ) ), d_func(), SLOT( onStateChanged( AudioOutput::AudioState, AudioOutput::AudioState ) ) );
     connect( d->audioOutput, SIGNAL( tick( qint64 ) ), SLOT( timerTriggered( qint64 ) ) );
     connect( d->audioOutput, SIGNAL( positionChanged( float ) ), SLOT( onPositionChanged( float ) ) );
-    connect( d->audioOutput, SIGNAL( volumeChanged( qreal ) ), SLOT( onVolumeChanged( qreal ) ) );
-    connect( d->audioOutput, SIGNAL( mutedChanged( bool ) ), SIGNAL( mutedChanged( bool ) ) );
 
-    if ( TomahawkSettings::instance()->muted() )
-    {
-        mute();
-    }
     setVolume( TomahawkSettings::instance()->volume() );
 
     qRegisterMetaType< AudioErrorCode >("AudioErrorCode");
@@ -190,7 +183,6 @@ AudioEngine::~AudioEngine()
     tDebug() << Q_FUNC_INFO;
 
     TomahawkSettings::instance()->setVolume( volume() );
-    TomahawkSettings::instance()->setMuted( isMuted() );
 
     delete d_ptr;
 }
@@ -297,11 +289,8 @@ AudioEngine::stop( AudioErrorCode errorCode )
     if ( d->waitingOnNewTrack )
         sendWaitingNotification();
 
-    if ( d->audioOutput->isInitialized() )
-    {
-        Tomahawk::InfoSystem::InfoPushData pushData( s_aeInfoIdentifier, Tomahawk::InfoSystem::InfoNowStopped, QVariant(), Tomahawk::InfoSystem::PushNoFlag );
-        Tomahawk::InfoSystem::InfoSystem::instance()->pushInfo( pushData );
-    }
+    Tomahawk::InfoSystem::InfoPushData pushData( s_aeInfoIdentifier, Tomahawk::InfoSystem::InfoNowStopped, QVariant(), Tomahawk::InfoSystem::PushNoFlag );
+    Tomahawk::InfoSystem::InfoSystem::instance()->pushInfo( pushData );
 }
 
 
@@ -577,12 +566,6 @@ AudioEngine::loadTrack( const Tomahawk::result_ptr& result )
     Q_D( AudioEngine );
     tDebug( LOGEXTRA ) << Q_FUNC_INFO << ( result.isNull() ? QString() : result->url() );
 
-
-    if ( !d->audioOutput->isInitialized() )
-    {
-        return;
-    }
-
     if ( !result )
     {
         stop();

src/libtomahawk/audio/AudioEngine.h

@@ -149,8 +149,6 @@ public slots:
     void setShuffled( bool enabled );
 
 signals:
-    void initialized();
-
     void loading( const Tomahawk::result_ptr track );
     void started( const Tomahawk::result_ptr track );
     void finished( const Tomahawk::result_ptr track );

src/libtomahawk/audio/AudioOutput.cpp

@@ -25,13 +25,11 @@
 
 #include "audio/MediaStream.h"
 #include "utils/Logger.h"
-#include "utils/TomahawkUtils.h"
 
 #include <QApplication>
 #include <QVarLengthArray>
 #include <QFile>
 #include <QDir>
-#include <QTimer>
 
 #include <vlc/libvlc.h>
 #include <vlc/libvlc_media.h>
@@ -60,7 +58,6 @@ AudioOutput::AudioOutput( QObject* parent )
     , m_currentTime( 0 )
     , m_totalTime( 0 )
     , m_justSeeked( false )
-    , m_initialized( false )
     , dspPluginCallback( nullptr )
     , m_vlcInstance( nullptr )
     , m_vlcPlayer( nullptr )
@@ -123,11 +120,6 @@ AudioOutput::AudioOutput( QObject* parent )
         libvlc_MediaPlayerTitleChanged,
         libvlc_MediaPlayerSnapshotTaken,
         //libvlc_MediaPlayerLengthChanged,
-#if (LIBVLC_VERSION_INT >= LIBVLC_VERSION(2, 2, 2, 0))
-        libvlc_MediaPlayerAudioVolume,
-        libvlc_MediaPlayerMuted,
-        libvlc_MediaPlayerUnmuted,
-#endif
         libvlc_MediaPlayerVout
     };
     const int eventCount = sizeof(events) / sizeof( *events );
@@ -136,24 +128,8 @@ AudioOutput::AudioOutput( QObject* parent )
         libvlc_event_attach( manager, events[ i ], &AudioOutput::vlcEventCallback, this );
     }
 
-    // HACK: play silent ogg file and set volume on that to workaround vlc not allowing to set volume before a file is played
-    m_silenceFile.setFileName( RESPATH "sounds/silence.ogg" );
-    Q_ASSERT( m_silenceFile.exists() );
-    Q_ASSERT( m_silenceFile.open( QIODevice::ReadOnly ) );
-
-    setCurrentSource( new MediaStream( &m_silenceFile, true ) );
-    libvlc_media_player_play( m_vlcPlayer );
-
-    #if QT_VERSION >= QT_VERSION_CHECK(5,4,0)
-    // if the silence file did not play for 15 secs, we pretend the AudioOutput is initialized, to allow proper error reporting
-    QTimer::singleShot( 15000, [&]()
-    {
-        if ( !m_initialized ) {
-            m_initialized = true;
-            emit initialized();
-        }
-    } );
-    #endif
+    m_muted = isMuted();
+    tDebug() << Q_FUNC_INFO << "Init OK";
 }
 
 
@@ -179,28 +155,6 @@ AudioOutput::~AudioOutput()
 }
 
 
-void
-AudioOutput::onInitVlcEvent( const libvlc_event_t* event )
-{
-    switch ( event->type )
-    {
-        case libvlc_MediaPlayerTimeChanged:
-            setVolume( volume() );
-            setMuted( isMuted() );
-
-            m_initialized = true;
-            m_silenceFile.close();
-
-            tDebug() << Q_FUNC_INFO << "Init OK";
-            emit initialized();
-            break;
-
-        default:
-            break;
-    }
-}
-
-
 void
 AudioOutput::setAutoDelete( bool ad )
 {
@@ -349,13 +303,6 @@ AudioOutput::setCurrentSource( MediaStream* stream )
 }
 
 
-bool
-AudioOutput::isInitialized() const
-{
-    return m_initialized;
-}
-
-
 AudioOutput::AudioState
 AudioOutput::state() const
 {
@@ -510,7 +457,7 @@ AudioOutput::isSeekable() const
 bool
 AudioOutput::isMuted() const
 {
-    return m_muted;
+    return libvlc_audio_get_mute( m_vlcPlayer );
 }
 
 
@@ -583,20 +530,6 @@ AudioOutput::onVlcEvent( const libvlc_event_t* event )
             // Don't call stop() here - it will deadlock libvlc
             setState( Error );
             break;
-#if (LIBVLC_VERSION_INT >= LIBVLC_VERSION(2, 2, 2, 0))
-        case libvlc_MediaPlayerAudioVolume:
-            m_volume = event->u.media_player_audio_volume.volume;
-            emit volumeChanged( volume() );
-            break;
-        case libvlc_MediaPlayerMuted:
-            m_muted = true;
-            emit mutedChanged( true );
-            break;
-        case libvlc_MediaPlayerUnmuted:
-            m_muted = false;
-            emit mutedChanged( false );
-            break;
-#endif
         case libvlc_MediaPlayerNothingSpecial:
         case libvlc_MediaPlayerOpening:
         case libvlc_MediaPlayerBuffering:
@@ -622,14 +555,7 @@ AudioOutput::vlcEventCallback( const libvlc_event_t* event, void* opaque )
     AudioOutput* that = reinterpret_cast < AudioOutput * > ( opaque );
     Q_ASSERT( that );
 
-    if ( !that->isInitialized() )
-    {
-        that->onInitVlcEvent( event );
-    }
-    else
-    {
-        that->onVlcEvent( event );
-    }
+    that->onVlcEvent( event );
 }
 
 

src/libtomahawk/audio/AudioOutput.h

@@ -25,8 +25,6 @@
 #include "DllMacro.h"
 #include "Typedefs.h"
 
-#include <QFile>
-
 #include <functional>
 
 struct libvlc_instance_t;
@@ -46,7 +44,6 @@ public:
     explicit AudioOutput( QObject* parent = nullptr );
     ~AudioOutput();
 
-    bool isInitialized() const;
     AudioState state() const;
 
     void setCurrentSource( const QUrl& stream );
@@ -75,16 +72,11 @@ public:
 public slots:
 
 signals:
-    void initialized();
     void stateChanged( AudioOutput::AudioState, AudioOutput::AudioState );
     void tick( qint64 );
     void positionChanged( float );
-    void volumeChanged( qreal volume );
-    void mutedChanged( bool );
 
 private:
-    void onInitVlcEvent( const libvlc_event_t* event );
-
     void setState( AudioState state );
     void setCurrentTime( qint64 time );
     void setCurrentPosition( float position );
@@ -107,9 +99,6 @@ private:
     qint64 m_totalTime;
     bool m_justSeeked;
 
-    bool m_initialized;
-    QFile m_silenceFile;
-
     std::function< void( int state, int frameNumber, float* samples, int nb_channels, int nb_samples ) > dspPluginCallback;
 
     libvlc_instance_t* m_vlcInstance;

src/libtomahawk/audio/MediaStream.cpp

@@ -41,16 +41,12 @@ MediaStream::MediaStream( const QUrl &url )
 }
 
 
-MediaStream::MediaStream( QIODevice* device, bool bufferingFinished )
+MediaStream::MediaStream( QIODevice* device )
     : QObject( nullptr )
     , m_type( IODevice )
     , m_ioDevice ( device )
-    , m_bufferingFinished( bufferingFinished )
 {
-    if ( !bufferingFinished )
-    {
-        QObject::connect( m_ioDevice, SIGNAL( readChannelFinished() ), this, SLOT( bufferingFinished() ) );
-    }
+    QObject::connect( m_ioDevice, SIGNAL( readChannelFinished() ), this, SLOT( bufferingFinished() ) );
 }
 
 

src/libtomahawk/audio/MediaStream.h

@@ -42,7 +42,7 @@ public:
 
     MediaStream( QObject* parent = nullptr );
     explicit MediaStream( const QUrl &url );
-    explicit MediaStream( QIODevice* device, bool bufferingFinished = false );
+    explicit MediaStream( QIODevice* device );
     virtual ~MediaStream();
 
     MediaType type() const;