mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-02-24 11:52:51 +01:00
Code Issues Releases Wiki Activity

Update normalizeDataKey to match the spec (#29609)

Browse Source
This commit is contained in:
Steffen Roßkamp 2019-10-31 06:58:09 +01:00 committed by XhmikosR
parent 639c405c65
commit c62efc3ef6
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/src/dom/manipulator.js
View File

@ -26,7 +26,7 @@ function normalizeData(val) {
}
function normalizeDataKey(key) {
return key.replace(/[A-Z]/g, chr => chr.toLowerCase())
return key.replace(/[A-Z]/g, chr => `-${chr.toLowerCase()}`)
}
const Manipulator = {

20
js/tests/unit/dom/manipulator.spec.js
View File

@ -24,13 +24,13 @@ describe('Manipulator', () => {
expect(div.getAttribute('data-key')).toEqual('value')
})
it('should set data attribute in lower case', () => {
it('should set data attribute in kebab case', () => {
fixtureEl.innerHTML = '<div></div>'
const div = fixtureEl.querySelector('div')
Manipulator.setDataAttribute(div, 'tEsT', 'value')
expect(div.getAttribute('data-test')).toEqual('value')
Manipulator.setDataAttribute(div, 'testKey', 'value')
expect(div.getAttribute('data-test-key')).toEqual('value')
})
})
@ -44,13 +44,13 @@ describe('Manipulator', () => {
expect(div.getAttribute('data-key')).toBeNull()
})
it('should remove data attribute in lower case', () => {
fixtureEl.innerHTML = '<div data-testkey="value" ></div>'
it('should remove data attribute in kebab case', () => {
fixtureEl.innerHTML = '<div data-test-key="value"></div>'
const div = fixtureEl.querySelector('div')
Manipulator.removeDataAttribute(div, 'tEStKeY')
expect(div.getAttribute('data-testkey')).toBeNull()
Manipulator.removeDataAttribute(div, 'testKey')
expect(div.getAttribute('data-test-key')).toBeNull()
})
})
@ -81,12 +81,12 @@ describe('Manipulator', () => {
expect(Manipulator.getDataAttribute(div, 'test')).toBeNull()
})
it('should get data attribute in lower case', () => {
fixtureEl.innerHTML = '<div data-test="value" ></div>'
it('should get data attribute in kebab case', () => {
fixtureEl.innerHTML = '<div data-test-key="value" ></div>'
const div = fixtureEl.querySelector('div')
expect(Manipulator.getDataAttribute(div, 'tEsT')).toEqual('value')
expect(Manipulator.getDataAttribute(div, 'testKey')).toEqual('value')
})
it('should normalize data', () => {