js fixes & lint

.eslintignore

@@ -0,0 +1,2 @@
+frontend/main.js
+frontend/registerServiceWorker.js

docs/translations/default.md

@@ -69,7 +69,6 @@ const data = {
   'Admin': 'Admin',
   'Save': 'Save',
   'Read': 'Read',
-  'Name': 'Name',
   'Write': 'Write',
   'Upload': 'Upload',
   'Permissions': 'Permissions',

frontend/main.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-console */
+
 import Vue from 'vue'
 import App from './App.vue'
 import router from './router'
@@ -43,7 +45,7 @@ new Vue({
             this.$store.commit('setUser', user)
             this.$router.push('/')
           })
-          .catch(error => {
+          .catch(() => {
             this.$notification.open({
               message: this.lang('Something went wrong'),
               type: 'is-danger',

frontend/mixins/shared.js

@@ -1,6 +1,5 @@
 import moment from 'moment'
 import store from '../store.js'
-import router from '../router.js'
 import api from '../api/api'
 
 import english from '../translations/english'

frontend/store.js

@@ -1,6 +1,5 @@
 import Vue from 'vue'
 import Vuex from 'vuex'
-import axios from 'axios'
 import shared from './mixins/shared'
 import _ from 'lodash'
 
@@ -37,17 +36,17 @@ export default new Vuex.Store({
       this.commit('resetTree')
       this.commit('destroyUser')
     },
-    resetCwd(state, data) {
+    resetCwd(state) {
       state.cwd = {
-      location: '/',
-      content: [],
+        location: '/',
+        content: [],
       }
     },
-    resetTree(state, data) {
+    resetTree(state) {
       state.tree = {
-      path: '/',
-      name: shared.methods.lang('Home'),
-      children: [],
+        path: '/',
+        name: shared.methods.lang('Home'),
+        children: [],
       }
     },
     setConfig(state, data) {
@@ -86,12 +85,12 @@ export default new Vuex.Store({
               return
             }
             if (typeof object[property] === 'object') {
-              traverse(object[property]);
+              traverse(object[property])
             }
           }
         }
       }
-      traverse(state.tree);
+      traverse(state.tree)
     },
   },
   actions: {

frontend/translations/english.js

@@ -51,7 +51,6 @@ const data = {
   'Admin': 'Admin',
   'Save': 'Save',
   'Read': 'Read',
-  'Name': 'Name',
   'Write': 'Write',
   'Upload': 'Upload',
   'Permissions': 'Permissions',

frontend/views/Browser.vue

@@ -21,7 +21,7 @@
         <div v-if="can('read')" class="is-flex is-justify-between">
           <div class="breadcrumb" aria-label="breadcrumbs">
             <ul>
-              <li v-for="(item, key) in breadcrumbs" v-if="item.name">
+              <li v-for="(item, index) in breadcrumbs" :key="index">
                 <a @click="goTo(item.path)">{{ item.name }}</a>
               </li>
             </ul>
@@ -40,7 +40,6 @@
                 <a v-if="! checked.length" class="is-inline-block">
                   <b-icon icon="upload" size="is-small"></b-icon> {{ lang('Add files') }}
                 </a>
-                </a>
               </b-upload>
             </b-field>
             <a v-if="can(['read', 'write']) && ! checked.length" class="is-inline-block">
@@ -218,7 +217,7 @@ export default {
         })
       })
 
-      return breadcrumbs
+      return _.filter(breadcrumbs, o => o.name)
     },
     content() {
       return this.$store.state.cwd.content
@@ -246,7 +245,7 @@ export default {
       this.$router.push({ name: 'browser', query: { 'cd': path }})
     },
     getSelected() {
-      return _.reduce(this.checked, function(result, value, key) {
+      return _.reduce(this.checked, function(result, value) {
         result.push(value)
         return result
       }, [])

frontend/views/Users.vue

@@ -59,6 +59,7 @@ import UserEdit from './partials/UserEdit'
 import Menu from './partials/Menu'
 import Pagination from './partials/Pagination'
 import api from '../api/api'
+import _ from 'lodash'
 
 export default {
   name: 'Users',
@@ -90,7 +91,7 @@ export default {
           api.deleteUser({
             username: user.username
           })
-            .then(res => {
+            .then(() => {
               this.users = _.reject(this.users, u => u.username == user.username)
               this.$toast.open({
                 message: this.lang('Deleted'),

frontend/views/partials/Menu.vue

@@ -41,7 +41,6 @@ import api from '../../api/api'
 
 export default {
   name: 'Menu',
-  components: { Profile },
   data() {
     return {
       navbarActive: false,

frontend/views/partials/Profile.vue

@@ -23,6 +23,7 @@
 
 <script>
 import api from '../../api/api'
+import _ from 'lodash'
 
 export default {
   name: 'Profile',
@@ -39,7 +40,7 @@ export default {
         oldpassword: this.oldpassword,
         newpassword: this.newpassword,
       })
-        .then(res => {
+        .then(() => {
           this.$toast.open({
             message: this.lang('Updated'),
             type: 'is-success',

frontend/views/partials/TreeNode.vue

@@ -6,13 +6,14 @@
       &nbsp; <a @click="$emit('selected', node)">{{ node.name }}</a>
 
     <ul v-if="node.children && node.children.length">
-      <TreeNode v-for="child in node.children" :node="child" @selected="$emit('selected', $event)"></TreeNode>
+      <TreeNode v-for="(child, index) in node.children" :node="child" :key="index" @selected="$emit('selected', $event)"></TreeNode>
     </ul>
   </li>
 </template>
 
 <script>
 import api from '../../api/api'
+import _ from 'lodash'
 
 export default {
   name: "TreeNode",

frontend/views/partials/Upload.vue

@@ -30,7 +30,7 @@
           <hr>
         </div>
         <div v-if="progressVisible" class="progress-items">
-          <div v-for="file in resumable.files.slice().reverse()">
+          <div v-for="(file, index) in resumable.files.slice().reverse()" :key="index">
             <div>
               <div>{{ file.relativePath != '/' ? file.relativePath : '' }}/{{ file.fileName }}</div>
               <div class="is-flex is-justify-between">
@@ -55,6 +55,7 @@ import Resumable from 'resumablejs'
 import Vue from 'vue'
 import api from '../../api/api'
 import axios from 'axios'
+import _ from 'lodash'
 
 export default {
   name: 'Upload',
@@ -88,7 +89,7 @@ export default {
       simultaneousUploads: this.$store.state.config.upload_simultaneous,
       chunkSize: this.$store.state.config.upload_chunk_size,
       maxFileSize: this.$store.state.config.upload_max_size,
-      maxFileSizeErrorCallback: (file, errorCount) => {
+      maxFileSizeErrorCallback: (file) => {
         this.$notification.open({
           message: this.lang('File size error', file.name, this.formatBytes(this.$store.state.config.upload_max_size)),
           type: 'is-danger',
@@ -106,7 +107,7 @@ export default {
       return;
     }
 
-    this.resumable.on('fileAdded', (file) => {
+    this.resumable.on('fileAdded', () => {
       if (! this.paused) {
         this.resumable.upload()
       }

frontend/views/partials/UserEdit.vue

@@ -68,10 +68,10 @@
 <script>
 import Tree from './Tree'
 import api from '../../api/api'
+import _ from 'lodash'
 
 export default {
   name: 'UserEdit',
-  components: { Tree },
   props: [ 'user', 'action' ],
   computed: {
   },