phpstan & refactoring

.travis.yml

@@ -12,6 +12,7 @@ before_script:
 
 script:
   - vendor/bin/phpunit --coverage-clover=coverage.xml
+  - composer phpstan
 
 after_success:
   - bash <(curl -s https://codecov.io/bash)

README.md

@@ -62,9 +62,10 @@ npm run serve
 Once everything is ready visit: ```http://localhost:8080```
 
 
-### Run tests
+### Run tests & static analysis
 ```
 vendor/bin/phpunit
+composer phpstan
 ```
 
 ### Deployment

backend/Controllers/AuthController.php

@@ -67,6 +67,10 @@ class AuthController
             return $response->json($errors->firstOfAll(), 422);
         }
 
+        if ($auth->user() === null) {
+            return $response->json(['oldpassword' => 'Wrong password'], 422);
+        }
+
         if (! $auth->authenticate($auth->user()->getUsername(), $request->input('oldpassword'))) {
             return $response->json(['oldpassword' => 'Wrong password'], 422);
         }

backend/Services/Auth/Adapters/Database.php

@@ -101,7 +101,7 @@ class Database implements Service, AuthInterface
             ], 'WHERE username = ?', $username);
         }
 
-        return $this->find($user->getUsername());
+        return $this->find($user->getUsername()) ?: $user;
     }
 
     public function add(User $user, $password): User
@@ -119,7 +119,7 @@ class Database implements Service, AuthInterface
             'password' => $this->hashPassword($password),
         ]);
 
-        return $this->find($user->getUsername());
+        return $this->find($user->getUsername()) ?: $user;
     }
 
     public function delete(User $user)

backend/Services/Auth/Adapters/JsonFile.php

@@ -96,7 +96,7 @@ class JsonFile implements Service, AuthInterface
 
                 $this->saveUsers($all_users);
 
-                return $this->find($user->getUsername());
+                return $this->find($user->getUsername()) ?: $user;
             }
         }
 
@@ -122,7 +122,7 @@ class JsonFile implements Service, AuthInterface
 
         $this->saveUsers($all_users);
 
-        return $this->find($user->getUsername());
+        return $this->find($user->getUsername()) ?: $user;
     }
 
     public function delete(User $user)

backend/Services/Session/Adapters/SessionStorage.php

@@ -55,7 +55,11 @@ class SessionStorage implements Service, SessionStorageInterface
 
     public function invalidate()
     {
-        if ($this->getSession() !== null || ! $this->getSession()->isStarted()) {
+        if ($this->getSession() === null) {
+            return;
+        }
+
+        if (! $this->getSession()->isStarted()) {
             $this->getSession()->start();
         }
 

backend/Services/Storage/Filesystem.php

@@ -282,6 +282,6 @@ class Filesystem implements Service
 
         $tmp = explode($this->separator, trim($path, $this->separator));
 
-        return  array_pop($tmp);
+        return  (string) array_pop($tmp);
     }
 }

composer.json

@@ -36,5 +36,8 @@
         "symfony/var-dumper": "^4.2",
         "league/flysystem-memory": "^1.0",
         "phpstan/phpstan": "^0.11.8"
+    },
+    "scripts": {
+        "phpstan": "phpstan analyse ./backend --level=7"
     }
 }