mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-02-21 01:48:45 +01:00
Code Issues Projects Releases Wiki Activity

mod/quiz/review quiz options loaded once per pageload, not once per qn.

Browse Source 
Moved loading of quiz review options from loop iterating over each qn to be
displayed, to the top of the pageload.  Should give efficency gains
on quizes with long pages, as well as making the options available
earlier in the process.
Credit: Peter Bulmer peterbulmer@catalyst.net.nz
This commit is contained in:
mjollnir_ 2006-04-18 22:47:56 +00:00
parent d13ef2fbdc
commit 9f7f01db04
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mod/quiz/review.php
View File

@ -38,6 +38,7 @@
require_login($course->id, false, $cm);
$isteacher = isteacher($course->id);
$options = quiz_get_reviewoptions($quiz, $attempt, $isteacher);
$popup = $isteacher ? 0 : $quiz->popup; // Controls whether this is shown in a javascript-protected window.
if (!$isteacher) {
@ -232,7 +233,6 @@
$number++; // Just guessing that the missing question would have lenght 1
continue;
}
$options = quiz_get_reviewoptions($quiz, $attempt, $isteacher);
$options->validation = QUESTION_EVENTVALIDATE === $states[$i]->event;
$options->history = ($isteacher and !$attempt->preview) ? 'all' : 'graded';
// Print the question