mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-81073 badges: better Oracle support for expiry filter.

Browse Source 
Avoid the following error by casting the bound parameter:

ORA-00932: inconsistent datatypes: expected CHAR got NUMBER.
This commit is contained in:
Paul Holden 2024-03-18 16:34:59 +00:00
parent 2f9001cbe9
commit ba1f9cb26c
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
badges/classes/reportbuilder/local/entities/badge.php
View File

@ -284,6 +284,8 @@ class badge extends base {
* @return filter[]
*/
protected function get_all_filters(): array {
global $DB;
$badgealias = $this->get_table_alias('badge');
// Name.
@ -330,9 +332,9 @@ class badge extends base {
'expiry',
new lang_string('expirydate', 'core_badges'),
$this->get_entity_name(),
"CASE
WHEN {$badgealias}.expiredate IS NULL AND {$badgealias}.expireperiod IS NULL THEN :{$parammaxint}
ELSE COALESCE({$badgealias}.expiredate, {$badgealias}.expireperiod + :{$paramtime})
"CASE WHEN {$badgealias}.expiredate IS NULL AND {$badgealias}.expireperiod IS NULL
THEN " . $DB->sql_cast_char2int(":{$parammaxint}") . "
ELSE COALESCE({$badgealias}.expiredate, {$badgealias}.expireperiod + :{$paramtime})
END",
[$parammaxint => 2147483647, $paramtime => time()]
))