mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 17:02:03 +02:00
Code Issues Projects Releases Wiki Activity

MDL-57177 theme_boost: Use regular ! for advanced form fields

Browse Source 
Previously we used U+2757 on advanced form fields, which was problematic
as it's part of emoji and displays differently on different platforms.
This is a problem since we explicitly style it to be blue, but, for
example on OS X it's red (since it gets replaced with their emoji).
This commit is contained in:
Cameron Ball 2016-11-28 15:23:02 +08:00
parent dc801cb6b9
commit d91cbe1e62
No known key found for this signature in database
GPG Key ID: 305B7F70214D810C
6 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
theme/boost/scss/moodle/core.scss
View File

@ -121,6 +121,10 @@ a.dimmed_text:visited,
@extend .text-info;
}
.fitem.advanced .text-info {
font-weight: bold;
}
.reportlink {
text-align: right;
}

2
theme/boost/templates/core_form/element-advcheckbox.mustache
View File

@ -37,7 +37,7 @@
{{/text}}
</label>
<span class="text-nowrap">
{{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">❗</abbr>{{/advanced}}
{{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">!</abbr>{{/advanced}}
{{{helpbutton}}}
</span>
<div class="form-control-feedback" id="id_error_{{element.name}}" {{^error}} style="display: none;"{{/error}}>

2
theme/boost/templates/core_form/element-checkbox.mustache
View File

@ -37,7 +37,7 @@
{{/text}}
</label>
<span class="text-nowrap">
{{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">❗</abbr>{{/advanced}}
{{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">!</abbr>{{/advanced}}
{{{helpbutton}}}
</span>
<div class="form-control-feedback" id="id_error_{{element.name}}" {{^error}} style="display: none;"{{/error}}>

2
theme/boost/templates/core_form/element-radio.mustache
View File

@ -38,7 +38,7 @@
</label>
<span class="text-nowrap">
{{#required}}<abbr class="initialism text-danger" title="{{#str}}required{{/str}}">✲</abbr>{{/required}}
{{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">❗</abbr>{{/advanced}}
{{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">!</abbr>{{/advanced}}
{{{helpbutton}}}
</span>
<div class="form-control-feedback" id="id_error_{{element.name}}" {{^error}} style="display: none;"{{/error}}>

2
theme/boost/templates/core_form/element-template-inline.mustache
View File

@ -2,7 +2,7 @@
<label class="col-form-label {{#element.hiddenlabel}}sr-only{{/element.hiddenlabel}}" for="{{element.id}}">
{{{label}}} {{{helpbutton}}}
{{#required}}<abbr class="initialism text-danger" title="{{#str}}required{{/str}}">✲</abbr>{{/required}}
{{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">❗</abbr>{{/advanced}}
{{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">!</abbr>{{/advanced}}
</label>
<span data-fieldtype="{{element.type}}">
{{$ element }}

2
theme/boost/templates/core_form/element-template.mustache
View File

@ -2,7 +2,7 @@
<div class="col-md-3">
<span class="pull-xs-right text-nowrap">
{{#required}}<abbr class="initialism text-danger" title="{{#str}}required{{/str}}">✲</abbr>{{/required}}
{{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">❗</abbr>{{/advanced}}
{{#advanced}}<abbr class="initialism text-info" title="{{#str}}advanced{{/str}}">!</abbr>{{/advanced}}
{{{helpbutton}}}
</span>
{{^element.staticlabel}}