mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-05-12 11:15:49 +02:00
Code Issues Projects Releases Wiki Activity

MDL-35547 Fetch more sub-categories with one SQL query.

Browse Source
This commit is contained in:
Tomasz Muras 2012-09-23 19:25:30 +02:00
parent 0f76ac4f2e
commit e80c64ab9d
1 changed files with 13 additions and 12 deletions

25
lib/questionlib.php

@ -1179,24 +1179,25 @@ function question_add_tops($categories, $pcontexts) {
function question_categorylist($categoryid) {
global $DB;
//final list of category IDs
// final list of category IDs
$categorylist = array();
//a list of category IDs to check for any sub-categories
$templist = array($categoryid);
// a list of category IDs to check for any sub-categories
$subcategories = array($categoryid);
while ($current = array_shift($templist)) {
if (isset($categorylist[$current])) {
throw new coding_exception("Category id=$current is already on the list - loop of categories detected.");
}
$subcategories = $DB->get_records('question_categories',
array('parent' => $current), 'sortorder ASC', 'id, 1');
while ($subcategories) {
foreach ($subcategories as $subcategory) {
$templist[] = $subcategory->id;
// if anything from the temporary list was added already, then we have a loop
if (isset($categorylist[$subcategory])) {
throw new coding_exception("Category id=$subcategory is already on the list - loop of categories detected.");
}
$categorylist[$subcategory] = $subcategory;
}
$categorylist[$current] = $current;
list ($in, $params) = $DB->get_in_or_equal($subcategories);
$subcategories = $DB->get_records_select_menu('question_categories',
"parent $in", $params, NULL, 'id,id AS id2');
}
return $categorylist;