mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-58749 lang: Change "inline text" to "online text" in qtype_essay

Browse Source 
This change has been agreed by Helen and Tim in MDL-49208.
This commit is contained in:
David Mudrák 2017-05-03 21:28:23 +02:00
parent 06d0aa4432
commit ee9e7ee31d
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
question/type/essay/db/install.xml
View File

@ -9,7 +9,7 @@
<FIELD NAME="id" TYPE="int" LENGTH="10" NOTNULL="true" SEQUENCE="true"/>
<FIELD NAME="questionid" TYPE="int" LENGTH="10" NOTNULL="true" SEQUENCE="false" COMMENT="Foreign key linking to the question table."/>
<FIELD NAME="responseformat" TYPE="char" LENGTH="16" NOTNULL="true" DEFAULT="editor" SEQUENCE="false" COMMENT="The type of input area students should be given for their response."/>
<FIELD NAME="responserequired" TYPE="int" LENGTH="2" NOTNULL="true" DEFAULT="1" SEQUENCE="false" COMMENT="Nonzero if an inline text response is optional"/>
<FIELD NAME="responserequired" TYPE="int" LENGTH="2" NOTNULL="true" DEFAULT="1" SEQUENCE="false" COMMENT="Nonzero if an online text response is optional"/>
<FIELD NAME="responsefieldlines" TYPE="int" LENGTH="4" NOTNULL="true" DEFAULT="15" SEQUENCE="false" COMMENT="Approximate height, in lines, of the input box the students should be given for their response."/>
<FIELD NAME="attachments" TYPE="int" LENGTH="4" NOTNULL="true" DEFAULT="0" SEQUENCE="false" COMMENT="Whether, and how many, attachments a student is allowed to include with their response. -1 means unlimited."/>
<FIELD NAME="attachmentsrequired" TYPE="int" LENGTH="4" NOTNULL="true" DEFAULT="0" SEQUENCE="false" COMMENT="The number of attachments that should be required"/>

2
question/type/essay/question.php
View File

@ -91,7 +91,7 @@ class qtype_essay_question extends question_with_responses {
}
public function is_complete_response(array $response) {
// Determine if the given response has inline text and attachments.
// Determine if the given response has online text and attachments.
$hasinlinetext = array_key_exists('answer', $response) && ($response['answer'] !== '');
$hasattachments = array_key_exists('attachments', $response)
&& $response['attachments'] instanceof question_response_files;

4
question/type/essay/tests/behat/edit.feature
View File

@ -34,9 +34,9 @@ Feature: Test editing an Essay question
Then I should see "You must supply a value here."
When I set the following fields to these values:
| Question name | Edited essay-001 name |
| Response format | No inline text |
| Response format | No online text |
And I press "id_submitbutton"
Then I should see "When \"no inline text\" is selected, or responses are optional, you must allow at least one attachment."
Then I should see "When \"No online text\" is selected, or responses are optional, you must allow at least one attachment."
When I set the following fields to these values:
| Response format | Plain text |
And I press "id_submitbutton"

2
question/type/essay/tests/helper.php
View File

@ -183,7 +183,7 @@ class qtype_essay_test_helper extends question_test_helper {
}
/**
* Makes an essay question without an inline text editor.
* Makes an essay question without an online text editor.
* @return qtype_essay_question
*/
public function make_essay_question_noinline() {

2
question/type/essay/tests/question_test.php
View File

@ -200,7 +200,7 @@ class qtype_essay_question_test extends advanced_testcase {
$this->assertTrue($essay->is_complete_response(
array('answer' => '', 'attachments' => $attachments[2])));
// Test the case in which both the response and inline text are optional.
// Test the case in which both the response and online text are optional.
$essay->attachmentsrequired = 0;
// Providing no answer and no attachment should result in an incomplete