28068 Commits

Author SHA1 Message Date
toyomoyo
00374cc5f0 MDL-11274, hide grades in the grader report if the current grades has no viewhidden capability 2007-09-14 08:43:10 +00:00
nicolasconnault
098042baea Issue:
The number of submissions in the Group average and Course average calculations
    should be shown in brackets. (submissions) should be added after the Group average
    and Course average labels.
Solution:
    new grader report preference (Display number of grades in average cells).
2007-09-14 06:57:30 +00:00
moodler
2c7a9bd2af Fix the location of the link to the site-wide grading preferences 2007-09-14 06:51:57 +00:00
moodler
6308b91c13 Changing string for Overall average (was logged under MDL-11233 even though that's not strictly the correct bug) 2007-09-14 05:45:38 +00:00
stronk7
c926560086 Now using one cross-db solution to be able to
simulate the status boolean ins assignment
submissions. MDL-8164 & MDL-10846
2007-09-13 17:51:48 +00:00
tjhunt
e8666d9abb MDL-11081 and MDL-11211 - Implement quiz_question_list_instances. The lach of this function was causing a horrible dataloss bug: MDL-11211. Fix thanks to Janne Mikkonen, refined by me. Merged from MOODLE_16_STABLE. 2007-09-13 17:29:08 +00:00
tjhunt
8472a14d71 MDL-11213 - Quiz preview attempts show up in item analysis. Fix thanks to Jean-Michel Vedrine. Merged from MOODLE_18_STABLE. 2007-09-13 16:25:00 +00:00
nicolasconnault
aae94377b7 Issue:
Only students should appear in the tutor report, however
    sorting by Surname results in the tutor being included, which we don't want.
Solution:
    Confirmed as a bug and filed in tracker: http://tracker.moodle.org/browse/MDL-11233

Issue:
    Clicking on Hide Groups reveals the results for all students
    and all tutors and course staff appear. A tutor should only be able to see
    the results for their tutor group
Solution:
    Prevent tutors from ever seeing student grades from other groups: use existing capabilities
        moodle/site:accessallgroups = off AND moodle/grade:viewall = on

Issue:
    Preferences tab should not be available to users without gradereport/grader:manage capability
Solution:
    Hide the tab completely

Issue:
    Apply different style to average cells
Solution:
    Add css classes to the different average cells, and write a default style in css file.

Issue:
    The Average under group average might be better labelled Course average.
Solution:
    Rename to "Complete average"
2007-09-13 15:11:16 +00:00
nicolasconnault
c421ad4b2e MDL-11233 Corrected typo in grader report lib, and added a second sort parameter for lastname and firstname sorts, to add consistency to result sets. Non-students no longer appear in the list 2007-09-13 13:44:35 +00:00
tjhunt
d9935f2985 MDL-11231 - Missing "correct" tick in Close question with answer '0'. Merged from MOODLE_18_STABLE. 2007-09-13 10:47:05 +00:00
nfreear
c5898fad45 MDL-11160, Cron exhausts memory on "Removing expired enrolments ..." - changing nested foreach to JOINs with while(..rs_fetch_next_record). 2007-09-13 09:13:00 +00:00
moodler
43ee1454df Added Zoomspider as allowed to enter when opentogoogle is open 2007-09-13 08:59:31 +00:00
moodler
e7aa5a8800 Patch as suggested by Eloy in MDL-11237 to work around a nasty PHP bug in PHP 5.20 2007-09-13 06:42:49 +00:00
nicolasconnault
83d387c290 MDL-11238 Removed reference to $grade_grade->feedback and replaced with grade_grade_text->feedback. Also instantiated the $grade_grade object properly instead of just get_record(), so that its set_hidden() method could be accessible. 2007-09-13 04:02:55 +00:00
diml
789d27eae6 changes reindexing strategy : deletes records rather than create back table
search db model transfered to block_search. No db model needed here.
2007-09-12 21:23:55 +00:00
diml
cf8ef35e5f changes reindexing strategy : deletes records rather than create back table
checkDB() and checkTableExists() in indexlib.php are obsolete
table name synced with search block install.xml table name
2007-09-12 21:22:15 +00:00
nicolasconnault
b1b6ebf437 Replacing the capability gradereport/grader:manage with moodle/grade:manage 2007-09-12 15:02:06 +00:00
nfreear
a98a90163e Fixes MDL-8627, "HTML QuickForm displays (some?) disabled elements in a non-accessible way", overrides parent::getFrozenHtml. 2007-09-12 11:17:35 +00:00
sam_marshall
d75c6556c7 MDL-11224 Updated UFO Flash JS library from 3.20 to 3.22, preserving minor Moodle-specific change (and added comment to top about it!) 2007-09-12 10:14:12 +00:00
donal72
c824d47823 Uninitialized variable 2007-09-12 03:25:43 +00:00
martinlanghoff
ff991c055a admin/cron: if $PERF->dbqueries is set, profile modules...
The cron() function of some modules can be a huge drag on the
server. Capture profiling data...
2007-09-12 02:57:58 +00:00
martinlanghoff
cf1348caae PERF logging - move handling to moodle_request_shutdown()
By moving the performance profile logging to the very
end of PHP processing, we cover more pages, notably those
that don't end up with a footer or a redirect, like file
serving.

This should improve quality of our performance logs, and
help catch some piggies...
2007-09-12 02:57:26 +00:00
martinlanghoff
3446daa3da redirect() - log performance profiling info
Many heavy pages end in a redirect. Log their profiling data!

Thanks to Matt Clarkson for spotting the problem.
2007-09-12 02:57:08 +00:00
martinlanghoff
6b6eea5575 admin/modules: Avoid calling rebuild_course_cache()
rebuild_course_cache() over all courses is extremely expensive,
not suitable for interactive calling. Better to clear modinfo
and let course/view.php repopulate it as needed.

With this patch we clear out modinfo _only_ for courses affected
by the module we show/hide/delete.
2007-09-12 02:56:50 +00:00
martinlanghoff
d863419245 course/index: move orphan fixups to an optimised fix_coursecategory_orphans()
Move the fixups for orphan courses to the newly minted
fix_coursecategory_orphans() -- and optimise it to take only 1 dbquery for
the common case.

If we do find lots of orphans, we issue 2 updates per orphan.

This cuts down dbqueries drastically - we used to have 2x the number of
courses in the site.
2007-09-12 02:56:36 +00:00
martinlanghoff
f8ea60777c fix_course_sortorder(): fix breakage with large categories, saner error
Two improvements for fix_course_sortorder()

 - If the category has more courses than the shift range
   use a larger shift range to avoid overlapping with itself

 - If things do go wrong during the per-course sortorder updates,
   rollback and try and call ourselves with a 'safe' flag.

Still - far from perfect. Probably the global sortorder approach
is broken. The sanest way is to rework things to always join against
course_categories and order by the combined sortorders.
2007-09-12 02:56:16 +00:00
stronk7
dc6cc11a72 Annihilate one wrong use of getNameForObject() now
that we are able to detect REAL check constraints names
2007-09-11 19:39:28 +00:00
stronk7
da40b0beab And now, the unused getStandardNameForObject() is out. Back to the
exclusive getNameForObject() function, ONLY USED TO CREATE NEW
OBJECTS, NEVER TO GUESS THE NAME OF EXISTING ONES. MDL-9356
2007-09-11 19:37:13 +00:00
stronk7
3d74e77aae Now we aren't guessing check constraint names
but getting the real ones under Oracle. MDL-9356
2007-09-11 19:08:11 +00:00
stronk7
92529a70fa Now we aren't guessing check constraint names
but getting the real ones under MSSQL. MDL-9356
2007-09-11 19:07:17 +00:00
stronk7
f0dfc20124 Now we aren't guessing check constraint names
but getting the real ones under PostgreSQL. MDL-9356
2007-09-11 19:06:38 +00:00
stronk7
3e38ceb837 Added some new test to check double creation
and deletion of enums (check constrainsts). MDL-9356
2007-09-11 18:35:23 +00:00
stronk7
f090314f46 General cleanup of debugging messages.
Now change_field_enum() introspects DB and detects
if the enum existed or no, as needed. MDL-9356
2007-09-11 18:33:23 +00:00
thepurpleblob
bad6ba65ae Missing a stripslashes() so TeX functions didn't work
Merged from STABLE_18
2007-09-11 14:55:34 +00:00
thepurpleblob
07caf142d7 MDL-10092:
Decode HTML entities before processing.

Merged from STABLE_18
2007-09-11 13:55:33 +00:00
jamiesensei
15822170d4 removing require that is not needed 2007-09-11 09:01:21 +00:00
jamiesensei
479cca8a1e fix to make breadcrumbs module independent 2007-09-11 08:23:00 +00:00
diml
515887c4d8 db scheme note for search engine 2007-09-11 08:09:02 +00:00
diml
0a4c172ce7 ensuring php5.0 php4.3 compatibility in cron runs 2007-09-11 08:03:40 +00:00
jgutierr25
c39e721374 Pb with autologinguest 2007-09-11 07:54:55 +00:00
nicolasconnault
6619eba40b MDL-10383 Reverting Petr's boolean cast on the array of allowed groups. It makes it impossible to get the "Group event" option in the calendar. 2007-09-11 07:29:48 +00:00
stronk7
af1192b159 Now both check_constraint_exists() and find_check_constraint_name()
are working under mysql, postgresql and mssql. 1st step of MDL-9356
2007-09-10 22:42:04 +00:00
stronk7
faa1a939f0 Now Oracle is also able to detect its check constraints per field. 2007-09-10 22:30:26 +00:00
stronk7
7abc6e09c0 Adding two new functions to search for check constraints from ddl stuff.
Unused and unfinished for now. I need them in CVS.
2007-09-10 22:22:23 +00:00
stronk7
a347e5e439 Preparing getCheckConstraintsFromDB() to retrieve the check constraint
defined for one field. Not used yet but I need it in CVS now.
2007-09-10 22:00:24 +00:00
diml
5c8f580358 Fixes wildcard exception occurence on deleting resources. 2007-09-10 19:48:31 +00:00
diml
1b4bb51edb add new itemid field for indexing subitems. 2007-09-10 17:26:10 +00:00
diml
7d0b446a6c let lethal exceptions from Lucene passthrough and the cron script finish normally 2007-09-10 17:25:35 +00:00
stronk7
15999a9351 Allow the upgrade_plugins() function to autodetect if the header
has been printed, so it runs in "embedded" mode. Useful to run
submodule installation/upgrade in the same page than the parent. MDL-11183
2007-09-10 17:13:12 +00:00
moodler
8c0aa4fd62 Removed unnecessary WHERE statement in SQL MDL-11146 2007-09-10 14:55:32 +00:00