For some reason, Safari behaves incorrectly when dealing with RTL content
where the table has a max-width of 100%.
This issue is a part of the MDL-25544 Epic.
Even if the navbar is in a static header, it should only be respected if it
is fixed still.
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
This is necessary for themes with non-fixed navbars to work with the
grader report, otherwise headers will be hidden.
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
This makes use of Global YUI events to trigger the resized event handler.
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
They are not serving the same purpose as the one they had before,
and they were overlapping with the content of the cell. Positioning
them somewhere else made them more confusing than helpful.
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
The grader table has been made entirely standalone from core or
theme styling. The floating divs have to share the exact same
rules, and so it was a lot easier and more maintainable to just
style them both using the same selectors, entirely ignoring the
table default styles.
And because the selectors are unique for both the floating elements
and the table cells, a themer can easily re-use them to style both,
without having to dig around to find all the selectors to overwrite.
Working on this highlighted some issues with the positioning. Those
have been fixed within the same patch. And even though it is still
not 100% correct on IE, the result is pretty decent.
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
For some reason, the max-width/min-width/width of the table cell containing
the name of the users did not work, leading to very large columns but a very
narrow floating one. Handling the size of those columsn upon resize was
also necessary after with this fix.
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
This also moves the code into a set of separate files to allow for
additional components of the report to be migrated to the same YUI module,
adjusts some UI components, improves JS performance, and adds appropriate
documentation.
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
Squashed commit of the following:
commit 5881cccc95c135e1440ce0c5441a84b462941758
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date: Thu Aug 21 02:15:05 2014 +0100
MDL-46812 grade/report/grader: Reset previous commit for left scroller.
commit 5abeb60470f02ab4c79c27b2a6f6187e75891e0b
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date: Thu Aug 21 01:29:41 2014 +0100
MDL-46812 grade/report/grader: Added jsenabled css body class to rtl style.
commit a95d23d8b753a590d980e5427e8c74ba597c2b91
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date: Thu Aug 21 00:59:06 2014 +0100
MDL-46812 theme_base; Removed more redundent CSS.
commit 3fb326e5b39738343e0b7c0d9c8da17adf5a09bb
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date: Wed Aug 20 13:24:59 2014 +0100
MDL-46812 theme_base: Removed redundent grade/report/grader CSS in style/grade.css
commit c602e7e277f9ce1fed6d0eccf72c547432e130b6
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date: Thu Aug 14 12:50:14 2014 +0100
MDL-46812 grade/report/grader: Need to tie up loose ends in Gradebook after MDL-43824
1. fixed gradebook layout when JS is disabled
2. added height and background color to scroller when JS is enabled
3. removed redundent top margin in user-grades table
This makes the strings more descriptive and consistent.
AMOS START
MOV [eventreportviewed, gradereport_grader],[eventgradereportviewed, gradereport_grader]
MOV [eventreportviewed, gradereport_outcomes],[eventgradereportviewed, gradereport_outcomes]
MOV [eventreportviewed, gradereport_overview],[eventgradereportviewed, gradereport_overview]
MOV [eventreportviewed, gradereport_user],[eventgradereportviewed, gradereport_user]
AMOS END
The grader report table makes use of various user preferences, and strings
which on every iteration. On a large gradebook, this can have a significant
impact upon performance.
The table also uses html_writer::tag to generate spans for
machine-generated content which becomes expensive on larger gradebooks.
