1452 Commits

Author SHA1 Message Date
Andrew Nicols
1aa1276a84 Merge branch 'MDL-71047-master' of https://github.com/NashTechOpenUniversity/moodle 2021-05-27 11:18:14 +08:00
Andrew Nicols
a44cee78f1 MDL-70990 core_editor: Replace EDITOR_CONTENT_RESTORED event
The legacy M.core.event.EDITOR_CONTENT_RESTORED event has been replaced
with a new core_editor/events::editorContentRestored native DOM event.

The new event can be listened to at any point in the DOM using the
following syntax:

```
import {eventTypes} from 'core_editor/events';

document.addEventListener(eventTypes.editorContentRestored, handler);
```

A backward-compatabibility layer is included to ensure that any legacy
jQuery event is still called with the same arguments.

This legacy bridge will be removed after Moodle 4.3.
2021-05-26 10:47:03 +08:00
Andrew Nicols
a1ccefe2ac MDL-70990 core_form: Standardise event name usage
The `types` object introduced in Moodle 3.11 has been replaced with the
`eventTypes` object which is used consistently across all CustomEvent
definitinos.

Likewise the trigger functions have been renamed from
`triggerUploadStarted` to `notifyUploadStarted` and from
`triggerUploadCompleted` to `notifyUploadCompleted`.

Backwards compatability is maintained.
2021-05-26 10:46:52 +08:00
Nhan Vo
e1c7a18677
MDL-71047 HTML Editor (Atto): Cursor position is not correct when paste 2021-05-17 09:50:58 +07:00
Eloy Lafuente (stronk7)
9d6aa39985 MDL-71583 versions: Add all the missing full-stops to version/requires
It seems that the new phpcs3 checker is now controlling those
line comments that previously were ignored.

This commit just looks for all the cases and bulk-add
them when needed. The bash script (mac) used to add all them is:

while read -r line; do
    arr=(${line//:/ })
    if [[ -n ${arr[0]} ]] && [[ -n ${arr[1]} ]]; then
        echo "  file ${arr[0]}, line ${arr[1]}"
        sed -i "${arr[1]}s/\$/\./" ${arr[0]}
    fi
done < <(find . -name version.php | xargs ag --nomultiline '>(version|requires) *=.*//.*[^;\.]$')
2021-05-11 20:11:07 +02:00
Jake Dallimore
e5e5a06190 Merge branch 'MDL-52724-master' of git://github.com/merrill-oakland/moodle 2021-05-03 13:25:05 +08:00
Jun Pataleta
c646a8eaec Merge branch 'MDL-70947-master' of git://github.com/HuongNV13/moodle 2021-04-30 10:34:11 +08:00
Huong Nguyen
c6fb80b639 MDL-70947 File upload: Upload protection
Interacts badly with double-submit protection, and not all uploads protected
2021-04-29 15:28:19 +07:00
Sara Arjona
92cfa71cd0 Merge branch 'MDL-70763' of git://github.com/paulholden/moodle 2021-04-28 12:36:23 +02:00
Eric Merrill
59704c659c MDL-52724 editor_atto: Scrub atto html for invalid ol, ul, and li tags
Try to correct broken ul/ol/li tags, as they have an outsized impact
on course layout. Uses basic regex and loops to track open and closed
tags.

Also adds a deep clean option to the HTML cleaner, that runs less
frequent, more intensive cleanings. This is because normally _cleanHTML
gets called after each keystroke, which could cause problems with
large content on weak systems.

Behat changes are a fix for setting multiline strings in Atto, and
creating a multiline match step.
2021-04-08 15:20:24 -04:00
Paul Holden
3b9e53c7e1 MDL-70763 core: export preferences for correct user.
Ensure we are using the ID of the given user rather than falling
back to that of the current user during privacy export.
2021-04-04 23:15:23 +01:00
Andrew Nicols
01266b38c0 Merge branch 'MDL-65776-master' of git://github.com/sarjona/moodle 2021-03-25 11:03:32 +08:00
Sara Arjona
a5558e1ae5 MDL-65776 libraries: Set moodle files after jsbeautify upgrade 2021-03-19 15:22:36 +01:00
Sara Arjona
84d8da8314 MDL-65776 libraries: Upgrade jsbeautify to 1.13 2021-03-19 15:22:35 +01:00
Peter Dias
ce863f7ded MDL-70313 core: Update the thirdpartylib.xml 2021-03-15 10:25:28 +08:00
Peter Dias
7e308ac133 MDL-70313 core: Rebuilt module files 2021-03-15 10:25:28 +08:00
Peter Dias
fdabce2329 MDL-70313 core: Update codemirror to 5.59.4 2021-03-15 10:25:28 +08:00
Eloy Lafuente (stronk7)
77342b96fc MDL-69308 upgrade: remove all the < 3.6.0 upgrade steps
This just deletes all the upgrade steps previous to 3.6.0. Some
small adjustments, like tweaking globals can also be applied
when needed.

Also includes an upgrade step to prevent upgrading from any
version < 2018120300 (v3.6.0) as anti-cheating measure.

Note that in this case, there wasn't any case of upgradelib
functions being used, hence we haven't to deprecate/remove
anything in codebase. When there is such a need, that is done
in separate commits (one for each function) and documented here.

See MDL-65809 commits for an example removing/deprecating a
good number of functions.
2021-01-13 19:11:19 +01:00
Andrew Nicols
7d70165c25 MDL-70167 behat: Boolean attributes should either exist or not 2020-11-23 11:02:36 +08:00
Matt Clarkson
541e90c32c MDL-68722 atto_equation: fix for form elements with special characters
Element id's containing characters such as ':' would break the tab
selector in bootstrap.

This specifically affects the essay question type.
2020-10-28 09:26:43 +13:00
Bas Brands
609d8b380e MDL-69395 theme_boost: improve colour contrast for form input fields
- for this issue the atto styles.css was moved into theme boost so
we can use our preset variable for $gray-500
2020-09-09 09:59:08 +02:00
Andrew Nicols
f24aae4cad Merge branch 'MDL-67735-master' of git://github.com/bmbrands/moodle 2020-08-19 08:28:49 +08:00
Eloy Lafuente (stronk7)
fbb0767536 MDL-69475 versions: bump all versions and requires in master
version = 2021052500 release version
requires= 2021052500 same than version

Why 20210525? (25th May 2021) ?

Because master is going to be Moodle 4.0, to be released
on November 2021. And, until then, we are going to have
a couple of "intermediate" releases:

- Moodle 3.10 to be released 9th November 2020. (2020110900)

  This version will be using versions from today to 2020110900
  (once it's released the YYYYMMDD part stops advancing).

- Moodle 3.11 to be released 10th May 2021. (2021051000)

  This version will be using versions from 3.10 release to 2021051000
  (once it's released the YYYYMMDD part stops advancing).

That means that all versions from today to 2021051000 are going
to be used by those 2 "intermediate" releases (3.10 and 3.11).

And we cannot use them in master, because it's forbidden to have
any overlapping of versions between branches (or different upgrade
paths will fail).

So, get that 2021051000, let's add it a couple of weeks to cover
the on-sync period (or a 2 weeks delay max!) and, the first version
that master can "own" in exclusive (without any overlap) is, exactly,
25th May 2021, hence our 20210525.
2020-08-18 00:47:15 +02:00
Bas Brands
4394f9e358 MDL-67735 theme_boost: remove bs2 and bs4alpha compatibility css 2020-08-17 08:16:42 +00:00
Tim Schroeder
95fc9d9399
MDL-60574 atto_undo: fixed redo erasing content
When you'd hit ctrl-y with nothing on the redo stack the entire
content of Atto would get deleted with no way of getting it back.
2020-08-04 09:24:15 +02:00
C4ne
4144e278a6 MDL-68107 editor_atto: responsive images for drag and drop 2020-07-27 09:55:33 +02:00
Helen Foster
38d5e3db1b MDL-69130 lang: Import fixed English strings (en_fix)
Significant string change:

- presentationoraltrequired,atto_image - wording changed to mention
  'decorative only' checkbox
2020-06-25 21:54:13 +02:00
Jun Pataleta
3a679810d5 Merge branch 'MDL-68436' of https://github.com/timhunt/moodle 2020-06-16 14:38:44 +08:00
Eloy Lafuente (stronk7)
b764343e5a MDL-69044 upgrade: add 3.9.0 separation line to all upgrade scripts 2020-06-14 13:08:09 +02:00
Adrian Greeve
fcae8cd3cf MDL-66601 atto_image: Removing bad js build files. 2020-06-11 10:43:13 +08:00
Adrian Greeve
0f4a9aa531 Merge branch 'MDL-66601-master' of git://github.com/mihailges/moodle 2020-06-11 09:43:07 +08:00
Tim Hunt
157c85c20a MDL-68436 atto_recordrtc: only works once per page 2020-06-10 13:40:15 +01:00
Jake Dallimore
337e2e2b23 Merge branch 'MDL-68973' of https://github.com/stronk7/moodle 2020-06-10 16:13:57 +08:00
Mihail Geshoski
ae6712133d MDL-66601 atto_image: Set the max-height of the image selection dialogue 2020-06-10 12:13:55 +08:00
Jake Dallimore
233a526c95 Merge branch 'MDL-68972-master-enfix' of git://github.com/mudrd8mz/moodle 2020-06-10 09:14:46 +08:00
Helen Foster
1ab405f4a2 MDL-68972 lang: Import fixed English strings (en_fix) 2020-06-09 20:56:34 +02:00
Eloy Lafuente (stronk7)
e69ab798dd MDL-68973 versions: Fix other small details
Thanks to Luca Bösch and Matteo Scaramuccia that detected
these 2 minor, but ugly details in core version files:

1) Adding comments pointed to versions (3.x, 20190801...) is not
   recommended, they easily come outdated.
2) Using plugin->release in core is no sense. Core plugins belong
   to the core release.

This commit just gets rid of them. That's all.
2020-06-09 20:27:30 +02:00
Eloy Lafuente (stronk7)
115cc0214f MDL-68973 versions: bump all versions and requires near release
version = 2020061500 release version
requires= 2020060900 current rc1 (week7roll1) version
2020-06-09 16:23:09 +02:00
Paul Holden
0759da9ecf MDL-68995 atto_image: remove initial dialogue image src attribute.
It caused a spurious request to be sent to the server on display.
2020-06-09 12:48:50 +01:00
Sara Arjona
2b860436c9 MDL-64175 atto_media: update advanced settings
Some OS, such as Ubuntu, are slightly changing the audio attributes,
from <audio attribute1="true"> to <audio attribute1>.
This patch is for reviewing this piece of code and covering both cases.
2020-05-28 17:28:37 +02:00
Jun Pataleta
01c8c667fc MDL-68568 editor_atto: Upgrade step for the new toolbar default layout
* emojipicker added to files
* indent moved to list
2020-05-21 00:39:00 +08:00
Mike Churchward
b677d33d62 MDL-68568 editor-atto: Move 'indent' next to 'lists' by default. 2020-05-21 00:10:37 +08:00
David Mudrák
87f9e88ddd MDL-68563 filters: Fix unit test regressions
Also incrementing the plugin versions to make sure the unit test
environment is reinitialised and the tests are reliable.

Minor correction of phpdocs @package tags included.
2020-05-13 16:28:24 +08:00
Simey Lameze
4044914d17 MDL-68563 editor_atto: display emoji picker on atto toolbar
As per enabling of emoticon filters enabling emoji picker is now visible
by default on the Atto editor toolbar.
2020-05-13 16:27:05 +08:00
Andrew Nicols
29c5fafff5 MDL-66109 js: Fix Shifter linting issues 2020-05-11 11:07:49 +08:00
Andrew Nicols
ae346c8624 Merge branch 'MDL-68548' of https://github.com/Neosi/moodle 2020-05-06 08:55:51 +08:00
Eloy Lafuente (stronk7)
dac1b3a4eb Merge branch 'MDL-68541-39' of https://github.com/PoetOS/moodle 2020-05-06 01:04:14 +02:00
Neosi
27e44c18fe MDL-68548 editor-atto: change <i> tags to <em> 2020-05-05 09:50:26 +01:00
Jake Dallimore
eec3a65e5d Merge branch 'MDL-47750' of https://github.com/timhunt/moodle 2020-05-05 11:55:15 +08:00
Andrew Nicols
0449045fa0 Merge branch 'MDL-68542-39' of https://github.com/JayChurchward/moodle 2020-05-05 11:50:04 +08:00