105070 Commits

Author SHA1 Message Date
Sara Arjona
1cedbd1e19 MDL-74784 core_badges: Fix exception with related badges
System badges with related badges were displaying an error before this patch,
because the is_guest($context) function expects a context_course.
2022-05-18 08:18:33 +02:00
Jun Pataleta
5e5e12e063 weekly release 4.1dev 2022-05-12 22:16:01 +08:00
Jun Pataleta
eae7ec37ca Merge branch 'MDL-74413' of https://github.com/stronk7/moodle 2022-05-12 12:09:05 +08:00
Jun Pataleta
aa88375db5 Merge branch 'MDL-73971' of https://github.com/stronk7/moodle 2022-05-12 11:54:43 +08:00
Jun Pataleta
9cb0f7c510 Merge branch 'MDL-73172-master' of https://github.com/NashTechOpenUniversity/moodle 2022-05-12 11:45:05 +08:00
Jun Pataleta
c7ddee0890 Merge branch 'MDL-70568-cron-debugging-patch' of https://github.com/macgirvin/moodle 2022-05-11 10:43:19 +08:00
Jun Pataleta
817db2b7f3 Merge branch 'MDL-74041' of https://github.com/timhunt/moodle 2022-05-10 17:59:45 +08:00
Jun Pataleta
e368edfb5c Merge branch 'MDL-71202-master' of https://github.com/junpataleta/moodle 2022-05-10 12:39:27 +08:00
Pete Whelpton
bc6041158c MDL-71202 webservice: Add index on external_tokens.sid
Without this index, a full table scan / table level locking occurs when
logging out of Moodle.  This can result in slow performance in a busy
Moodle site.
2022-05-10 12:31:25 +08:00
Eloy Lafuente (stronk7)
caf55abf17 MDL-74413 phpunit: Move more tests to use correct names and namespaces
Applied the following changes to various testcase classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to:

- Moved to the level2 "privacy" namespace:
  - \mod_assign\privacy\feedback_legacy_polyfill_test
  - \mod_assign\privacy\submission_legacy_polyfill_test

- Moved to the level2 "task" namespace:
  - \core_message\task\migrate_message_data_test
  - \ltiservice_gradebookservices\task\cleanup_test
  - \message_email\task\send_email_test
  - \mod_lti\task\clean_access_tokens_test
  - \mod_workshop\task\cron_task_test

- Moved to the level2 "event" namespace:
  - \core_h5p\event\deleted_test
  - \core_h5p\event\viewed_test

- Renamed to a better name:
  - backup_forum_activity_task_test.php (missing "task")
2022-05-07 20:32:30 +02:00
Eloy Lafuente (stronk7)
9f53b0e965 MDL-73971 phpunit: Move more tests to use correct names and namespaces
Applied the following changes to various testcase classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to:

- Some fixtures, initially defined in the test files have been
  moved to new files in fixtures subdirectory, leaving the unit
  test files clearer:
  - moodle2_course_format_test.php
- Rename wrong named test:
  - baseoptiogroup_test = baseoptigroup_test
2022-05-06 18:29:11 +02:00
Eloy Lafuente (stronk7)
941a29925e weekly release 4.1dev 2022-05-06 15:58:24 +02:00
Jake Dallimore
d84738eb08 MDL-74602 mod_assign: fix js error with assign grader on classic 2022-05-06 16:46:58 +08:00
Jun Pataleta
48cab7f948 Merge branch 'MDL-74584-master-v1' of https://github.com/mihailges/moodle 2022-05-06 14:47:04 +08:00
Mihail Geshoski
154dbce845 MDL-74584 mod_bigbluebuttonbn: Update behat tests 2022-05-06 14:39:06 +08:00
Mihail Geshoski
75d9476420 MDL-74584 mod_bigbluebuttonbn: Update unit tests 2022-05-06 14:39:06 +08:00
Mihail Geshoski
90f517cf1f MDL-74584 course: New optional parameter in get_module_types_names()
Adds new parameter in get_module_types_names() to optionally reset
the $modnames static cache.
2022-05-06 14:39:06 +08:00
Mihail Geshoski
c23b67be46 MDL-74584 mod_bigbluebuttonbn: Add install script and new upgrade step
Adds a new install script for the BBB module and a new upgrade step.
The BBB module now will be disabled by default for new installations
and also it will be disabled for the existing sites that use the
default BBB server configuration. Admistrators will be required to
confirm the acceptance of the related DPA prior to (re)enabling the
plugin once again.
2022-05-06 14:39:06 +08:00
Mihail Geshoski
b9b9ec82d4 MDL-74584 mod_bigbluebuttonbn: Add DPA info in the general setting page
Adds a note in the BBB general settings page to raise awareness about
the legal obligations related to the data processing agreement with the
service provider which is currently configured.
2022-05-06 13:36:53 +08:00
Mihail Geshoski
6588baec97 MDL-74584 mod_bigbluebuttonbn: Implement 'pre_enable_plugin_actions'
Implements a function for the 'pre_enable_plugin_actions' callback.
When the default BBB server settings are used while the administrator
attempts to enable the BBB plugin, the function will prevent this
action and trigger a dynamic form requesting the admin to conifrm
their acceptance of the related data processing agreement. The process
of enabling the plugin will continue as usual in cases where the
admin has already confirmed the acceptance of the dpa or a different
BBB server configuration is used other than the default.
2022-05-06 13:36:53 +08:00
Mihail Geshoski
4a55d6eb02 MDL-74584 admin: Add callback executed prior to enabling a module
Adds a callback xxx_pre_enable_plugin_actions in admin/modules.php
which plugins can use to force additional actions before enabling the
plugin. The return value (bool) from the plugin callback method
specifies whether the process of enabling the plugin should continue
after the added actions or not.
2022-05-06 13:36:53 +08:00
Jun Pataleta
7aa68e3393 Merge branch 'MDL-74511-master' of https://github.com/andrewnicols/moodle 2022-05-06 11:57:42 +08:00
Andrew Nicols
1b18a4c142 MDL-74511 core: Add phpcs default config 2022-05-06 11:39:10 +08:00
Ilya Tregubov
6442615878 Merge branch 'participants_per_page_MDL-41498' of https://github.com/rschrenk/moodle 2022-05-06 07:59:43 +06:00
Víctor Déniz
9746b8a6e2 Merge branch 'MDL-74612' of https://github.com/paulholden/moodle 2022-05-05 13:20:20 +01:00
Víctor Déniz
78154ce598 Merge branch 'MDL-74128' of https://github.com/paulholden/moodle 2022-05-05 12:09:33 +01:00
Víctor Déniz
89fbe47289 Merge branch 'MDL-74567' of https://github.com/paulholden/moodle 2022-05-05 09:37:28 +01:00
Hien Dinh
00dcb18999 MDL-73172 course: COMPLETE_PASS status cannot enhance in custom theme 2022-05-05 09:35:36 +07:00
Jun Pataleta
a1c0b98c1d MDL-74317 blocks: Revert checking of block usage against page format 2022-05-05 10:02:29 +08:00
Jun Pataleta
53ad985457 Merge branch 'MDL-74576-master' of https://github.com/snake/moodle 2022-05-05 09:55:37 +08:00
Jun Pataleta
4182721677 Merge branch 'MDL-73981-master' of https://github.com/ilyatregubov/moodle 2022-05-05 09:48:59 +08:00
Ilya Tregubov
93e96e0aa2 Merge branch 'MDL-74602-master' of https://github.com/snake/moodle 2022-05-05 07:46:33 +06:00
Jun Pataleta
96ffb21ca6 Merge branch 'MDL-74546-master' of https://github.com/snake/moodle 2022-05-05 09:41:28 +08:00
Ilya Tregubov
82e3a9ce40 MDL-73981 tool_uploadcourse: Validate enrolment role from csv. 2022-05-05 07:38:47 +06:00
Jun Pataleta
0cdc33f19e Merge branch 'MDL-74511-master' of https://github.com/andrewnicols/moodle 2022-05-05 09:37:26 +08:00
Tim Hunt
aac5b47cea MDL-74041 quiz: use own size for paging the question bank 2022-05-04 11:01:44 +01:00
Tim Hunt
10e8ffe312 MDL-74041 question bank: page size should be 100 2022-05-04 10:34:34 +01:00
Jake Dallimore
59b5858da2 MDL-73736 core_auth: Fix concurrency issue in login_attempt_failed()
This patch wraps the login_failed_count logic in a resource lock and
forces a user preferences cache reload. Each thread must wait for the
lock and must fetch the current count before incrementing it. This
ensures that login_failed_count is correct across threads and that the
lockout threshold is correctly honoured.

Co-Authored-By: Sujith Haridasan <sujith@moodle.com>
2022-05-04 14:44:42 +06:00
Michael Hawkins
a0f47c8bc4 MDL-74333 badges: Check profile criteria valid when reviewing 2022-05-04 12:57:38 +08:00
Ilya Tregubov
9478dc6b07 Merge branch 'MDL-74563' of https://github.com/paulholden/moodle 2022-05-04 09:25:08 +06:00
Ferran Recio
4f2eac208d MDL-71623 core_search: fix user document visibility 2022-05-04 04:04:15 +02:00
Amaia Anabitarte
670268900c MDL-74318 core_user: Description field as hidden on profile 2022-05-04 04:04:15 +02:00
Paul Holden
6abe964bba MDL-74204 mod_assign: escape identity fields in allocate marker form. 2022-05-04 04:04:15 +02:00
Jun Pataleta
11b2cc4cb5 Merge branch 'MDL-73878-master' of https://github.com/aanabit/moodle 2022-05-04 09:42:30 +08:00
Amaia Anabitarte
ffc655b181 MDL-73878 core_user: Creating a new category for social fields 2022-05-03 17:52:11 +02:00
Amaia Anabitarte
d2fb057b7e MDL-73878 core_user: Fixing social fields upgrading issue 2022-05-03 17:32:20 +02:00
Jun Pataleta
b625dabb83 Merge branch 'MDL-74543' of https://github.com/timhunt/moodle 2022-05-03 22:22:39 +08:00
Tim Hunt
7d3eaf892d MDL-74543 quiz attemptlib: covert string comparison to ===
Where obviously safe.
2022-05-03 13:45:39 +01:00
Tim Hunt
52b8962dbd MDL-74543 quiz: correctly record time when overdue attempt submitted 2022-05-03 13:41:45 +01:00
Víctor Déniz
9943699604 Merge branch 'MDL-74611' of https://github.com/timhunt/moodle 2022-05-03 13:00:23 +01:00