196 Commits

Author SHA1 Message Date
Tim Hunt
2daffca554 MDL-20636 Fix 30 TODOs 2011-02-24 17:47:51 +00:00
Tim Hunt
f7970e3ca7 MDL-20636 Eliminate integer and boolean in PHPdoc comments. should be int and bool. 2011-02-23 16:25:25 +00:00
Tim Hunt
a17b297d60 MDL-20636 Add missing defined('MOODLE_INTERNAL') || die(); 2011-02-23 16:00:20 +00:00
Tim Hunt
0ff4bd0877 MDL-20636 Fix new stdClass -> stdClass(), and trailing whitespace. 2011-02-21 18:10:19 +00:00
Tim Hunt
e24ee794b2 MDL-20636 Convert the overview report. 2011-02-16 17:33:51 +00:00
Tim Hunt
7ee80cab53 MDL-20636 Manual comment popup comment.php now works. 2011-02-09 20:29:59 +00:00
Tim Hunt
b2607ccc19 MDL-20636 Now the quiz review page works. 2011-02-09 20:18:24 +00:00
Tim Hunt
6577832390 quiz reports MDL-25206 Make it more obvious how to review the students responses. 2010-11-15 16:41:42 +00:00
Sam Hemelryk
367a75fae4 themes lib MDL-24895 Multiple fixes to better handle overflow.
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.
2010-11-05 02:53:47 +00:00
Tim Hunt
e09ca95eba quiz reports MDL-24603 columns in the overview report should be collapsible. 2010-11-01 14:36:58 +00:00
Sam Hemelryk
9db1789832 mod-quiz MDL-24418 Overflow fix allow horizontal scrolling of quiz results. 2010-09-29 03:02:18 +00:00
Petr Skoda
39790bd805 MDL-24321 switching to stdClass in /mod/ 2010-09-21 08:37:36 +00:00
Tim Hunt
414e727676 quiz reports MDL-23161 notify(get_string('nostudentsyet')) breaking downloads. 2010-08-11 18:34:42 +00:00
Tim Hunt
f6c7f15883 quiz reports MDL-17388 tweak layout so more useful stuff fits on the first page.
In particular, I think you should be able to see at least the top of the table or results without scrolling, if your monitor is not too small.
2010-08-04 18:45:05 +00:00
Tim Hunt
f05fedc84d quiz overview report MDL-23377 can't delete attempts when there are no students.
Actually, reviewing this, I noticed some other security checks were missing, for
example we should ensure the users can only delete attempts belonging to this quiz!
2010-08-03 13:15:27 +00:00
Tim Hunt
07a2b2f0f0 quiz overview MDL-23377 whitespace cleanup, before doing the real fix. 2010-08-03 12:54:23 +00:00
Tim Hunt
a49cb927fd NOBUG more consistent use of URLs for the quiz reports. 2010-07-28 15:08:34 +00:00
Petr Skoda
3a11c09f5b MDL-21676 user_picture refactoring, reenabling email requirement - towards Gravatar support 2010-07-04 18:36:34 +00:00
Tim Hunt
cd0a2ed882 quiz reports MDL-22847 Cannot delete quiz attempts when a group is selected. 2010-06-23 20:09:09 +00:00
Rossiani Wijaya
942308b74d Change the fields value (3rd parameter) from 'id' to 'u.id' 2010-05-21 03:50:00 +00:00
Rossiani Wijaya
ef7700377b fixed typo for parameter value from treu to true. 2010-05-21 02:33:43 +00:00
Tim Hunt
37b5b69f2e quiz reports MDL-22257: was loading the complete user record, when it only wanted userid.
On a coures with 16000 users, that is a very bad idea ;-)
2010-04-30 13:15:42 +00:00
Tim Hunt
db77f4103c quiz reports: MDL-21688 Add missing sesskey checks. 2010-04-07 11:26:02 +00:00
Petr Skoda
b9bc201962 MDL-21233 escaped parameter is far more importatnt than the overrideparams in out() method - especially all JS urls should be converted to out(false); also it is possible to create new url with overrided parameters in constructor which might be actually work around the double encoding problems in the url (we should never use the out() in moodle_url constructor itself!) 2010-01-17 09:50:55 +00:00
Petr Skoda
eb7880654f MDL-21233 finally removed the omitquerystring parameters from the out method because: 1/ the least used parameter should nto be first, 2/ it is colliding with the other two paramters, now we have separate funtion for that instead 2010-01-17 09:37:30 +00:00
Petr Skoda
6ea66ff36c MDL-21233 obviously input tag writing does not belong into the moodle_url class, moving to html_writer instead + simplifying api 2010-01-17 09:06:55 +00:00
Petr Skoda
a685593466 MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions 2010-01-16 15:39:56 +00:00
Petr Skoda
3fac41f8dd MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-04 11:57:54 +00:00
Petr Skoda
aeb15530b8 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-04 11:57:52 +00:00
nicolasconnault
825116fb22 MDL-19813 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:16:08 +00:00
nicolasconnault
90cd54cb2a MDL-19813 Migrated calls to print_heading 2009-08-06 08:23:24 +00:00
nicolasconnault
e42f153c33 MDL-19976 Changing redirect($url->out()) to redirect($url). NEVER, NEVER use redirect($url->out())!!! Bad Tim! :p 2009-07-31 09:30:11 +00:00
tjhunt
eacb462e38 quiz reports: MDL-19205 Improved tooltips on individual question grades. 2009-06-05 06:54:42 +00:00
Francois Marier
200164446a Fix drift with CVS 2009-03-11 13:16:54 +00:00
tjhunt
96c7d771df quiz: MDL-14926 New capability mod/quiz:reviewmyattempts, separate from mod/quiz:attempt. Merged from MOODLE_19_STABLE. 2009-01-14 07:08:02 +00:00
jamiesensei
bbf4f440ee MDL-15326 "allow for per report capabilities to replace mod/quiz:viewreports" 2008-11-25 12:11:27 +00:00
tjhunt
9101efd312 cleanup: MDL-17083 Remove the old teacher, teachers, student and students columns from the course table.
For something that has been deprecated for over two years, they were still used in a lot of places!
2008-11-13 08:40:57 +00:00
tjhunt
739b07112e MDL-16625 Detection of whether a quiz has grades was broken in HEAD.
1. Fix this by factoring out a quiz_has_grades function.
2. Fix the quiz unit tests.
3. Fix quiz_has_feedback to return false for ungraded quizzes.
4. Fix use of get_records to do record_exists in quiz reports.
2008-09-23 07:18:15 +00:00
jamiesensei
3d6de8770d MDL-16362 "Quiz - bar graph on results screen" removing var_dump that I forgot to clean up. 2008-09-15 14:08:11 +00:00
jamiesensei
2a1995a476 MDL-16362 "Quiz - bar graph on results screen" there was a bug in my code that would put the graph generation code into an infinite loop if the overall grade for the quiz is 0. Since the change in the type of the field for quiz->grade the old test for quiz->grade being zero doesn't work. Using $quiz->grade as a bool does not work ($quiz->grade is now a string 0.0000), since Moodle 2.0 need to use $quiz->grade == 0. 2008-09-15 13:38:31 +00:00
tjhunt
337fa7a0ef MDL-16263 - followup - fix notices. 2008-08-29 11:30:16 +00:00
jamiesensei
570e5e029a MDL-16041 "Grade of new tests are zero!" no longer displaying graphs of grades for ungraded quizzes. 2008-08-15 10:24:04 +00:00
jamiesensei
f29e6691a7 MDL-15972 "Make ability to list regrades dependent on permission" fixed a problem showing some of the regrade interface to users who do not have permission to regrade.
MDL-15960 "Overview report does not work correctly with groups" Fixed a problem that group mode was not working as the logic selecting the attempts mode was erroneously showing the all attempts mode.
MDL-15958 "Error on selecting to hide marks for each question" problem with trying to sort on question grades when grades not displayed fixed.
MDL-15953 "Summary chart to show in 5% ranges please" allowed the graph to show up to or equal to 20 bands, instead of just up to 20.
MDL-14201 "Summary graph" showing two graphs now as it was felt that when there were few students in a group compared with all the students who took a quiz then it would be difficult to see the data for the group.
2008-08-15 09:59:55 +00:00
tjhunt
f88fb62c40 MDL-10682 - Ensure quiz and question grades are formatted consisently and correctly. While testing, I also fixed a few XHTML Strrrict errors. 2008-08-15 06:42:38 +00:00
jamiesensei
daae98e118 MDL-14216 "change query to work on Postgres." - some adjustments to make it work on mysql again too. 2008-07-24 16:10:26 +00:00
tjhunt
1e98b864e5 MDL-14216 - change query to work on Postgres. 2008-07-24 15:34:15 +00:00
tjhunt
23277af8f1 MDL-14216 - change query to work on Postgres. 2008-07-24 12:58:05 +00:00
jamiesensei
16de0ed32b MDL-15732 "question_load_questions has changed in HEAD and expects an array instead of a comma seperated list of question ids" 2008-07-21 13:06:57 +00:00
jamiesensei
6559096f2c MDL-15728 "quiz_report_load_questions should alias qqi.grade to maxgrade so that questions array has the required fields expected by much of the question code." 2008-07-21 09:06:46 +00:00
jamiesensei
55caa1d5dc MDL-15198 "non-standard sql in reportlib.php" using CASE statement to wrap logic in fields list 2008-07-20 12:52:14 +00:00