59 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
29a541724f
MDL-65292 style: Fix all the function declaration ordering
This has been generated running the following Sniff,
part of the Moodle's CodeSniffer standard:
- PSR2.Methods.MethodDeclaration

It just ensures all the function declarations have
the correct order for:
- abstract and final.
- visibility (public, protected, private).
- static.

So, all the lines modified by this commit are function declarations
and the only changes are in the positions of those keywords.
2024-02-28 23:47:47 +01:00
Marina Glancy
8fc1486d36 MDL-77164 various: fix incorrect phpdocs 2023-04-13 11:35:06 +01:00
Marina Glancy
f4fb91aecb MDL-70920 core: prevent calls to call_user_fun_array() with assoc array 2021-02-21 22:22:21 +01:00
Shamim Rezaie
934c2ee1b6 MDL-58584 core_ddl: getDropTableSQL should not do more than what it says 2020-02-03 15:07:15 +11:00
Tim Hunt
5abc431335 MDL-63020 ddl: fix nullable unique indexes in OCI and MS SQL
This works-around the default non-standard behaviour of these DB engines.
2018-09-20 17:41:22 +01:00
Tim Hunt
54b2b1d27f MDL-63020 xmldb: Improve PHPdoc comments for better IDE autocomplete 2018-09-20 17:41:22 +01:00
Eric Merrill
cd729dc905 MDL-58593 database: More efficiently track issued key names 2017-04-13 12:21:13 -04:00
Simey Lameze
87a3e50192 MDL-51374 core_dml: change database layer to pass table name as parameter 2016-03-15 14:43:45 +08:00
Russell Smith
d22a01fd99 MDL-53213 caching: Faster databasemeta caching for all databases. 2016-02-28 17:03:14 +11:00
Marina Glancy
dcde391b44 MDL-40883 ddl: make sure object name never exceeds max length
Many thanks to Ray Bon for finding the problem
2013-11-08 11:58:35 +11:00
Petr Skoda
bd991d03cf MDL-33018 add general index type hints and use PostgreSQL varchar_pattern_ops index type for context.path
This significantly improves performance of accesslib queries,
credit for the discovery of this solution goes to Andrew Masterton from OU.
2012-07-06 08:19:39 +02:00
Petr Skoda
a6d9d4efc2 MDL-32003 fix PHP4-isms in core xmldb code 2012-06-17 22:56:29 +02:00
Petr Skoda
5a070f0477 MDL-32003 fix phpdocs in DDL layer 2012-06-17 22:56:28 +02:00
Petr Skoda
a66b2ae4f4 MDL-32434 deprecate drop_temp_table() in favour of drop_table() 2012-04-15 12:23:15 +02:00
Petr Skoda
f9090b195b MDL-32112 validate table name restrictions in sql_generator 2012-03-24 11:40:15 +01:00
Petr Skoda
05aae0a571 MDL-29514 drop support for enum data types 2012-03-10 21:36:48 +01:00
Petr Skoda
e9e4a4a672 MDL-27982 convert all signed to unsigned and prevent adding of new unsigned columns
Conflicts, amended to use .02 versions:

	lib/db/upgrade.php, version.php
2012-03-06 12:03:59 +01:00
Eloy Lafuente (stronk7)
29b6a3e8c3 MDL-31251 documentation : whitespace fixes 2012-02-14 00:36:12 +01:00
Aparup Banerjee
83a4ee1ea0 MDL-31251 documentation : improved core ddl API phpdocs. (used moodlecheck plugin) 2012-02-10 12:42:46 +08:00
Petr Skoda
257ad88f89 MDL-29313 enforce varchar size limit 2011-09-16 08:49:42 +02:00
Petr Skoda
b2cfdcf697 MDL-29314 enforce index size limits 2011-09-16 08:45:06 +02:00
Eloy Lafuente (stronk7)
00570de599 MDL-26883 ddl - fix some function declarations 2011-03-18 14:40:20 +01:00
Petr Skoda
7c109ea3f0 MDL-24276 "static abstract" combination is deprecated since PHP 5.2, replacing with our coding_style exception 2010-09-19 18:43:52 +00:00
Petr Skoda
209e00185b MDL-24276 abstract static methods not allowed since PHP 5.2, thanks Anthony Borrow for pointing this out 2010-09-18 22:43:51 +00:00
Petr Skoda
524ad88107 fixed funny initialisation of static local variable 2010-09-14 16:14:19 +00:00
Petr Skoda
41a50aa254 MDL-19057 detect missing unique primary key on id columns 2010-09-14 16:13:06 +00:00
Petr Skoda
844239d3ed MDL-24092 removing STATEMENTS support from install.xml, use db/install.php or db/log.php instead 2010-09-06 11:11:32 +00:00
Petr Skoda
c86f538116 MDL-21249 improved php docs and adding direct access prevention in ddl 2010-07-25 12:57:03 +00:00
Eloy Lafuente
67a2f1c1d7 MDL-22804 hyphens in index names - Now the big-four handle/quote them properly 2010-06-16 16:15:23 +00:00
Petr Skoda
a3790ed5db a few more DDL comment typos 2010-05-21 18:42:50 +00:00
Petr Skoda
0a03123fcf MDL-22167 removing sqlite because it is not maintained 2010-04-23 17:30:02 +00:00
Eloy Lafuente
10f375aa2e MDL-22076 temptables - warn and dropped on disposal 2010-04-21 16:12:27 +00:00
Eloy Lafuente
a1656ddf79 MDL-21874 - phisics are physics :-P 2010-03-22 09:27:35 +00:00
Eloy Lafuente
90d07fa496 MDL-21874 - ddl object names cache. Don't use cache keys anymore. Leads to conflicts. 2010-03-22 09:24:57 +00:00
Eloy Lafuente
38af117a91 NOBUG: partially re-introduce DB object static cache, as we need to avoid dupes
when two indexes are created in the same sentence and initials are the same (contenthash, contextid)
This introduces some problems in Oracle but... better to keep the rest working.
2010-03-18 00:48:48 +00:00
Eloy Lafuente
237e66198d MDL-21834 DDL tests - static caches aren't good for multiple connections in same request 2010-03-17 02:17:26 +00:00
Petr Skoda
117bd74897 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 11:31:16 +00:00
stronk7
692ae9122e MDL-14679, MDL-17491 empty defaults: when passing empty ('') default to char/clob columns
apply correct $default_for_char, so each DB will get its correct empty value
2009-09-22 17:26:40 +00:00
stronk7
4ff402d68e MDL-15181 temporary tables support. No more differences in table_exists() +
implemented temptables store for mysql.
2009-08-31 15:47:46 +00:00
stronk7
b1ca138716 SQL generators must not execute changes in DB. Just provide the needed SQL
in order to make database_manager to execute it. reset_sequence reimplemented.
2009-08-31 14:23:40 +00:00
stronk7
0f887b881e Delete the tweakTempTable() thing used to support temp tables in mssql.
Was hacky and incomplete. Proper solution must be mssql exclusive.
2009-08-28 17:30:18 +00:00
stronk7
4411f0d5f5 MDL-19974 postgres sql generator - simplified a lot thanks to 8.x as min req in Moodle 2.0 (alter column & defaults handling) 2009-07-30 22:08:47 +00:00
skodak
94b6329544 MDL-14679 license header fixes 2009-06-12 08:44:49 +00:00
stronk7
2d2d79ef49 MDL-18577 drop enums support - step3: Drop enums from generator classes. Only code used to drop enums remains until Moodle 2.1 2009-05-01 23:49:31 +00:00
stronk7
2a88f626f7 MDL-18577 drop enums support - step2: enums out from editor, dbmanager and all upgrade scripts. 2009-05-01 01:19:16 +00:00
skodak
1045a0074c MDL-17849 sql queries not printed by default during upgrade anymore, there is a new config.php only setting $CFG->upgradeshowsql instead 2009-01-12 16:52:53 +00:00
skodak
be415e95be MDL-17354 moved reset_sequence into dbmanager 2008-11-21 21:40:50 +00:00
skodak
28a40b5ca2 MDL-15071 coding style improvement by Index: sql_generator.php by Andrei Bautu 2008-07-13 10:14:42 +00:00
skodak
eb099f327b MDL-14956 removed some tests from create table method - no need to check if something exists in table if table itself does not exist yet 2008-06-22 12:35:15 +00:00
skodak
b1f93b1512 MDL-15246 moving all remaining ddl function to adminlib, keeping old lib/ddllib.php only for BC withexisting code; fixed inline docs related to ddl 2008-06-15 10:32:50 +00:00