5744 Commits

Author SHA1 Message Date
toyomoyo
176058849a MDL-12451, in get_users_by_capability(), defaultroleid bit fixes 2007-12-06 03:57:05 +00:00
tjhunt
36c6f4f59e MDL-12452 - not a fix I fear, just clarifying the comments about how this method is broken. 2007-12-05 17:25:25 +00:00
tjhunt
628f99616d MDL-12438 - followup - fix typos. Thanks to Dan Poltawski. 2007-12-05 16:50:23 +00:00
toyomoyo
086df9283f MDL-12437, sorting by names adds teacher to gradebook list 2007-12-05 01:13:29 +00:00
tjhunt
ade79a4768 MDL-12438 - Print a develoer debug message if you call get_records with a non-unique first column. Merged from MOODLE_19_STABLE. 2007-12-04 17:29:47 +00:00
sam_marshall
d5fe85d5cc MDL-12431 Added ability for filters to contain lang files 2007-12-04 11:47:28 +00:00
nicolasconnault
6073a598a7 MDL-12389 Removed the selectallornone element in favour of a more generic submitlink element. The checkbox controller is now added to a form using moodleform::add_checkbox_controller. 2007-12-04 10:35:25 +00:00
martinlanghoff
1d854cec5a datalib: get_logs_user*() - fix invalid SQL - MDL-12426
Oracle does not accept column labels in the GROUP BY section -
get_logs_usercourse() and get_logs_userday() were computing the
day/hours column and using it in the GROUP BY. The compatible fix
is to reproduce the same computation in the GROUP BY section.

Credit for the fix goes to Dennis Rochford <Dennis.Rochford@usq.edu.au>.
2007-12-04 06:26:10 +00:00
martinlanghoff
2ff0fb1205 accesslib: build_context_path() remove $temptable for Oracle too
The removal of $temptable was incomplete - and so build_context_path()
was broken on Oracle. MDL-11347
2007-12-04 06:25:25 +00:00
toyomoyo
0c07a1c458 MDL-12399, shorten_text() truncates all closing tags 2007-12-04 05:10:12 +00:00
fmarier
69885093bf ddllib: Mark table_column() as deprecated
Signed-off-by: Eloy Lafuente
2007-12-03 23:20:03 +00:00
stronk7
1e5352cb61 Adding some outer spaces to returned SQL to avoid wrong
sentences caused by concatenation.

Merged from MOODLE_19_STABLE
2007-12-03 20:44:03 +00:00
stronk7
51adead13f Adding two new functions: sql_isempty() and sql_isnotempty() to perform
SQL comparisons to empties in a cross-db way. General solution for
problems like MDL-12084

Merged from MOODLE_19_STABLE
2007-12-03 20:30:41 +00:00
nicolasconnault
8f9607dbc8 MDL-12389 Added a new getElementsByClassName function in lib/javascript.php, added the selectallornone formslib element, modified the advcheckbox element to support the group variable, and implemented the new element in grade_export_form 2007-12-03 20:13:01 +00:00
nfreear
166db28057 Fixes bug MDL-12416, Help links - img ALT text should contain phrase "new window" to match link TITLE. 2007-12-03 16:41:36 +00:00
toyomoyo
93c61c18cf MDL-10915, additional setting for emoticons 2007-12-03 06:27:21 +00:00
toyomoyo
8f2469611f wrap search/replace in a function so that it could be used in cron 2007-12-03 04:46:37 +00:00
iarenaza
060518592b Remove accidentally revived files as part of MDL-11099 fix 2007-12-02 16:14:13 +00:00
scyrma
2416a6f7c2 Code style corrections. 2007-11-30 03:09:59 +00:00
skodak
0b5a80a1a5 MDL-7028 rewritten course reset + forum role_unassign cleanup fixes; merged from MOODLE_19_STABLE 2007-11-29 14:43:04 +00:00
scyrma
80f29a5947 Possible fix to MDL-12093 : give window without heading and navigation special css classes. 2007-11-29 07:20:13 +00:00
scyrma
fc5e9c4095 MDL-12093 : cleanup & simplify code to get popup windows. 2007-11-29 05:54:35 +00:00
stronk7
ec28a9bf8b Adding new wraplevelXX class for easier containers identification. MDL-12339
Merged from MOODLE_19_STABLE
2007-11-28 18:14:38 +00:00
skodak
f0362b5db2 MDL-7028 gradebook related changes for course reset; merged from MOODLE_19_STABLE 2007-11-28 09:43:47 +00:00
nicolasconnault
66b61ac680 MDL-12356 CSS classes implemented 2007-11-28 05:16:09 +00:00
toyomoyo
b1ee7d3a02 MDL-12366, removing useless print_capabilities function 2007-11-28 01:20:59 +00:00
nicolasconnault
759094e488 MDL-9506 Added support for 'course' type in grade_get_grade_items() function, plus corrected a few typos 2007-11-27 07:11:11 +00:00
moodler
da46265a8f Merged docs fix about get_recordsets usage from 1.9 stable 2007-11-27 05:59:45 +00:00
jamiesensei
0f6475b396 fix for error message 2007-11-26 13:32:23 +00:00
skodak
e850ec4846 MDL-12130 fixed regression - disabledIf did not work in dateselectors; merged from MOODLE_19_STABLE 2007-11-24 13:37:07 +00:00
skodak
a78890d593 MDL-12133 validate() method tidying up; merged from MOODLE_19_STABLE 2007-11-23 22:15:07 +00:00
skodak
0ad439bb42 MDL-12221 custom themes revisited - fixed bug in previous commit, added more developer debug; merged from MOODLE_19_STABLE 2007-11-23 20:26:16 +00:00
skodak
9f7f1a74a0 MDL-12221 custom themes revisited - implemented container concept; merged from MOODLE_19_STABLE 2007-11-23 16:49:51 +00:00
nicolasconnault
8f81fab9df MDL-9506 Returning stdClass objects instead of grade_item objects: for security 2007-11-22 08:47:34 +00:00
scyrma
61b420ace2 Replaces 'GMT' by 'UTC' where it showed in user interface and fixes MDL-9164. 2007-11-22 06:28:58 +00:00
nicolasconnault
1a5159496b MDL-12182 Reverting to pre-upgrade in order to prepare a patch instead 2007-11-22 06:17:01 +00:00
nicolasconnault
f3ac8eb40c MDL-12182 Reverting to pre-upgrade in order to prepare a patch instead 2007-11-22 05:42:46 +00:00
nicolasconnault
93da7cf445 MDL-12182 More grade_item unit tests 2007-11-22 05:37:49 +00:00
toyomoyo
d2b8b98732 MDL-12309, gradebook can not sort by names while in group mode 2007-11-22 05:17:26 +00:00
nicolasconnault
77dbe70855 MDL-9506 Implemented and tested the new API functions 2007-11-21 10:04:21 +00:00
toyomoyo
576ad29016 MDL-10294, MDL-10028, changing messaging/bulk messaging system 2007-11-21 07:53:42 +00:00
sam_marshall
ca70075a39 MDL-12284 Moved require_js to weblib and improved it so that it works if called during header (also tidied up code) 2007-11-20 18:04:03 +00:00
tjhunt
71e197598c MDL-12172 - Sorry, more fall-out from converting continue buttons to use GET instead of POST. Sometimes, URLs were being passed in with & already repalced by &amp; and we weren't handling that properly. Should now be fixed. Merged from MOODLE_19_STABLE. 2007-11-20 17:31:13 +00:00
tjhunt
13ccb7bd58 MDL-12133 - Errors calling parent::validation in a moodle form subclass because the base class method returns true not an empty array. This patch allow subclasses to start their validate method with
$errors = parent::validation($data, $files);

which is what you naturally want to do if you are used to object oriented programming.

Merged from MOODLE_19_STABLE.
2007-11-20 15:08:05 +00:00
nfreear
5cfea9fbae Follow up for MDL-12256, "Course AJAX has very poor accessibility - ALT text" - IE tooltip/ title hack. 2007-11-20 14:37:58 +00:00
martinlanghoff
4f957b116d accesslib: has_capability_in_accessdata() respects rdef locality a bit more
With this patch, we respect rdef locality when two roles
assignments in the same context have conflicting rdefs.
In that case, the most local rdef wins.

So RA locality still matters most. If you are a teacher
sitewide and a student in course X, student role trumps
teacher.

For a use case, see the discussion here
http://moodle.org/mod/forum/discuss.php?d=84472

Notes:

- If we wanted to have locality of RDEF trump everything
  we can. A comment in this patch shows how.

- I don't know how to reproduce this in pure SQL.

And Also:

This patch also fixes a bug where if CAP_PROHIBIT was set
_and_ another role added to it in the same context, we would
add or substract 1 to CAP_PROHIBIT, and it would lose its magic.

And while at it, tighten the code to avoid casts. All the
ints are unambiguously ints.
2007-11-20 00:18:31 +00:00
skodak
f16fa0a34b MDL-12249 groups UI cleanup and improvements - see tracker for details; merged from MOODLE_19_STABLE 2007-11-19 20:31:57 +00:00
nfreear
f8eaeffa21 Fixes for bug MDL-12256, "Course AJAX has very poor accessibility - ALT text" (includes white-space cleanup). 2007-11-19 17:22:04 +00:00
nfreear
11599e476d Initial fix for MDL-12256, "Course AJAX has very poor accessibility - ALT text" - test, imgAttributes.length NOT attributes.length. 2007-11-19 15:25:16 +00:00
mattc-catalyst
6779dc6a02 MDL-12172: fixed get parameters not being submitted in Firefox
Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-11-19 01:45:45 +00:00