39249 Commits

Author SHA1 Message Date
David Mudrak
45d24d396e Added the skelet for grading evaluation subplugins 2010-01-04 18:06:26 +00:00
David Mudrak
f05c168d2e MDL-20236 overall codebase architecture cleanup and fixing regression
See the issue description for more details
2010-01-04 18:05:48 +00:00
David Mudrak
6516b9e9e4 Added instructions for submitting
File API seems to be broken right now so I can't test properly. The new
mod/page code was re-used here.
2010-01-04 18:02:27 +00:00
David Mudrak
ddb59c778f Displays all assigned submissions to be reviewed and saves the calculated grade 2010-01-04 18:02:16 +00:00
David Mudrak
3dc78e5b04 Refactoring some critical parts
Critical issue fixed here: after recent refactorings, I called
get_users_with_capability() inside the loop in another loop! (oops :-)
This was used in my very first code using the renderers. I have learnt
I should follow the core approach (as suggested by Tim) to prepare a
data object and pass it to the renderer. The fact the renderer called
a workshop method indicated something was really wrong...

WIP
2010-01-04 18:02:05 +00:00
David Mudrak
51508f2591 Go workshop, go! 2010-01-04 18:01:50 +00:00
David Mudrak
e9b0f0ab97 Displays the list of submissions 2010-01-04 18:01:40 +00:00
David Mudrak
454e8dd965 Phases can be switched from the Workshop plan tool
There may be more conditions checks written in the future and the
explanation added on what can be expected to happen after the phase
switch.
2010-01-04 18:01:29 +00:00
David Mudrak
3189fb2d42 Uses tabs for all actions, removed temporary links 2010-01-04 18:01:15 +00:00
David Mudrak
da0b1f70c1 More work done on the Workshop Plan UI 2010-01-04 18:01:05 +00:00
David Mudrak
b761e6d9c6 Mostly working on the view.php UI plus some changes 2010-01-04 18:00:54 +00:00
David Mudrak
b13142daee Refactored the Workshop API class
Uses the PHP magic getter to access the underlying database record. Does
not do the serialization goulash, as the passed objects should be clear
database rows.
2010-01-04 18:00:34 +00:00
David Mudrak
095d6e6c9d Reviewed and modified the workshop capabilities 2010-01-04 18:00:24 +00:00
David Mudrak
39861053c4 MDL-20183 Uses some of the new Navigation API 2010-01-04 18:00:12 +00:00
David Mudrak
c333a49ecc MDL-20192 Moving settings.php into suplugins and a small fix 2010-01-04 18:00:02 +00:00
David Mudrak
7e109b56ae Dropping obsolete function call 2010-01-04 17:59:46 +00:00
David Mudrak
ed597c7756 MDL-20192 Allocators and grading strategies are proper subplugins now 2010-01-04 17:59:34 +00:00
David Mudrak
0121d6302c Removed the Dummy grading strategy
This was here for the code reviewing purposes only.
2010-01-04 17:58:45 +00:00
David Mudrak
4eae27fda8 MDL-19931 Number of errors - grading strategy logic implemented 2010-01-04 17:58:26 +00:00
David Mudrak
1dbbccb7a2 Fixed SQL quoting - double quotes needed here 2010-01-04 17:58:16 +00:00
David Mudrak
7a79469c75 Fixed a unittest bug 2010-01-04 17:58:06 +00:00
David Mudrak
f9cb8ea72f MDL-20192 Allocation and grading methods are proper subplugins now.
Still, some areas to be finished - strings and settings
2010-01-04 17:57:54 +00:00
David Mudrak
bdb78faa21 WIP template for unit testing 2010-01-04 17:56:56 +00:00
David Mudrak
b29f0c7d9d Get rid of old navigation stuff (to finish yet) and use OUTPUT 2010-01-04 17:56:44 +00:00
David Mudrak
235b31c887 Reverts the double quotes surrounding SQL 2010-01-04 17:56:34 +00:00
David Mudrak
bc40ea0a9e Better explanation of the returned value 2010-01-04 17:56:23 +00:00
David Mudrak
0371fd0f2c Displays the radio to evaluate the assertion
Also offers all possible numbers of errors, if weighted ones are
counted. Reverts the double quotes coding style for SQL.
2010-01-04 17:56:13 +00:00
David Mudrak
42140421db Work in progress on "Number of errors" grading strategy. Does not work yet. 2010-01-04 17:56:01 +00:00
David Mudrak
7f8312728b Added a dummy grading strategy to demonstrate the basic structure of the component 2010-01-04 17:55:45 +00:00
David Mudrak
8d54587610 Puttting a TODO note - return to this code once working on the Scheduled allocation 2010-01-04 17:55:23 +00:00
David Mudrak
e724e3e5f2 Fixing the rendering of remove icon 2010-01-04 17:55:13 +00:00
David Mudrak
65ba104c5d Reverting Petr's suggestion - using stdClass instead of object again
I do not agree with using object() class for no real reason.
2010-01-04 17:55:02 +00:00
David Mudrak
2c3a86b0f7 Fixed function name typo 2010-01-04 17:54:46 +00:00
David Mudrak
f051cee111 wip 2010-01-04 17:54:36 +00:00
David Mudrak
c46e753305 Fixing regression
Raw database records and $USER are stdClasses (grrr I wonder why we ever
started with this object class)
2010-01-04 17:54:23 +00:00
David Mudrak
dfd3497a75 Fixing the type for grades to number(10,5) 2010-01-04 17:54:13 +00:00
David Mudrak
b398c4c28d Dropping support for Workshop password
Discussed with Petr. Password protection should be sorted out at the
core level (conditionlib maybe).
2010-01-04 17:54:03 +00:00
David Mudrak
3fd2b0e1ac Petr's review: private member variables do not have underscore prefix 2010-01-04 17:53:53 +00:00
David Mudrak
46d0362ccb English string fixed, thank to Stephan Rinke
http://moodle.org/mod/forum/discuss.php?d=130085
2010-01-04 17:53:43 +00:00
David Mudrak
6d5a866090 Adding new install.php file 2010-01-04 17:53:33 +00:00
David Mudrak
9bb4a4a0d5 Petr's review: Removing assignments by reference where not needed 2010-01-04 17:53:20 +00:00
David Mudrak
06d73dd561 Fixing regression - $DB does not return objects() but stdClasses() :-( 2010-01-04 17:53:10 +00:00
David Mudrak
4443519f57 Petr's review: use object instead of stdClass 2010-01-04 17:52:59 +00:00
David Mudrak
74e28b263a Petr's review: Removing assignment by reference 2010-01-04 17:52:45 +00:00
David Mudrak
2fe703edfc Accumulative grading: calculation of grade given by peer reviewer 2010-01-04 17:52:35 +00:00
David Mudrak
50d79a0d08 Added an unique index on workshop_grades 2010-01-04 17:52:25 +00:00
David Mudrak
7f0666a1bb Removing unittesting of implementation details 2010-01-04 17:52:14 +00:00
David Mudrak
7a0ae478c3 Refactoring and fixing
There was a chaos in dimension masterids and localids
2010-01-04 17:52:04 +00:00
David Mudrak
fa159f43c1 Fixed wroing using of static cache 2010-01-04 17:51:54 +00:00
David Mudrak
3d2924e995 Removing static variables. Double quoting SQL. Named param 2010-01-04 17:51:44 +00:00