230 Commits

Author SHA1 Message Date
M Kassaei
32498c28ea MDL-49813 quiz: add sections in the right place after page changes 2015-04-23 16:54:50 +01:00
M Kassaei
5d949702f8 MDL-40988 quiz: ability to break quizzes into sections
The sections are created on the edit quiz page, and then appear in the
navigation panel when the quiz is being attempted to help students find
their way around.

The 'Shuffle questions' setting has been moved from being per-quiz
to being a per-section.

This commit is actually the joint work of Mahmoud Kassaei and Tim Hunt
from The Open University. We could only use one persons name for the
commit and this time Mahmoud gets the credit/blame.
2015-04-05 14:30:53 +01:00
Tim Hunt
080839c421 MDL-48168 quiz editing: max grade should be editable after attempts
Note that there was a lot of legacy code left from Moodle 2.7 which is
no longer required, and I took this opportunity to delete it.
2014-11-10 19:00:05 +00:00
Tim Hunt
6870a6b8d0 MDL-47963 quiz editing: block ajax edits once there are attempts 2014-10-30 16:24:55 +00:00
Sam Hemelryk
ba2f9a9695 Merge branch 'MDL-47132' of git://github.com/timhunt/moodle 2014-10-08 12:01:42 +13:00
Tim Hunt
4d1fcfdf8a MDL-47547 quiz editing: minor fixes following MDL-47547
* Remove unnecessary skip links.
* Disable shortforms for form in pop-ups.
* Remove some CSS that was hurting display of the add menu.
2014-10-06 15:44:21 +01:00
Tim Hunt
16fa272e29 MDL-47132 quiz: move the remains of editlib.php to locallib.php 2014-10-03 07:54:47 +01:00
Tim Hunt
8aa5e0cf58 MDL-47132 quiz: move question bank extensions to classes/question/bank
While doing this code clean-up, I noticed that the question bank pop-up was
only showing the question name, whereas it should have been showing the
question name and the start of the question text, so I fixed that.
2014-10-03 07:54:46 +01:00
Colin Chambers
e1a2d0d92d MDL-43089 quiz: improved interface for building quizzes
This commit is actually the joint work of Mahmoud Kassaei, Colin
Chambers and Tim Hunt from The Open University. We could only use one
persons name for the commit, and this time Colin gets the credit/blame.

The goal of this work was to increase usability, and also clean up
the page enough that it will be possible to add new features in future.

Display of mod/quiz/edit.php is now entirely generated by
mod_quiz\output\edit_renderer. This uses a helper class
mod_quiz\structure to provide details of the structure of the quiz, and
mod_quiz\repaginate to alter that structure. (Acutally, there are still
some modification methods on mod_quiz\structure. Expect that to be
cleaned up in future.)

The new code uses much more ajax, and there are new scripts
mod/quiz/edit_rest.php and mod/quiz/repaginate.php to handle this.
(Again, don't be surprised if those two scripts get merged in future.)
Also questionbank.ajax.php (which may, in future, be made more generic,
and moved into the core question bank code.)

Most of the new JavaScript code has intentionally copied the way things
are done when editing activities on the course page.

As a result of this, mod/quiz/editlib.php is now much shorter than it
was. (In future, expect the remaining code in here to move into
mod/quiz/classes.)
2014-10-02 17:22:23 +01:00
Mark Nelson
5e8f736565 MDL-40063 mod_quiz: replaced 'editquestions' add_to_log call with an event 2014-04-10 20:34:27 -07:00
Dan Poltawski
a59b2e18d8 Merge branch '44180-27' of git://github.com/samhemelryk/moodle 2014-03-05 12:47:17 +08:00
Sam Hemelryk
01773a6d00 MDL-44180 mod_quiz: unified @package use 2014-03-03 08:37:06 +13:00
Tim Hunt
ccba5b8805 MDL-43749 normalise quiz database structure.
The sequence of questions that made up a quiz used to be stored as a
comma-separated list in quiz.questions. Now the same information is
stored in the rows in the quiz_slots table. This is not just 'better' in
a database design sense, but it allows for the future changes we will
need as we enhance the quiz in the MDL-40987 epic.

Having changed the database structure, all the rest of the code needs to
be changed to account for it, and that is done here.

Note that there are not many unit tests for the changed bit. That is
because as part of MDL-40987 we will be changing the code further, and
we will add unit tests then.
2014-03-02 10:00:40 +01:00
Tim Hunt
9fc29eec6d MDL-39282 quiz: always allow removal of bogus questions. 2013-03-01 17:33:32 +00:00
Mary Evans
bd5d8b5041 MDL-29723 mod/quiz: Modified show/hide button in edit.php and added some extra CSS rules to styles.css to make Question bank block more compatible/adaptable with themes. 2013-01-22 16:17:11 +00:00
Ankit Agarwal
d197ea4300 MDL-34549 libraries: Replace get_context_instance_by_id() by context::instance_by_id() 2012-08-24 11:30:10 +08:00
Petr Škoda
f387bb9bb7 MDL-34741 use 2in3 in mod_quiz 2012-08-11 20:40:09 +02:00
Rajesh Taneja
1e12c1203b MDL-30651 libraries: Replaced deprecated PARAM_INTEGER with PARAM_INT 2012-07-19 15:37:46 +08:00
Dan Poltawski
8409bd51f4 Merge branch 'MDL-33612' of git://github.com/timhunt/moodle 2012-06-12 17:38:25 +08:00
Tim Hunt
4c7f377d9b MDL-33612 quiz: Improve page title 'Editing quiz'
Include the quiz name in the title. Also, add two missing format_string
calls around $quiz->name.
2012-06-08 11:47:03 +01:00
Tim Hunt
7f5f384477 MDL-33532 quiz editing: let uses enter locale floats.
So, for example, Croatian users can set the maximum grade to 65,5.
2012-06-07 12:55:53 +01:00
Tim Hunt
9e83f3d11d MDL-32788 quiz: clean up codechecker issues before the 2.3 release. 2012-05-04 15:12:23 +01:00
Tim Hunt
76cf77e4d3 MDL-32240 quiz editing: check permissions questions are added.
We also check permissions when removing questions from the quiz, so that
we do not let users make mistakes they cannot immediately undo.
2012-03-29 14:14:12 +01:00
Sam Hemelryk
d36b5d1177 Merge branch 'MDL-31095' of git://github.com/timhunt/moodle 2012-01-16 16:58:32 +08:00
Dan Poltawski
a530d4a93b MDL-29091 quiz - switch to use moodle_url::out_as_local_url 2012-01-13 10:16:52 +00:00
Tim Hunt
18dff75754 MDL-31095 quiz editing: only set quiz->grade to 0 if really necessary.
It is only necessary when there are (non-preview) attempts. However,
after making this change we have to ensure users cannot start attempts
when ->grade > 0 and ->sumgrades = 0.

Display ->grade on the order and paging tab of edit.php, so it is clear
what is going on when you are using that tab.

Finally, improve the error message a student gets if they try to start a
quiz with no questions.
2012-01-12 12:10:08 +00:00
Tim Hunt
800944b015 MDL-29176 quiz editing: can't move questions onto a new page. 2011-12-15 19:32:37 +00:00
Tim Hunt
e20ad67d7b MDL-29141 question bank show question text checkbox does not match state. 2011-08-26 17:01:06 +01:00
Tim Hunt
b72b413759 MDL-28604 Question bank display forgets sort order 2011-08-04 13:53:02 +01:00
Tim Hunt
4bf1be3596 MDL-28437 Question bank pages should all use General type: admin. 2011-07-25 08:50:06 +01:00
Tim Hunt
612106b3a4 MDL-20636 fix URL handling for previews to always use Moodle URL.
Also, make the preview window big enough. #367
2011-05-27 11:49:23 +01:00
Tim Hunt
25a03faaca MDL-20636 fix many code-checker issues in mod/quiz. 2011-05-12 00:30:25 +01:00
Tim Hunt
0ff4bd0877 MDL-20636 Fix new stdClass -> stdClass(), and trailing whitespace. 2011-02-21 18:10:19 +00:00
Tim Hunt
ba6438471b MDL-20636 Fix top of file boilerplate in mod/quiz. 2011-02-21 16:13:25 +00:00
Tim Hunt
fd214b596d MDL-20636 Preserve scroll position when doing action on the quiz edit page. 2011-02-11 17:36:02 +00:00
Tim Hunt
f9b0500f7f MDL-20636 Quiz editing now works, as does the random question type.
However, all this needs more testing.

Also, a bit of a purge of training whitespace and global .
2011-02-10 20:50:18 +00:00
Tim Hunt
f2956c9813 quiz editing MDL-25391 creating a new question and adding it directly to the quiz was broken.
Thanks to Chad Outten for finding this before it was too late, and skodak for the review.
2010-11-24 09:05:22 +00:00
Tim Hunt
94dbfb3a82 quiz editing MDL-24750 The Add random button should also let you add questions from an existing category.
Also includes a fix for MDL-24749 by Sam Hemelryk. Thanks Sam.

This commit also includes a certain amount of code cleaning up.
2010-11-22 09:52:42 +00:00
Tim Hunt
16cad79ba9 quiz editing MDL-25205 help for the order and paging page. 2010-11-15 17:00:38 +00:00
Tim Hunt
eb02301a36 mod_quiz / navigation MDL-20276 further polishing the quiz navigation structure. 2010-08-04 16:31:54 +00:00
David Mudrak
7292c11f51 MDL-21695 quiz: deprecated setHelpButton() and old_help_icon() replaced with new calls
Some help icons dropped without replacement as suggested by Helen, the
Help Writer. Some strings moved to core_question.

AMOS BEGIN
 HLP quiz/timelimit.html,[timelimit_help,mod_quiz]
 HLP quiz/grademethod.html,[grademethod_help,mod_quiz]
 HLP quiz/questionsperpage.html,[newpage_help,mod_quiz]
 HLP quiz/shufflewithin.html,[shufflewithin_help,mod_quiz]
 HLP quiz/penaltyscheme.html,[penaltyscheme_help,mod_quiz]
 HLP quiz/repeatattempts.html,[eachattemptbuildsonthelast_help,mod_quiz]
 HLP quiz/reviewoptions.html,[reviewoptionsheading_help,mod_quiz]
 HLP quiz/showuserpicture.html,[showuserpicture_help,mod_quiz]
 HLP quiz/decimalpoints.html,[decimalplaces_help,mod_quiz]
 HLP quiz/decimalplacesquestion.html,[decimalplacesquestion_help,mod_quiz]
 HLP quiz/requirepassword.html,[requirepassword_help,mod_quiz]
 HLP quiz/requiresubnet.html,[requiresubnet_help,mod_quiz]
 HLP quiz/timedelay1.html,[delay1st2nd_help,mod_quiz]
 HLP quiz/timedelay2.html,[delaylater_help,mod_quiz]
 HLP quiz/overallfeedback.html,[overallfeedback_help,mod_quiz]
 HLP quiz_statistics/negcovar.html,[negcovar_help,quiz_statistics]
 MOV [penaltyfactor,mod_quiz],[penaltyfactor,core_question]
 MOV [penaltyfactor_help,mod_quiz],[penaltyfactor_help,core_question]
 HLP quiz/penalty.html,[penaltyfactor_help,core_question]
AMOS END
2010-08-02 20:56:15 +00:00
Tim Hunt
a49cb927fd NOBUG more consistent use of URLs for the quiz reports. 2010-07-28 15:08:34 +00:00
Tim Hunt
1a0e96c708 quiz edit: MDL-22651 apply mudrd8mz's fix. Thanks David. 2010-06-06 07:18:32 +00:00
Sam Hemelryk
56ed242b51 navigation MDL-20276 Fixed up the navigation for the quiz module and question section as per Tim's recommendation.
* Routine navigation through the quiz and question modules
* Fixed navbar through quiz and questions
* Pages headers added throughout
* Added method to turn a navigation node into a tabs array suitable for use with print tabs
2010-05-21 03:15:48 +00:00
Sam Hemelryk
6605ff8cda themes MDL-22358 Renamed sideblock class to block 2010-05-06 06:16:07 +00:00
Tim Hunt
455d765f87 quiz editing: MDL-20263 When adding a new question directly to the quiz, highlight it in the question bank. 2010-05-01 08:23:28 +00:00
Petr Skoda
596509e431 MDL-21695 renaming ->help_icon() to old_help_icon() and going to introduce new help_icon() with new parameters and detailed debugging - hopefully this will help during the conversion to new help 2010-04-13 20:34:27 +00:00
Tim Hunt
453b28d818 Fix $PAGE->set_url initialisation order. 2010-04-12 13:31:42 +00:00
Petr Skoda
d9df2a8993 MDL-20204 fixed regression 2010-02-11 10:24:59 +00:00
Petr Skoda
3224f709d7 MDL-20204 selects conversion 2010-02-11 10:03:28 +00:00