29491 Commits

Author SHA1 Message Date
tjhunt
13ccb7bd58 MDL-12133 - Errors calling parent::validation in a moodle form subclass because the base class method returns true not an empty array. This patch allow subclasses to start their validate method with
$errors = parent::validation($data, $files);

which is what you naturally want to do if you are used to object oriented programming.

Merged from MOODLE_19_STABLE.
2007-11-20 15:08:05 +00:00
tjhunt
ea16c547ee Remove a developer debug notice and save a database query. Merged from MOODLE_19_STABLE. 2007-11-20 14:46:50 +00:00
nfreear
5cfea9fbae Follow up for MDL-12256, "Course AJAX has very poor accessibility - ALT text" - IE tooltip/ title hack. 2007-11-20 14:37:58 +00:00
ethem
488bc5f51b Fix for Canadian Postal Code
http://moodle.org/mod/forum/discuss.php?d=81736
2007-11-20 13:22:39 +00:00
tjhunt
fe93ba838b MDL-12133 - Errors calling parent::validation in a moodle form subclass because the base class method signature was changed. This patch fixes all calls to parent::validation in the question editing forms. Merged from MOODLE_19_STABLE. 2007-11-20 12:41:04 +00:00
scyrma
828f84cf9a Makes it possible to confirm users using manual auth system. 2007-11-20 05:28:33 +00:00
toyomoyo
d052434c4f fixing header/formatting 2007-11-20 05:16:11 +00:00
moodler
b2d735f130 Automatic installer.php lang files by installer_builder (20071120) 2007-11-20 05:05:51 +00:00
toyomoyo
001f36522c MDL-12234, fixing unicode issues with global search 2007-11-20 04:12:18 +00:00
pichetp
705b5874ce MDL-12255 Adding questiontext decoding and subquestions validation when editing 2007-11-20 03:50:28 +00:00
pichetp
e9028ffc87 Solving MDL-12063 qtype_questions where left orphans when questions whe deleted or
qtype change
2007-11-20 03:48:29 +00:00
mattc-catalyst
1a5bc8ae5a MDL-12264 - course/info: check if course is hidden before displaying info about it.
Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-11-20 02:32:09 +00:00
martinlanghoff
9b86470e53 MDL-12142 mailout-debugger: Now works on Windows too
Switched to use sys_get_temp_dir() to define
which tempdir to use.
2007-11-20 00:31:40 +00:00
martinlanghoff
4f957b116d accesslib: has_capability_in_accessdata() respects rdef locality a bit more
With this patch, we respect rdef locality when two roles
assignments in the same context have conflicting rdefs.
In that case, the most local rdef wins.

So RA locality still matters most. If you are a teacher
sitewide and a student in course X, student role trumps
teacher.

For a use case, see the discussion here
http://moodle.org/mod/forum/discuss.php?d=84472

Notes:

- If we wanted to have locality of RDEF trump everything
  we can. A comment in this patch shows how.

- I don't know how to reproduce this in pure SQL.

And Also:

This patch also fixes a bug where if CAP_PROHIBIT was set
_and_ another role added to it in the same context, we would
add or substract 1 to CAP_PROHIBIT, and it would lose its magic.

And while at it, tighten the code to avoid casts. All the
ints are unambiguously ints.
2007-11-20 00:18:31 +00:00
stronk7
9126bd7ee9 Some question formating...
Merged from MOODLE_19_STABLE
2007-11-20 00:10:05 +00:00
skodak
0112ed8e0d MDL-12249 fixed distribution for small groups; merged from MOODLE_19_STABLE 2007-11-19 22:55:39 +00:00
skodak
9509119b0e MDL-12249 fixed small group ration, can be overriden from config.php now; merged from MOODLE_19_STABLE 2007-11-19 21:41:02 +00:00
skodak
f16fa0a34b MDL-12249 groups UI cleanup and improvements - see tracker for details; merged from MOODLE_19_STABLE 2007-11-19 20:31:57 +00:00
diml
b9ce88c74c fix some keys 2007-11-19 20:09:38 +00:00
nfreear
f8eaeffa21 Fixes for bug MDL-12256, "Course AJAX has very poor accessibility - ALT text" (includes white-space cleanup). 2007-11-19 17:22:04 +00:00
nfreear
f7a5b3ad3a Fixes for bug MDL-12256, "Course AJAX has very poor accessibility - ALT text". 2007-11-19 17:21:28 +00:00
nfreear
11599e476d Initial fix for MDL-12256, "Course AJAX has very poor accessibility - ALT text" - test, imgAttributes.length NOT attributes.length. 2007-11-19 15:25:16 +00:00
sam_marshall
9b50bd46ad MDL-12075 Display individually colour-coded events in calendar rather than random day colours 2007-11-19 10:53:23 +00:00
moodler
21090e447a Merged from 1.9
Improvements to the tabs for assigning and overriding roles.   MDL-12120

Tabs are now all on the top row
Tabs have clearer titles
Other help texts improved
2007-11-19 07:13:02 +00:00
moodler
b8faa9a7d1 Merged fixes for override colouring MDL-12248 2007-11-19 06:59:19 +00:00
scyrma
a9237b8b45 MDL-3632 : this prevents people without mod/forum:viewhiddentimedposts to see hiddentimedposts. 2007-11-19 04:44:08 +00:00
toyomoyo
f2bcb0815d MDL-12218, display course specific role names on override page 2007-11-19 04:36:21 +00:00
toyomoyo
ed61510be6 changed to get_recordset_sql because get_records forces the first element to be$ 2007-11-19 04:13:15 +00:00
martinlanghoff
0cbcc8efc1 user_login() was not converted to using get_cache_flags().
It was still using the 'old' get_config() interface, so the 'cookie'
set by ntlmsso_finish() wasn't retrieved at all, and the automatic
login always failed.

Signed-off-by: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>


Author: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>
Committer: Martin Langhoff <martin@catalyst.net.nz>
2007-11-19 02:43:48 +00:00
martinlanghoff
58eada356d If the cache flag is not set, it doesn't make sense trying to test its value
Signed-off-by: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>


Author: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>
Committer: Martin Langhoff <martin@catalyst.net.nz>
2007-11-19 02:43:34 +00:00
martinlanghoff
a44240fa89 Fix typo in ntlmsso_finish()
Signed-off-by: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>


Author: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>
Committer: Martin Langhoff <martin@catalyst.net.nz>
2007-11-19 02:43:16 +00:00
toyomoyo
6bb7689ff9 merged fix for MDLSITE-294, needs a forced type cast 2007-11-19 02:25:22 +00:00
mattc-catalyst
6779dc6a02 MDL-12172: fixed get parameters not being submitted in Firefox
Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-11-19 01:45:45 +00:00
toyomoyo
5bbf18cd6f changed to get_recordset_sql because get_records forces the first element to be key 2007-11-19 01:44:26 +00:00
toyomoyo
f7bd8c758f making a SQL cross-db compatible 2007-11-19 01:13:31 +00:00
stronk7
d4775d5495 Merging unmerged code. MDL-11743 and MDL-11671 2007-11-18 17:12:58 +00:00
iarenaza
41079ed4bb MDL-11099 and MDL-11655 Don't show external db password in clear 2007-11-18 12:45:21 +00:00
moodler
7cec2e57f3 Automatic installer.php lang files by installer_builder (20071118) 2007-11-18 04:36:52 +00:00
skodak
afdde5a117 MDL-12231 fixed applying of CFG defaults during initial install phase; merged from MOODLE_19_STABLE 2007-11-17 21:21:37 +00:00
skodak
64f592adf3 fixed typo throwing warnings during install; merged from MOODLE_19_STABLE 2007-11-17 20:55:44 +00:00
skodak
3541cecb66 MDL-12041 fixed groupmode flag in cm when mode forced in course; merged from MOODLE_19_STABLE 2007-11-17 17:41:28 +00:00
skodak
4050572d56 MDL-10888 parent definition_after_data() must be called too!; merged from MOODLE_19_STABLE 2007-11-17 16:53:39 +00:00
skodak
71198086c3 MDL-12221 initialised $output and fixed whitespace; merged from MOODLE_19_STABLE 2007-11-17 16:37:00 +00:00
skodak
7c9b1d315d MDL-12199 problem with "Show advanced" used after pressing of enter in forms; merged from MOODLE_19_STABLE 2007-11-17 13:30:15 +00:00
skodak
6ba472cd65 MDL-12146 merged recent changes from normal item to outcome form; merged from MOODLE_19_STABLE 2007-11-16 22:15:25 +00:00
skodak
1b452baf24 MDL-12200 fixed problems when no custom user fields defined; merged from MOODLE_19_STABLE 2007-11-16 22:12:04 +00:00
dwoolhead
1c0d9b6677 MDL-12226 forum index page not always displaying forum links or subscription buttons as expected 2007-11-16 17:03:06 +00:00
nfreear
8fee6c60c8 Fixes bug MDL-12225, Mark up lists correctly in course/lib (accessibility). 2007-11-16 16:47:54 +00:00
dwoolhead
01cbbbd70a MDL-11979 Forum subscriptions loop hole allowing users to subscribe to forums they should not have access to. 2007-11-16 16:31:00 +00:00
mits
26966d4026 Removed styles_layout.css from theme oceanblue.
Updated config.php for theme oceanblue.
2007-11-16 14:51:34 +00:00